From: Marek Vasut <marek.vasut@mailbox.org>
To: peng.fan@nxp.com, shawnguo@kernel.org, Frank.li@nxp.com
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
robh@kernel.org, s.hauer@pengutronix.de,
Rain Yang <jiyu.yang@oss.nxp.com>
Subject: Re: [PATCH] arm64: dts: imx95: Use GPU_CGC as core clock for GPU
Date: Tue, 30 Dec 2025 02:53:38 +0100 [thread overview]
Message-ID: <53ea529f-3538-4ab5-aa99-0caa6729b4cd@mailbox.org> (raw)
In-Reply-To: <aTYxm_dfMwF4H0_b@oss.nxp.com>
On 12/8/25 3:02 AM, Rain Yang wrote:
>>> Okay, I’ll submit a patch later.
>>> The commit message should reflect that only CLK_GPU_CGC is enabled.
>>
>> The commit message , and this change , is unrelated to GPUAPB clock.
> The commit message is ambiguous. Could you clarify which parent clock
> you are referring to, and whether it can be enabled by CLK_GPU_CGC?
> If it was CLK_GPU, CLK_GPU_CGC can't be able to control it.
The commit message clearly states "These new GPU_CGC clock
gate the existing GPU clock." and "GPU_CGC as well as its parent GPU
clock." , I don't perceive any ambiguity, sorry.
Frankly, the whole GPUAPB discussion is entirely unrelated and it only
stalls application of this bugfix and keeps upstream broken. This is not
helping.
So unless there is anything in particular that is on-topic and prevents
this patch from being applied, it would be good to apply it, otherwise
the GPU on MX95 in mainline Linux is not working.
next prev parent reply other threads:[~2025-12-30 1:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 14:31 [PATCH] arm64: dts: imx95: Use GPU_CGC as core clock for GPU Marek Vasut
2025-12-03 2:48 ` Rain Yang
2025-12-03 3:38 ` Marek Vasut
2025-12-03 9:28 ` Rain Yang
2025-12-03 22:48 ` Marek Vasut
2025-12-04 3:01 ` Rain Yang
2025-12-04 3:25 ` Marek Vasut
2025-12-05 8:17 ` Rain Yang
2025-12-07 9:01 ` Marek Vasut
2025-12-08 2:02 ` Rain Yang
2025-12-30 1:53 ` Marek Vasut [this message]
2025-12-30 2:53 ` Rain Yang
2025-12-30 14:17 ` Marek Vasut
2025-12-31 3:06 ` Rain Yang
2025-12-31 14:09 ` Marek Vasut
2026-01-17 5:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ea529f-3538-4ab5-aa99-0caa6729b4cd@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jiyu.yang@oss.nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox