From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D55C1428E7 for ; Thu, 28 Nov 2024 10:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.19.9.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732791449; cv=none; b=AIFAz/dqXv0RHvKxPaqKJbwGCqzSliRRt0oC5OR0SuA/T7sHvfo+OXQetn5vpeamzX4CZSd12/QUshPOnCAf+Ir8lAsvF7t9hZWJV3o2fKU4NSdnB5D043yMvGr7LjOdFhUGBYQT5LbrtK5K+U0OwavyF/x4awbLZ6xds6iljNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732791449; c=relaxed/simple; bh=wlA5czvcbRh5+RTGwducbEagxk6hSXBSIdSDTwo+DDM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sj7j75NwXioNpTtp/rMJfltChsvquFqiYG6qN519W56oE3ZC9fQDYnJBlXCONgPrVxF6Xb+CSJnuiPY5cEwwoSomN4Ifdr12ar3WQxTJbaB7DM2wejqblwWkwYAUflieOApiwhv8g3uw+ZOZZu//TU7qaKVm9n0amaTr/iCEEH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=norik.com; spf=pass smtp.mailfrom=norik.com; arc=none smtp.client-ip=46.19.9.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=norik.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=norik.com Received: from [89.212.21.243] (port=43044 helo=[192.168.69.52]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1tGcD1-00CJZu-1K; Thu, 28 Nov 2024 11:57:18 +0100 Message-ID: <56f9bee2-74bd-4150-abab-fbc1459d7e36@norik.com> Date: Thu, 28 Nov 2024 11:57:16 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add optional property ti,lvds-vcom To: Maxime Ripard Cc: Rob Herring , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20241127103031.1007893-1-andrej.picej@norik.com> <20241127103031.1007893-2-andrej.picej@norik.com> <20241127151630.GA3515396-robh@kernel.org> <3b5768e5-dcb6-436d-837c-418676e13b2e@norik.com> <20241128-mottled-nostalgic-oriole-be31ce@houat> Content-Language: en-US From: Andrej Picej Autocrypt: addr=andrej.picej@norik.com; keydata= xsDNBGa0T6ABDAC4Acdg6VCJQi1O9x5GxXU1b3hDR/luNg85c1aC7bcFhy6/ZUY9suHS/kPF StNNiUybFZ2xE8Z18L+iQjNT3klDNUteroenx9eVhK5P1verK4GPlCB+nOwayoe/3ic5S9cC F76exdEtQHIt4asuwUJlV1IARn2j30QQ/1ZDVsw2FutxmPsu8zerTJAZCKPe6FUkWHaUfmlw d+DAdg3k33mVhURuiNfVrIHZ+Z9wrP6kHYS6nmBXNeAKy6JxJkJOUa4doBZFsvbQnNoPJTeF R/Pc9Nr5dRlFjq/w0RQqOngdtA2XqXhqgsgzlOTCrHSzZXqtwyRQlbb0egom+JjyrfakQa/L exUif7hcFiUdVImkbUwI4cS2/prNHu0aACu3DlLxE0I9fe/kfmtYWJLwMaI6pfuZdSL5N49y w+rllYFjOuHYEmyZWDBRKPM7TyPVdlmt6IYXR09plqIifc0jXI6/543Hjt8MK4MZSke6CLGn U9ovXDrlmTh5h8McjagssVsAEQEAAc0lQW5kcmVqIFBpY2VqIDxhbmRyZWoucGljZWpAbm9y aWsuY29tPsLBBwQTAQgAMRYhBFPRdFhqlu6CXugSybrG0Hq8HZyTBQJmtE+hAhsDBAsJCAcF FQgJCgsFFgIDAQAACgkQusbQerwdnJPi0QwAjuxLXKbt0KP6iKVc9dvycPDuz87yJMbGfM8f 6Ww6tY3GY6ZoQB2SsslHyzLCMVKs0YvbxOIRh4Hjrxyx7CqxGpsMNEsmlxfjGseA1rFJ0hFy bNgCgNfR6A2Kqno0CS68SgRpPy0jhlcd7Tr62bljIh/QDZ0zv3X92BPVxB9MosV8P/N5x80U 1IIkB8fi5YCLDDGCIhTK6/KbE/UQMPORcLwavcyBq831wGavF7g9QV5LnnOZHji+tPeWz3vz BvQyz0gNKS784jCQZFLx5fzKlf5Mixkn1uCFmP4usGbuctTo29oeiwNYZxmYMgFANYr+RlnA pUWa7/JAcICQe8zHKQOWAOCl8arvVK2gSVcUAe0NoT6GWIuEEoQnH9C86c+492NAQNJB9nd1 bjUnFtjRKHsWr/Df11S26o8XT5YxFhn9aLld+GQcf07O/MWe+G185QSjKdA5jjpI459EPgDk iK4OSGx//i8n4fFtT6s+dbKyRN6z9ZHPseQtLsS7TCjEzsDNBGa0T6EBDAClk5JF2904JX5Z 5gHK28w+fLTmy8cThoVm3G4KbLlObrFxBy3gpDnSpPhRzJCbjVK+XZm2jGSJ1bxZxB/QHOdx F7HFlBE2OrO58k7dIB+6D1ibrHy++iZOEWeoOUrbckoSxP2XmNugPC1ZIBcqMamoFpz4Vul1 JuspMmYOkvytkCtUl+nTpGq/QHxF4N2vkCY7MwtY1Au6JpeJncfv+VXlP3myl+b4wvweDCWU kqZrd6a+ePv4t8vbb99HLzoeGCuyaBMRzfYNN4dMbF29QHpvbvZKuSmn5wZIScAWmwhiaex9 OwR6shKh1Eypw+CUlDbn3aieicbEpLgihali8XUcq5t6dGmvAiqmM7KpfeXkkE1rZ4TpB69+ S2qiv2WgSIlUizuIx7u1zltCpEtp0tgTqrre8rVboOVHAytbzXTnUeL/E8frecJnk4eU3OvV eNDgjMe2N6qqfb6a2MmveM1tJSpEGYsOiYU69uaXifg5th7kF96U4lT24pVW2N2qsZMAEQEA AcLA9gQYAQgAIBYhBFPRdFhqlu6CXugSybrG0Hq8HZyTBQJmtE+iAhsMAAoJELrG0Hq8HZyT 4hAL/11F3ozI5QV7kdwh1H+wlfanHYFMxql/RchfZhEjr1B094KN+CySIiS/c63xflfbZqkb 7edAAroi78BCvkLw7MTBMgssynex/k6KxUUWSMhsHz/vHX4ybZWN15iin0HwAgQSiMbTyZCr IEDf6USMYfsjbh+aXlx+GyihsShn/dVy7/UP2H3F2Ok1RkyO8+gCyklDiiB7ppHu19ts55lL EEnImv61YwlqOZsGaRDSUM0YCPO6uTOKidTpRsdEVU7d9HiEiFa9Se3Y8UeiKKNpakqJHOlk X2AvHenkIyjWe6lCpq168yYmzxc1ovl0TKS+QiEqy30XJztEAP/pBRXMscQtbB9Tw67fq3Jo w4gWiaZTJM2lirY3/na1R8U0Qv6eodPa6OqK6N0OEdkGA1mlOzZusZGIfUyyzIThuLED/MKZ /398mQiv1i++TVho/54XoTtEnmV8zZmY25VIE1UXHzef+A12P9ZUmtuA3TOdDemS5EXebl/I xtT/8OxBOVSHvA== In-Reply-To: <20241128-mottled-nostalgic-oriole-be31ce@houat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.linux.dev X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: Hi Maxime, On 28. 11. 24 11:29, Maxime Ripard wrote: > On Thu, Nov 28, 2024 at 09:46:33AM +0100, Andrej Picej wrote: >> On 27. 11. 24 16:16, Rob Herring wrote: >>> On Wed, Nov 27, 2024 at 11:30:29AM +0100, Andrej Picej wrote: >>>> From: Janine Hagemann >>>> >>>> Add an optional property to change LVDS output voltage. This depends on >>>> the connected display specifications. With this property we directly set >>>> the LVDS_VCOM (0x19) register. >>>> Better register property mapping would be quite tricky. Please check >>>> bridge's datasheet for details on how register values set the LVDS >>>> data lines and LVDS clock output voltage. >>>> >>>> Signed-off-by: Janine Hagemann >>>> Signed-off-by: Andrej Picej >>>> --- >>>> .../bindings/display/bridge/ti,sn65dsi83.yaml | 14 +++++++++++++- >>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml >>>> index 48a97bb3e2e0..5b2c0c281824 100644 >>>> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml >>>> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml >>>> @@ -58,6 +58,12 @@ properties: >>>> - const: 2 >>>> - const: 3 >>>> - const: 4 >>>> + ti,lvds-vcom: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + description: LVDS output voltage configuration. This defines >>>> + LVDS_VCOM (0x19) register value. Check bridge's datasheet for >>>> + details on how register values set the LVDS data lines and >>>> + LVDS clock output voltage. >>> >>> Constraints? 0 - 2^32 are all valid values? >> >> Not really, only first 6 bits, which also means that this can be uint8 then. >> Will fix with other issues. > > Also, generally speaking directly using register values is really > frowned upon, even more so when they match a value expressed in a > standard unit. Yes, I am aware that this is not how devide-tree/device drivers should work. But setting this values based on wanted LVDS voltage will be quite tricky. Matching a value expressed in mV would be quite hard, take a look in the bridge datasheet [1], Chapter 6.5 Electrical Characteristics (|VOD|). Basically both: - LVDS data line output and - LVDS clock voltage is determined by the CSR 0x19.3:2. So when checking which Reg setting CSR 0x19 should be set to both conditions should meet specifications of the connected display. Output voltage for the same CSR 0x19 setting differs between LVDS data lines and LVDS clock. Anyway, I'll prepare a v2 which only sets a part of this register, a bitfield (2 bits) that is responsible for LVDS differential output voltage. [1] https://www.ti.com/lit/ds/symlink/sn65dsi83.pdf?ts=1732738773429&ref_url=https%253A%252F%252Fwww.mouser.co.uk%252F Best regards, Andrej > > Maxime