Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Clemens Gruber <mail@clemensgruber.at>,
	wei.fang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org
Cc: shenwei.wang@nxp.com, xiaoning.wang@nxp.com, imx@lists.linux.dev,
	netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH v2] net: fec: account for VLAN header in frame length calculations
Date: Thu, 22 Jan 2026 13:23:53 +0100	[thread overview]
Message-ID: <578b5c27-0db5-4185-ad3b-cb35bf864d18@redhat.com> (raw)
In-Reply-To: <20260121083751.66997-1-mail@clemensgruber.at>

On 1/21/26 9:37 AM, Clemens Gruber wrote:
> The MAX_FL (maximum frame length) and related calculations used ETH_HLEN,
> which does not account for the 4-byte VLAN tag in tagged frames. This
> caused the hardware to reject valid VLAN frames as oversized, resulting
> in RX errors and dropped packets.
> 
> Use VLAN_ETH_HLEN instead of ETH_HLEN in the MAX_FL register setup,
> cut-through mode threshold, buffer allocation, and max_mtu calculation.
> 
> Cc: stable@kernel.org # v6.18+
> Fixes: 62b5bb7be7bc ("net: fec: update MAX_FL based on the current MTU")
> Fixes: d466c16026e9 ("net: fec: enable the Jumbo frame support for i.MX8QM")
> Fixes: 59e9bf037d75 ("net: fec: add change_mtu to support dynamic buffer allocation")
> Fixes: ec2a1681ed4f ("net: fec: use a member variable for maximum buffer size")
> Signed-off-by: Clemens Gruber <mail@clemensgruber.at>

A couple of things to remember for future submissions: you should
include the target tree into the subj prefix ('net' in this case) and
you should avoid sending you revision in reply to older ones as it may
foul patchwork.

No repost needed, the patch looks good, I'm applying it.

Thanks,

Paolo


  parent reply	other threads:[~2026-01-22 12:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 16:04 [PATCH] net: fec: account for VLAN header in MAX_FL calculation Clemens Gruber
2026-01-21  1:57 ` Wei Fang
2026-01-21  8:37 ` [PATCH v2] net: fec: account for VLAN header in frame length calculations Clemens Gruber
2026-01-22  6:07   ` Wei Fang
2026-01-22 12:23   ` Paolo Abeni [this message]
2026-01-22 12:30   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578b5c27-0db5-4185-ad3b-cb35bf864d18@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=mail@clemensgruber.at \
    --cc=netdev@vger.kernel.org \
    --cc=shenwei.wang@nxp.com \
    --cc=stable@kernel.org \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox