From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468B41FCF73; Wed, 13 Nov 2024 12:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731500364; cv=none; b=Vtou7HCC/zRX9zmzb52mMy7AOYMKLMw7Z+Uo0b24nKJX4le7MS2yDuqfe6OXYfIX/eEgDF/Bg8eZFQsVyIKf3bXODAiSGL3WIxDvccNHNZOAxOrEkdv1WyiUkNs5EXrzfpL07oDAHGeaEn7htb04lMWp4W6tOBPzFLf5qA0S7O8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731500364; c=relaxed/simple; bh=MRfrMS2NSXnwvk0Sf7GaU1O/RZZoM1ZJQOA8Qn8wyr8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FIuwwGeqEY/Y4a4Oc30trrHOaE5l1LAONTG596at6TzuaSdw6zd+hB45SjubfxUyOBzGTrUcnNNGEnusyyYxq+w/HdwqhaZxetC4qElC5+Fmi6hxMoWRS8z2TEK1OoIal8mgAsx/uRr6diXAYzP/LnyGoPCImzqqKc3IgyQhWIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c6uQKSE+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c6uQKSE+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 195F3C4CECD; Wed, 13 Nov 2024 12:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731500363; bh=MRfrMS2NSXnwvk0Sf7GaU1O/RZZoM1ZJQOA8Qn8wyr8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=c6uQKSE+Z8mVuqF3X2BreB9nkrA++x9ggOBttAbYhtUrRuA2+XptAHGTOCXyuBqQx RU9Bq2baf/NZ3gDA/OkAOflg3+RNv+GiTWLZn3FGWRtATVARpmhL5fWjr5exTvgtNb M3QKmQiH60HK+TRUqjR2kj+7mGwM8qdGFmE7gcVGRClz1O1wBLlrMKU0xZBxUDSRY4 Ap/bVjhmf6rqG0NasSnosbsJs/qL2UGqNwgmvNsp6+To9y+AlMFvQNBj5u5D210RAr NWoWOVm7CSZYGhogLH2tKBUVkKCZluF4qGb56xaGI9h06zw9l9gyGnHVfaF7K0XWlP g0fAdRyO0YlWQ== Message-ID: <5e54aa43-8299-4166-8724-ebe48a9a9747@kernel.org> Date: Wed, 13 Nov 2024 13:19:18 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] samples: pktgen: correct dev to DEV To: Wei Fang Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "lorenzo@kernel.org" References: <20241112030347.1849335-1-wei.fang@nxp.com> <0cde0236-c539-487d-a212-b660331d3683@kernel.org> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/11/2024 11.06, Wei Fang wrote: >> On 12/11/2024 04.03, Wei Fang wrote: >>> In the pktgen_sample01_simple.sh script, the device variable is >>> uppercase 'DEV' instead of lowercase 'dev'. Because of this typo, the >>> script cannot enable UDP tx checksum. >>> >>> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support") >>> Signed-off-by: Wei Fang >>> --- >>> samples/pktgen/pktgen_sample01_simple.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/samples/pktgen/pktgen_sample01_simple.sh >>> b/samples/pktgen/pktgen_sample01_simple.sh >>> index cdb9f497f87d..66cb707479e6 100755 >>> --- a/samples/pktgen/pktgen_sample01_simple.sh >>> +++ b/samples/pktgen/pktgen_sample01_simple.sh >> >> Why are you only fixing one script? >> > > Other scripts are correct, because they are all multi-threaded, "dev" is > defined for each thread like below. > > dev=${DEV}@${thread} > Good point! - then this patch is enough :-) Acked-by: Jesper Dangaard Brouer Thanks for fixing this, --Jesper