From: Andrew Lunn <andrew@lunn.ch>
To: "Csókás, Bence" <csokas.bence@prolan.hu>
Cc: Frank Li <Frank.Li@freescale.com>,
"David S. Miller" <davem@davemloft.net>,
imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down
Date: Wed, 12 Jun 2024 21:16:13 +0200 [thread overview]
Message-ID: <5fa9fadc-a89d-467a-aae9-c65469ff5fe1@lunn.ch> (raw)
In-Reply-To: <20240611080405.673431-1-csokas.bence@prolan.hu>
On Tue, Jun 11, 2024 at 10:04:05AM +0200, Csókás, Bence wrote:
> FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which
> makes all 1588 functionality shut down, and all the extended registers
> disappear, on link-down, making the adapter fall back to compatibility
> "dumb mode". However, some functionality needs to be retained (e.g. PPS)
> even without link.
>
> Fixes: 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock")
> Cc: Richard Cochran <richardcochran@gmail.com>
>
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-06-12 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 8:04 [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down Csókás, Bence
2024-06-12 19:16 ` Andrew Lunn [this message]
2024-06-13 15:12 ` Jakub Kicinski
2024-06-14 7:59 ` Csókás Bence
2024-06-15 1:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fa9fadc-a89d-467a-aae9-c65469ff5fe1@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Li@freescale.com \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox