From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21DCF3C3C00 for ; Mon, 31 Aug 2026 07:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788160826; cv=none; b=UC/qj7xV0LQ8eqqzbCrp6VT0Obrv5rgXf9lGae2yOY5M2g4tR0v8lUX7MCIT/o4KRJWDJUrfqLPRGRSdO7Vb/myR3NFXNH1EHX2pPf91t7QRA86ogRJc77krXDFOh8nW6UOjR8HHg6xaeFpKrijHxV+Sj8B9qMBzBJwPLaiQH1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788160826; c=relaxed/simple; bh=h8J2NrchB0Z1iFN/dkUbMfkCPgIc00ZPMgcFXxFod04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EcXSlie68HFqq8ZBlF36WpyFhrp17Ug5iuGRyrk1cvO30Y7Pzd3XfDmziXMKmQ8LJk8m3GCDTAyuN2W/9GfKZK4ByZ9QeXDFsgLaA0BaWppbGC4LCYivq7iFBbKqVfiFz5H/fOKhTeR+UpQ6w0RJHeps4mxsqbJ7tjUa2/2JgSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T+KK612L; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jymEqclr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T+KK612L"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jymEqclr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67V52Vi02680012 for ; Mon, 31 Aug 2026 07:20:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jp+hqQqMNpfps3DxX8HzIVZ5L4ni0RL7VXbNl/0NSJ8=; b=T+KK612LWjZUANeB VkFdsMWkr9eyhS/Q15o16qwql0zjmx3zVqavLU23rgjw75IUZUoeAw5IHkblRKn+ 7YzUSSJgv8+lF+kOZ2W6XWW5bum1I9EQ+RpOKDfct9vO11Ph6msTMLpc/ic9AYgw 9O8Aw8paGd/LlJnIuE4ETOoGVuwYXXhZ+vb77bRI3rZ8QAVyFbCKjs8vRFOOVwqN jYcwONoZ8zLm1TjLaKsiTZz3e2FqBM4bH5hcaHomWo0mCaNv/8Iyq9WKBXXmSWeT sCT2wFUOep/7F5Lk8R53LQ532oQlxD+K1hDs2Mlg9Gl+3TG7dDe49k7ZK1lSrFtj 9mSIhA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gbqhwd69b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 31 Aug 2026 07:20:23 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-903694fd3bfso3542156d6.1 for ; Mon, 31 Aug 2026 00:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788160822; x=1788765622; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jp+hqQqMNpfps3DxX8HzIVZ5L4ni0RL7VXbNl/0NSJ8=; b=jymEqclrWrHINIwCV5kzlvm3gfWuXLWoEeYoFnAjcc6RPhZvFIJ7YRoksvhI2fIv6J qehjHlcfUwAiJOnHcS3uCKx83OoO7iAHjgeT2N1exz9/TyGCRxhFL5oNxNbCzMu0nbpD 16mbi5Cpkd4PcBOJrrxxKhDRuR3NApZ+xovuhKMoaAT+dE6VYb/7801XGNdust5vtX61 xp1XZZSdWHQouajF53npkdDNWPU+6qBugdal1w1w+KF45pGfc1qcjkaPJ2LFHxxer1zY gj5cudsYUVX0/BW4BaCY5CjURXeLcjNFEWMZj7Cq9avyMbanijnARU6I6OJBLB3l4KX5 ttOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788160822; x=1788765622; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jp+hqQqMNpfps3DxX8HzIVZ5L4ni0RL7VXbNl/0NSJ8=; b=TN8CQgURBQC6t67/qYLrxTDT2fUsxczqx2y3skoOfqIYeopOR9i9mtwDWHX6bzMG7A nIU/x/1w45XoHf1RScB271B+6VQ0VvlOl/6fF38DS+RsQ8ybcazh0R0F/0g+4J/vEoG5 BXa7vuRwHlRUgnKI/cXn4TMLM4kIw33CnrB72lRjNuVDqcWp6cBOtYspiCskuZa87IWM 8XRXwXU0Yx5bblWfJ91WzBAK+/mjsW6NPKPPPmM/ecslZ4ZDS9coeNUAmZfhZqfYo0CL 7x+sUBbNpxRkSNTDmKXOvlecGeEmxPk8gwgqSwiLZ+72Jl1Y+0QXW9aoiXhMJtPmncaX ibHw== X-Forwarded-Encrypted: i=1; AHgh+RpoLr6foStLodNYDAgyKn91nIF8bYFvgtpmcyX3iOSygW/mEd6EUwXgno5J4J3PiGGXyqQ=@lists.linux.dev X-Gm-Message-State: AFuF++m4QGLSzFRBwudZFZ3xthIWv5bBYFcy07GRTJMD/o8m2swWSH5B lyr1MrJfQUp83LSEOOhYh9xar8S+TJpnGwVWzXSWvlDTpGU5lvXeAlS+VLHq3xrZGaqlO6LsRqZ +8bYTBRrQ+Kj76Wc6cx7ObSEWqZEiT05voejxC+xQnpDb48EoX/qRXHw= X-Gm-Gg: AR+sD11va2YCqiiPZM1wb9RHQ+Adi2ucs7jvbLMWLxw2QWa0p/HVTKLSGdeiqRXefZx EXtFysqoDwBaXLGFmvhTab2Gs0ho0iJjKi3NAL1lGVutwO64qpfnKcI2eABCMXjKnLdnOWH4cNB 3Fd5kROxqWh/eyHSNMjtTxJKjcwKGlEi/Xh+uZEtqy00yw5tZNhHOEmHV3xYMxuVd36gZfGtLNB +0RS3bl5fe6yzFYtn7VK3Gln+Aos8n/pxGl+mI2n47gFA28vMg7qg1Q61VMCWmKKu1X2CFc3AiB 6rj/Mywb+dvbw/6b3LwrEHqX8SnapH3V9J1OeRI5+O2Ss0smZE/0KwgpSf310XKcfMSmSF5aX9q xL0CbJU7/2I31Kq9gnQLj4A== X-Received: by 2002:a05:620a:1b9a:b0:92b:7420:bd58 with SMTP id af79cd13be357-939285432f8mr771690085a.0.1788160822425; Mon, 31 Aug 2026 00:20:22 -0700 (PDT) X-Received: by 2002:a05:620a:1b9a:b0:92b:7420:bd58 with SMTP id af79cd13be357-939285432f8mr771687685a.0.1788160821970; Mon, 31 Aug 2026 00:20:21 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c255f1b2049sm405315466b.36.2026.08.31.00.20.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2026 00:20:21 -0700 (PDT) Message-ID: <655e39a2-88d7-4522-a27d-767dc9578aa2@oss.qualcomm.com> Date: Mon, 31 Aug 2026 09:20:17 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] i2c: qcom-geni: release DMA channels on probe error To: Shengzhuo Wei , Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Wolfram Sang , Ludovic Desroches , Oleksij Rempel , Pengutronix Kernel Team , Frank Li , Sascha Hauer , Fabio Estevam , Yao Yuan , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Vinod Koul , Praveen Talari Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org References: <20260827-i2c-dma-channel-leak-v1-0-271d4adc03a0@cherr.cc> <20260827-i2c-dma-channel-leak-v1-3-271d4adc03a0@cherr.cc> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260827-i2c-dma-channel-leak-v1-3-271d4adc03a0@cherr.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 4mSVujf-II3Y2ftfqjqVA8OVZms6IOJl X-Proofpoint-ORIG-GUID: 4mSVujf-II3Y2ftfqjqVA8OVZms6IOJl X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDA2MSBTYWx0ZWRfX4mv6uuaujaya cRFGaPGg9m8oem8FTRg2C/kj7nvFeJ6fWbQ++eQX4+CIfWINvmGN8RST+FFiYda8PWO/57gpo/7 SKoXptBGo0oifgMc6HAXUB/tR+u4bXU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDA2MSBTYWx0ZWRfX68F5z3ybGG4l oErI+cZboslDZSJno5UfHwypefQtWdK8RcXWHhsxjPyW+aowvH0cdY8WgG4iS+yW7DY4BS+bZTM 1r/wh7cZKcNDCz4NXdDmn530y5kucuyj0uzRzoOTmY/56xXjqq8YHhtoLpbo76VgaTrDFuuhCBK am03+IXM8K+etgS8AvWggpudV4yZvEcCx+daPUfNOCz4trwq9LV3890Osc+fNX0I8NJ1KQC1dxN 5P/4Zg6i00x74uMDLC8VYCUv1T5VYM19fzD29HfS1PPMih4Vn4y1rhenvgSREvJt9qrpItJlIH2 TqD4vTs3wuqirGV7nWzQ7IqX2wE6s+QRkHnypXS3W+CiLYv61NZVnJ+n6WDBXYTJhDgSdb+vm8v wa5FqS6ThKfzWhXvnlqR4XIpzd04/A8xapLv2disurXvGH2NTTYYmlKpFZI3+D0whmraGBTy28T gV3lbd1AYri/5tCAf6g== X-Authority-Analysis: v=2.4 cv=YKKvDxGx c=1 sm=1 tr=0 ts=6a952b37 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=FqpsaMCCsM1CaQCKzz8A:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_02,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310061 On 8/27/26 5:43 PM, Shengzhuo Wei wrote: > geni_i2c_init() grabs exclusive GPI tx/rx DMA channels when the serial > engine runs in GPI mode. If i2c_add_adapter() subsequently fails, probe > returns without releasing the channels, because the remove callback is > not invoked after a failed probe. > > The adapter-registration failure path used to release the channels via > its err_dma label; that release was dropped when the probe tail was > restructured into geni_i2c_init(). > > Release the channels on the adapter-registration failure path, mirroring > geni_i2c_remove(). > > Fixes: d8d3bb127ad1 ("i2c: qcom-geni: Isolate serial engine setup") > Cc: stable@vger.kernel.org > Signed-off-by: Shengzhuo Wei > Assisted-by: GLM:5.3 > --- Reviewed-by: Konrad Dybcio Konrad