From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013056.outbound.protection.outlook.com [52.101.83.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCE7FEACD for ; Wed, 3 Dec 2025 18:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.56 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764785358; cv=fail; b=UvJSda68S2alWPi1WwTCi4zSUzfdQQD7qRtCiqGTaGA5JsdBQY6KR8gLsieMdl9kp75ym7iI7tz9m8pxxmRvb6YEeCdU4zxR8iY8B9HPWw6+9TdBcLMVQTvh8llxDD0CbqtLcFUzwCPF7bIaVJHXeHiPqXpXsiOwyBQTWPzVHq8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764785358; c=relaxed/simple; bh=gkRN21w9eyvoN0Yx/+CAtBNarHq5+2teU+f1L0soBr0=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=Rl52cO9Jn7B0YjNtM8PYh+g8afju26Qhuy5jyQJX4qzHVWXZ470P0sZxQPjTsO1maYuLBpkroRIL78+KTlBG1P4mmXex6P8KxWXqMA6Jha/1PwbrVkgNVRksx9AOH38ZWJQdyVJt3EAB3mhlWfqqDIyETr+PrcnPr+df6dIAKgc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=iTk7m7cx; arc=fail smtp.client-ip=52.101.83.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="iTk7m7cx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eGlHL4Vee6Rj1ZXwh8+xlwfGD4aRIjedQ9Vs4JC+4Wm2p+hCJclAiBtQ3gxQJPg0KtgWOXUhFXgnApcCe0ppEhw5eSU6Ng6KbXKowvvnLdDKXYvwOWVsAFocWHZ56xn9aYHmkA3PagVKqCc8pXAbGsQ/1CaJD7f6QEywGUqBdA0YwDduHOhm3GUJuYvKQVi2/SzBICcfIxD1SPyv6KxX6wqHkTS/aMYJxCZSSaNgzJGCYeU24J1MVbr6GMCXRFnJxCU1dDrIOEHLNlbLDPQfie8BCNsqi7aYYYZs/WXiLql+lUDpS3NytXqMKhRdRtSOiOx2tCOoAMZdZpIMhbNevA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzdCsiNW4aVMY6eON+onneoXp7RRIg0O+7/nJCpsEhw=; b=T4l+IlrUNT7N/wYvOWCbngQ29PwGfN+oKQNZ0UIJzGrkJc6Gk8DdhB+i2TTvgSCaUsstTu2/QxeAfyvXo7/5GAjI2Zycv2lf7KNaZS5zWOeqrsTGy+WV/msaGStgjPIxhHz/s4zDYzQrUw/V6USD836ui7vmkTFfh6fxYclrqi4hddr8lF0vMBjG7AM1W5ZRkpowjCFOyO63JvTijjQEz68DwxMLQa2wwHEn5NoWw5tshCzfMIrJBT9x5/M9MGmxUsows43QxjIM/NHVXY5XmJgAN4hFjtilXecb2pWOMd8to1q/wxOllmWVNTEmVAzPD9bb+JQ4DFQ7kxTc9qfc7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzdCsiNW4aVMY6eON+onneoXp7RRIg0O+7/nJCpsEhw=; b=iTk7m7cxL36Vc6DG3ep2hXfZmf2ECmfJelhrcJkSUvXWczPFt35yLgzMFmdVDaBABVppVMPlNZcM5qsElrOGDH4lkSpIQicXPDkwK9Bn1Hi6OkSdYjNJ9yWylWnMIAzRfM3RjOo+xtSQ5uJzsqfQbf8T1jt918GgWLQm7KhUDYGluJdj9nAKxy52Fjrzn11hqOPcGnHQTzOYKYPD0Ifbi4uzuXa09IZKpEs0MuDd5EB4oqh7eCu6dYfqA7xXBIIeJDWtsfbIutqPVQOqXOkNB4ufXYjjMMy53q4dczcNk6R7xcwqASnGVZlS6E6jRhnb5uZhji/LtYnv9qWdQH7p5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8907.eurprd04.prod.outlook.com (2603:10a6:20b:40a::22) by DU4PR04MB10600.eurprd04.prod.outlook.com (2603:10a6:10:588::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Wed, 3 Dec 2025 18:09:12 +0000 Received: from AM9PR04MB8907.eurprd04.prod.outlook.com ([fe80::a361:2618:7785:3bc9]) by AM9PR04MB8907.eurprd04.prod.outlook.com ([fe80::a361:2618:7785:3bc9%4]) with mapi id 15.20.9388.003; Wed, 3 Dec 2025 18:09:12 +0000 Message-ID: <6a6e90fb-c8be-49ad-83b4-4b602489a616@nxp.com> Date: Wed, 3 Dec 2025 20:09:10 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] remoteproc: imx_dsp_rproc: Wait for suspend ACK only if WAIT_FW_READY is set To: Bjorn Andersson , "Iuliana Prodan (OSS)" Cc: Mathieu Poirier , Shawn Guo , Sascha Hauer , "S.J. Wang" , Fabio Estevam , Daniel Baluta , imx@lists.linux.dev, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team References: <20251125124903.962295-1-iuliana.prodan@oss.nxp.com> <20251125124903.962295-2-iuliana.prodan@oss.nxp.com> Content-Language: en-US From: Iuliana Prodan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS4P250CA0029.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5e3::19) To AM9PR04MB8907.eurprd04.prod.outlook.com (2603:10a6:20b:40a::22) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8907:EE_|DU4PR04MB10600:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d3537f1-17a6-421b-a93c-08de32970f91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K1dpdzRudk1GRjhuN3FSQTYyUUxjSHc5emJuZ2p2UUdQUE5oWTkwZTg4ZVA1?= =?utf-8?B?UlRUbncvdWxXUldnSm1HOUNWRGtTWCtBL2RzQ0psSkxVY3ZZWFUwdkJpTU5B?= =?utf-8?B?alNXaDNBNWhJUTllajZBRk5GLzFjcE45NVJRamEzbEFoQUtXSkVqWFdyVThL?= =?utf-8?B?cG9YNUI1YmxDeWUrcEhpQjlPb0N5cHUwbGpHbHd4WGE5SkI5T0UwTWNkYWJD?= =?utf-8?B?OVNMN0dURDlLdWZHeUp6dkRyRTg2bnpQNitTTG41cUhNeUVhTmxEcFcvUG9V?= =?utf-8?B?ZFZqb1lBMkp5N1ZpUGdwLy9DMDE5YUZrdEhTMTRvRXJjZkg2MkNxb1FiS05M?= =?utf-8?B?TFNLMlhBTndCcUZPQTdkclI0T0hBM2dkTmJlT0NJdlRMM1ozd3ZzZDdIQlNC?= =?utf-8?B?T25pajZHTEpDeldVOHBJV2o5YjRiMWx6a0Zzd0FDQ3kxa2oydXZBS1VOV0R2?= =?utf-8?B?NFRPcjFOZGdqbDZCUFh5ZzZOekZ3dHNYZlJoOXdZamo2bE1wUUhmenltL3VR?= =?utf-8?B?czV1c05TRzFoMDk5VUlnM2dxcDVmdUdGelBmTDZRaXkzUkpqemhkYkRpUXFJ?= =?utf-8?B?L0pLMCsyWVJQcU5HcmNwRmpDSzNFQTY3d2hHRXM4Z3VxeTRhMERkazJnWlZQ?= =?utf-8?B?K2tZT3J4bWdCN09DSy9SMEkrZEVGN2Q4bllYb2VZelpNa0Z6YWUrS2NnanQ0?= =?utf-8?B?ZkJ6L1RYMnM0eWZWMDYzdXpsWWU5WWdqNnFMSVY2SURSeFVHSUprQkxLV1d0?= =?utf-8?B?eWxFVFY1MEhleW80cWdwUlVhakljS3IyeUs2QUFvM1RFNFVvV09udVlkY2F2?= =?utf-8?B?SnRPdFg1RkFmZjBCaThDbWh0cktzWiszRjdURUpVaUNuL3RpNnVKV3NjMi9X?= =?utf-8?B?OWUvMWY1TlV4SkRpWGlRcWpWaEViS3VHWlY5MjQyK2ZRRlY5VkFqYjdZbkNa?= =?utf-8?B?QTg1ZC94aDhBR3lVNVJmZE94UDFZcHpGa0xuWHZZWVpWTUtKMmk4WTVDdUNI?= =?utf-8?B?RVUyWXZsOG1ZUUZVWm5xRDdnL1RNS2U0aUF6aC9xaGQyeFdoaXo1M25YdFhL?= =?utf-8?B?M2ZjVVJPRVNmUW1HNXMzQnM0d3N1REFTRmtyckZFK3o1QWxwZXE4QVNtM0lr?= =?utf-8?B?em5Wc2xyQnhoU09jVTVUU0F6eGVqQXdFT0FzOVY0SUgvaTlqVng1elpUU0da?= =?utf-8?B?MGlFd1dPNGhnNHJyVFVZTzhqOW5pVTRmWWFLUW9CcW9XTFEyRDkxUjNEdURP?= =?utf-8?B?YmhuRFN2YXN6WC83aGluOGt4eXdVM3djZmIzUVcwNm5CaE9zRHJRcFBXcXRx?= =?utf-8?B?Z1NWUWo5U2h1NkduZU45WUVBSkpyaFEyN2JmdmhONCtVMzJ1RFB0QUpqT0Zk?= =?utf-8?B?YURGb2ZVWEltYjVRanpsR3FBQ1I5dFhucFdvR201QjlTRGNtYkpYSVptb1pU?= =?utf-8?B?MlNhOStIcG5TdUlTR1k3VDJxazM0aWNrYWh0eUpFSzRnbkFDVWpsKzZpTmcy?= =?utf-8?B?NHpiK0tmVUFSSU9ORStqTWFMR29uUHZwWGdnZ1dQalNIekRoN045Skt1Vk00?= =?utf-8?B?UmdIbUE0bmIwT2FiUHROMlBFb2RWZ2M5VU1JakhNZzE4Qm1ZVGxyb3h1Nko2?= =?utf-8?B?WHB2dTNENGtrWFVvYnRtMzA3ZGk3S3Rmb1pndTM4ZXZ4YTNuMlp3UWE2VG5k?= =?utf-8?B?U1QrZHNxUnV5WHJIOUc2MmpWdjVUTGMrcVZUblNtb3Q2Z1MwVFNES0Z4NDB4?= =?utf-8?B?MjkvTGJqVldZb2tXTEwyMnJYOVVoMElEclREWCtHYXZNcS8zb1ZzcWZCQmJ0?= =?utf-8?B?UGtQTlpKUjI0UGhjR211SWNzRkU0eFdtZVVlMnhFb1NsbG41cURhVHFBbzBv?= =?utf-8?B?dVNmdGRZc211NkcxMGlleU5OYkl5UktZQ1ExcVpjYjJwQm5DN05tS0xOdHlq?= =?utf-8?Q?QClcxKM8+xInwIlf+GK+zhG0Ea4xSvjs?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8907.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wjl6QlIxc0w4T0RsbGlQYkdCTXdQS3lmZGtjWUp2S01tNmJQRFp1N3Uxejd0?= =?utf-8?B?cjZCR0tzMGdMMWVHSWFiVWZJSHgxd09aYUJpU3NidnRzSm5XRnppVmJNNEdI?= =?utf-8?B?WXNUUjcvbG13YkdUSU91SjVxaDNnMmVpclVlUnNvWE90djlUTkxMcEpGdE9u?= =?utf-8?B?MXgvcnlsV3hEM1phY25EZ3IrMytvclJhNC83dnF6NUVSc2hzY1lLeW92M2wx?= =?utf-8?B?VUJYNitZa0FJdXdQU3M3aEh6YnF5SFRaZG9SaEd2TS9zR3doZUVXOE5yRXRC?= =?utf-8?B?RFk2ZUdVdzg3V3ZTbTdkYWxYaTVyb2FtRXZSSUxINGFuTnVUd0pqdGcyMlN5?= =?utf-8?B?djBFNmZlTDdmWmhnWFhUbFNVY0NsNEk2UW1ZUS9lVkpCWEJHZ3M3ekZScVBD?= =?utf-8?B?TGxPdUhycU8zb0kvQi9YeFBQNFpaOHMwZTMrWHFvTGtVQjhJMFgxSXM3WnVm?= =?utf-8?B?Z1I5bWgzS0JoMEQ3RmxGSUJXc204aloxUzFnYUdHaE0yS1NENnVsQ25QS3g4?= =?utf-8?B?aEJXZENxcGIxNW1scUZvOXl6SmRzYTRwZkl1cm5aUVU3a3o1QnFUNkVaUjNX?= =?utf-8?B?QVdFd2tWblRncnNwQUQrNktkNWUrVFRPY2lvVSs2NllUdEU1a2pZRmxRZC9z?= =?utf-8?B?S0FRSWpkU0JTdXRjRUZybnQ4cWtyY3JZbjU5ZDRoaHhVWVN3VUlvRnQzcXZ0?= =?utf-8?B?VEtEUXFoM2lPaittZEJ1VUhBMmdYdFhQTkdOU2xOTUo4UDQ0WGEwUHFGLzVF?= =?utf-8?B?WDQzQi9hdlRKTzR4c1BndVduRGZZNVQ5MGxlNWNRRk9aVHRnendkME1LOGcr?= =?utf-8?B?Y0JLQjVHK0llM3N0VENvdzZ2ajIzd3UyOUFGako2am5GTXBVNmIrYUtoK3BJ?= =?utf-8?B?SmlqMEw2cFViZUE4TldoRjBoZTUyZEtaa2dwZzBTREpHbWdnVXZ0ZEpPb3Nr?= =?utf-8?B?VmtuaW5zQnhoRnYwZDkwQVZ5TERvZWU4bkZpYUtDaGUyanhDL2VPRUpuQjhm?= =?utf-8?B?Q0V3ZW9NemJYRVYxRlJGcHdIbTg4VG1LOFV1NjNpSTBpaVB1dVQ2b05MK20y?= =?utf-8?B?c0hoNUFJd1loMHJPbnoySWhvVFgwTWt4TnY1SHlOeFl2UWVBT0xQZzJiRVlo?= =?utf-8?B?eHV5MnFpeEg0dm41QUV3VzlXVlFVOUh3NzZpbzR4Q3M1b2ZhVGhiSTJ5MEcv?= =?utf-8?B?UXNMWnUyTUFYbVFyQ09YclN0YTRlTHJWZXhFbGd5U3JiaUVROFJKRlVCZExo?= =?utf-8?B?S1dZMnZUMzBOWTVMVGt4ZnFEL0pNT1VmQ3N0VlBiQy9aNzFRZFdoVDNHRnZL?= =?utf-8?B?V0x1SWcrd2NSOGFKV0tXQVJ4aUpBU3NQU1AwSjdxb1QzVk5qMzU2UzdGV0dZ?= =?utf-8?B?RWt2ZjIzOWNURldDNWZ1T1Z5L20yMmdTL1NsRFovZ0lnSE8vUlpjN0pLY1Iv?= =?utf-8?B?TnExRlRmOGxKeWtMS2NxMWQxbFJjR2VUT2oxazVvTXdrMk9yTkZFdFFxQTMw?= =?utf-8?B?WTNQc01obFZsWVFJRm9NR2JGaHFmUGNWZlg5RnpBNWFVYThYUHNNSCtiSTIz?= =?utf-8?B?dW1RZWdOTXNSK1c2M0I0OWpNcHJmREFwMWJxVGxRQjM2WE9NMzdZSWxDdU03?= =?utf-8?B?Y09Cd0hmSyt4Q2lobjcxRnBRV2tNbXQ0WlNCbkdUSjJiM2Z2M2pqV3dzZGxM?= =?utf-8?B?dmZPTzRjTnVlYlhnUFJEMHYrN0VEZzBJZ3NIckdVL2w2Z1hoSDFIR3hqc3M4?= =?utf-8?B?Ym9UWlF5Ky9iWTcrK29EM0dON2d2c01PTGp3MVRsTTRYWkdLeFF2cUl5bDBv?= =?utf-8?B?SnRjaVlzMUx5WjU4V0lsNG1qT1hDSlFxQnJEN3hOMWlONU93R1JhVitTMmZX?= =?utf-8?B?aXlQazBBVjNoYUU5TXFUeisyYVZFMHB6K3FNckxEOXlRbzMvc1EyTjBYd3NK?= =?utf-8?B?MU42bzlId0c5Q1NjTkkvbUhCdXNZQXArQ1VObUJXcEs3M2IrMVg4d1dqcnN2?= =?utf-8?B?dkgxd2VTc2FvM2RmdTdYR2FoTlVxOFFlUUwxUDJlN3U3dUhnakdidFc5RnNL?= =?utf-8?B?cVNCNDRlU2J1Rk9WaTNndWh3d0JnTi95QWkwSlF4YS95cFhuWXRiRkptQ1p6?= =?utf-8?B?T2pialRiMUVOd2RtUXpCR05XZ1FSQnQ2OXIwZDNESUZHU3FGQnZSOHA5cEdM?= =?utf-8?B?VGc9PQ==?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d3537f1-17a6-421b-a93c-08de32970f91 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8907.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2025 18:09:12.2135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4POQzuywZJnOIB4F3Bh2iF73mL5DRHFimg7GrinNxdw/Z1RsLkNExq04NQliTHo+zJtrXv1ACLscrMgS52XWFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10600 On 11/26/2025 10:21 PM, Bjorn Andersson wrote: > On Tue, Nov 25, 2025 at 02:49:03PM +0200, Iuliana Prodan (OSS) wrote: >> From: Iuliana Prodan >> >> The DSP suspend path currently waits unconditionally >> for a suspend ack from the firmware. >> This breaks firmwares that do not implement the >> mailbox-based READY handshake, as the DSP never >> responds and system suspend fails with -EBUSY. >> > > But if the firmware doesn't implement "mailbox-based READY handshake", > do you still want to send the RP_MBOX_SUSPEND_SYSTEM message? > If FEATURE_DONT_WAIT_FW_READY is set, it means the remote does not send any feedback to the host and does not handle specific messages. In this case, it’s better not to send the message at all. BTW, to avoid confusion with FW_READY macros, I’ll add a new patch to rename these macros to FW_CONFIRMATION, since they are used both for boot confirmation and other firmware acknowledgments. > If so, can you clarify here in the commit message that the firmware > expects the mailbox-based message, and only the "handshake" part should > be omitted. > > If that part isn't implemented either, then I think you should fix the > code to not poke the mailbox in the first place. > Yes, will fix in v2. > > Also, wrap your commit message at 75 characters, please. > >> The driver already uses the WAIT_FW_READY flag to >> indicate that the firmware supports the READY >> handshake at boot. Apply the same logic during >> suspend: only wait for the suspend ack when the >> firmware is expected to support it. >> >> Signed-off-by: Iuliana Prodan >> --- >> drivers/remoteproc/imx_dsp_rproc.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c >> index fc0470aa72c1..e25dbe32ef79 100644 >> --- a/drivers/remoteproc/imx_dsp_rproc.c >> +++ b/drivers/remoteproc/imx_dsp_rproc.c >> @@ -1327,10 +1327,11 @@ static int imx_dsp_suspend(struct device *dev) >> } >> >> /* >> - * DSP need to save the context at suspend. >> - * Here waiting the response for DSP, then power can be disabled. >> + * The DSP must save its context during suspend. > > Please double check that this comment reflect above conclusion. > This is valid for some firmware, like Xtensa Audio Firmware (XAF), where we use both firmware-ready replay and the messages are handled on the remote side, where the DSP context is saved. > Regards, > Bjorn > >> + * Wait for a response from the DSP if required before disabling power. >> */ >> - if (!wait_for_completion_timeout(&priv->pm_comp, msecs_to_jiffies(100))) >> + if (priv->flags & WAIT_FW_READY && >> + !wait_for_completion_timeout(&priv->pm_comp, msecs_to_jiffies(100))) >> return -EBUSY; >> >> out: >> -- >> 2.34.1 >>