[PATCH v3 1/1] dt-bindings: memory-controllers: fsl,ifc: add compatible string fsl,ifc-nand

[PATCH v3 1/1] dt-bindings: memory-controllers: fsl,ifc: add compatible string fsl,ifc-nand

[Frank Li]

ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc
and compatible string "fsl,ifc-nand" when ifc connect to nand flash.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
	failed to match any schema with compatible: ['fsl,ifc-nand']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- add partition child node for nand
- Only partition property is used at ppc
Change from v1 to v2
- add address-cells and size-cells
---
 .../memory-controllers/fsl/fsl,ifc.yaml       | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
index d1c3421bee107..5a11224da8914 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
@@ -58,6 +58,32 @@ properties:
       access window as configured.
 
 patternProperties:
+  "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
+    type: object
+    properties:
+      compatible:
+        const: fsl,ifc-nand
+
+      reg:
+        maxItems: 1
+
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 1
+
+    patternProperties:
+      "^partition@[0-9a-f]+":
+        $ref: /schemas/mtd/partitions/partition.yaml#
+        deprecated: true
+
+    required:
+      - compatible
+      - reg
+
+    additionalProperties: false
+
   "^.*@[a-f0-9]+(,[a-f0-9]+)+$":
     type: object
     description: |
-- 
2.34.1

Re: [PATCH v3 1/1] dt-bindings: memory-controllers: fsl,ifc: add compatible string fsl,ifc-nand

[Krzysztof Kozlowski]

On Fri, Aug 30, 2024 at 03:11:43PM -0400, Frank Li wrote:
> ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc
> and compatible string "fsl,ifc-nand" when ifc connect to nand flash.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
> 	failed to match any schema with compatible: ['fsl,ifc-nand']
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v2 to v3
> - add partition child node for nand
> - Only partition property is used at ppc
> Change from v1 to v2
> - add address-cells and size-cells
> ---
>  .../memory-controllers/fsl/fsl,ifc.yaml       | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> index d1c3421bee107..5a11224da8914 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> @@ -58,6 +58,32 @@ properties:
>        access window as configured.
>  
>  patternProperties:
> +  "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
> +    type: object
> +    properties:
> +      compatible:
> +        const: fsl,ifc-nand
> +
> +      reg:
> +        maxItems: 1
> +
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 1
> +
> +    patternProperties:
> +      "^partition@[0-9a-f]+":
> +        $ref: /schemas/mtd/partitions/partition.yaml#
> +        deprecated: true
> +
> +    required:
> +      - compatible
> +      - reg
> +
> +    additionalProperties: false
> +
>    "^.*@[a-f0-9]+(,[a-f0-9]+)+$":

This pattern is for NAND already. I don't understand why you are
duplicating it. If this part does not work, fix it.

Best regards,
Krzysztof

Re: [PATCH v3 1/1] dt-bindings: memory-controllers: fsl,ifc: add compatible string fsl,ifc-nand

[Frank Li]

On Mon, Sep 02, 2024 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
> On Fri, Aug 30, 2024 at 03:11:43PM -0400, Frank Li wrote:
> > ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc
> > and compatible string "fsl,ifc-nand" when ifc connect to nand flash.
> >
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
> > 	failed to match any schema with compatible: ['fsl,ifc-nand']
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Change from v2 to v3
> > - add partition child node for nand
> > - Only partition property is used at ppc
> > Change from v1 to v2
> > - add address-cells and size-cells
> > ---
> >  .../memory-controllers/fsl/fsl,ifc.yaml       | 26 +++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> > index d1c3421bee107..5a11224da8914 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> > @@ -58,6 +58,32 @@ properties:
> >        access window as configured.
> >
> >  patternProperties:
> > +  "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
> > +    type: object
> > +    properties:
> > +      compatible:
> > +        const: fsl,ifc-nand
> > +
> > +      reg:
> > +        maxItems: 1
> > +
> > +      "#address-cells":
> > +        const: 1
> > +
> > +      "#size-cells":
> > +        const: 1
> > +
> > +    patternProperties:
> > +      "^partition@[0-9a-f]+":
> > +        $ref: /schemas/mtd/partitions/partition.yaml#
> > +        deprecated: true
> > +
> > +    required:
> > +      - compatible
> > +      - reg
> > +
> > +    additionalProperties: false
> > +
> >    "^.*@[a-f0-9]+(,[a-f0-9]+)+$":
>
> This pattern is for NAND already. I don't understand why you are
> duplicating it. If this part does not work, fix it.

It is old binding. It did not require compatible string. It should split
into nand\flash\fpga ...

The difference part require difference compatible string. NAND is only
1st step to improve it.

Frank

>
> Best regards,
> Krzysztof
>

Re: [PATCH v3 1/1] dt-bindings: memory-controllers: fsl,ifc: add compatible string fsl,ifc-nand

[Krzysztof Kozlowski]

On 02/09/2024 19:57, Frank Li wrote:
> On Mon, Sep 02, 2024 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
>> On Fri, Aug 30, 2024 at 03:11:43PM -0400, Frank Li wrote:
>>> ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc
>>> and compatible string "fsl,ifc-nand" when ifc connect to nand flash.
>>>
>>> Fix below warning:
>>> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
>>> 	failed to match any schema with compatible: ['fsl,ifc-nand']
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>> Change from v2 to v3
>>> - add partition child node for nand
>>> - Only partition property is used at ppc
>>> Change from v1 to v2
>>> - add address-cells and size-cells
>>> ---
>>>  .../memory-controllers/fsl/fsl,ifc.yaml       | 26 +++++++++++++++++++
>>>  1 file changed, 26 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
>>> index d1c3421bee107..5a11224da8914 100644
>>> --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
>>> @@ -58,6 +58,32 @@ properties:
>>>        access window as configured.
>>>
>>>  patternProperties:
>>> +  "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
>>> +    type: object
>>> +    properties:
>>> +      compatible:
>>> +        const: fsl,ifc-nand
>>> +
>>> +      reg:
>>> +        maxItems: 1
>>> +
>>> +      "#address-cells":
>>> +        const: 1
>>> +
>>> +      "#size-cells":
>>> +        const: 1
>>> +
>>> +    patternProperties:
>>> +      "^partition@[0-9a-f]+":
>>> +        $ref: /schemas/mtd/partitions/partition.yaml#
>>> +        deprecated: true
>>> +
>>> +    required:
>>> +      - compatible
>>> +      - reg
>>> +
>>> +    additionalProperties: false
>>> +
>>>    "^.*@[a-f0-9]+(,[a-f0-9]+)+$":
>>
>> This pattern is for NAND already. I don't understand why you are
>> duplicating it. If this part does not work, fix it.
> 
> It is old binding. It did not require compatible string. It should split
> into nand\flash\fpga ...
> 
> The difference part require difference compatible string. NAND is only
> 1st step to improve it.

I understand. I would prefer to make it complete, which you are quite
close to it. Just change the remaining pattern for example:

(flash|fpga)......:
  type: object
  oneOf:
    - $ref: /schemas/board/fsl,fpga-qixis.yaml#
    - $ref: /schemas/mtd/mtd-physmap.yaml#
  unevaluatedProperties: false

or something similar.


Best regards,
Krzysztof