Re: [PATCH 2/2] media: uvcvideo: add URB_USBMON_NEED_SYNC urb flag

[Hans de Goede <hansg@kernel.org>]

Hi,

On 14-Jun-25 15:24, Xu Yang wrote:
> Since commit "20e1dbf2bbe2 media: uvcvideo: Use dma_alloc_noncontiguous
> API", the driver is allocating non-coherent buffer for urb. This will
> add URB_USBMON_NEED_SYNC flag to inform usb monitor needs do dma sync
> when record data.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans


> ---
>  drivers/media/usb/uvc/uvc_video.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index e3567aeb0007..446b3f16545d 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1946,7 +1946,8 @@ static int uvc_init_video_isoc(struct uvc_streaming *stream,
>  		urb->context = uvc_urb;
>  		urb->pipe = usb_rcvisocpipe(stream->dev->udev,
>  				ep->desc.bEndpointAddress);
> -		urb->transfer_flags = URB_ISO_ASAP | URB_NO_TRANSFER_DMA_MAP;
> +		urb->transfer_flags = URB_ISO_ASAP | URB_NO_TRANSFER_DMA_MAP |
> +				      URB_USBMON_NEED_SYNC;
>  		urb->transfer_dma = uvc_urb->dma;
>  		urb->interval = ep->desc.bInterval;
>  		urb->transfer_buffer = uvc_urb->buffer;