From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: Clark Wang <xiaoning.wang@nxp.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi
Date: Mon, 29 Jul 2024 17:10:48 +0200 [thread overview]
Message-ID: <6c6bb89e-a9d8-4d5c-837a-30f3bae56f0f@kernel.org> (raw)
In-Reply-To: <20240729094511.159467-1-alexander.stein@ew.tq-group.com>
On 29/07/2024 11:45, Alexander Stein wrote:
> From: Clark Wang <xiaoning.wang@nxp.com>
>
> Add DMA configurations for LPSPI nodes on i.MX8QX/QM/DXL.
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Using the DMA configuration bits from downstream kernel.
> Tested on TQMa8XxS.
>
> arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> index 1ee9496c988c5..8ae5f065b4180 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -34,6 +34,8 @@ lpspi0: spi@5a000000 {
> assigned-clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>;
> assigned-clock-rates = <60000000>;
> power-domains = <&pd IMX_SC_R_SPI_0>;
> + dma-names = "tx","rx";
Missing spaces. Unexpected order, unless that's the coding style for imx.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 9:45 [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi Alexander Stein
2024-07-29 15:10 ` Krzysztof Kozlowski [this message]
2024-07-30 7:30 ` Alexander Stein
2024-07-30 7:37 ` Krzysztof Kozlowski
2024-07-30 7:51 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6bb89e-a9d8-4d5c-837a-30f3bae56f0f@kernel.org \
--to=krzk@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox