From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59490221DB3 for ; Mon, 24 Nov 2025 10:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763979854; cv=none; b=WskjQTs1PBnQsuToeSbVcEDrze/wm7ZspEKORWYdPHlYpVtzI+bZ0XGS2PmJS5WP9gFvhB6HZ7/emgdMz1SjU+yJj0rQtFChZEjilQHZOItyoYXcB65VO3eBtUMspKt59kbE5kTymd+AtLdxg9ip2jotnRszC1R11HBBUI0aXgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763979854; c=relaxed/simple; bh=MyhVfaLuUMB4FJ2DvvqxwnUvFdn4Yuvt+apgQWbex0s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IwVuyi9Iq3gZS7HN20Kk6v/oaSfKqeRgExcr62pmDCCPUfMrjKxUJ6v3HchBLdmALnmNkV+fcONti2pb3Hn8c9oCXNRVK/yCDaE6Zaxt2oxn7/ck010lFoGfZTHh+TKSnp/C9KJ0esYdnTasBl1TsTp5gb1bBVkttB4C41goqvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IxrsMjLt; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IxrsMjLt" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5957e017378so4253640e87.3 for ; Mon, 24 Nov 2025 02:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763979850; x=1764584650; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UvxeS/74nBAEFSf4nVKv65BSIxiE58qrGcTM82uuMOU=; b=IxrsMjLt8BWVgHWCpvTpLBRIp0N2abt7p0pt6Y46ZELHacD6BUwSdED4r85LqGA2I8 kwb7aH5etVpD63Rqy1gA37LmTKntguG0AnsemLEhJ0XGnaph6D9Lt7WBmBwCdJ2Gi0LC uF86TGrUrIK1GRrEoZR5wUHt2Zi0YLh59c1sgghY0Hc4nB3JzpoZGy8qNW2kIH1nVjys jrmHJ2wC7989z3X78cj7ucR6ZGzaH8Kj7NLAOmS3neirRd2zZMREPgjYNhG7KnHrWDX2 8BlXhBdSZA2lNB9cfxZx/6gWSG5d5wcw/ZTDLaDLwM6Kex87EbzUg+kN1hF2YolJlUIh pRug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763979850; x=1764584650; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UvxeS/74nBAEFSf4nVKv65BSIxiE58qrGcTM82uuMOU=; b=ma5AYfZ13RaOqZRKmPqx09mhc+8+8zQ/2f0vFm/8zBI1beXghZsMYdf+t9QUuRoMJ/ KSInapK6xjM05iF3WqS3chblQ+BPiTjJPrggYhiiUi+s5GM1j8rHh4GtKXHoDKQQrL6P UN9A7hDBrMgBASj8sVqo39VONIAGG1Ms6P4KGZSAh6bG2R8YZykZYgeA/772G6GcT8PC 9oRpbyIVGQJ92jczMNGE6R+yqJt4UPqWGw2kVwRlXvJ7vj5+nguvsenkWRd16fK85QcI dXPjh2L6xk4xzLAF/kXL0vo9MlRc3OjyCnwTxXg15vsVQXx4FRo1Fvh65x63EOzNVaFp +DRg== X-Forwarded-Encrypted: i=1; AJvYcCUFmy56yqj3ocrgW2psOGH0bwtmwRMk+tprsF2Y59gDu6fypXd5pGffgOcPeM3FbEogo+4=@lists.linux.dev X-Gm-Message-State: AOJu0YxvT5QYq6f+EnXGmjZsUKLYGP2vNiCUsJBXw6X5t9WrqYvDtmj8 iB/Bw2/+ICTyz2Xp96l7SY3D6asmDKmNcSrWEPqShNxpwLv1+dVoWIjzkRUdR0My X-Gm-Gg: ASbGncsIJYtBU0OLWywj40o5QwYXDpG7AHdh3tBvcg/K17urpc22gtLlzbwoZRfzq9p e//6zJ8sDeARr7kUorM9t41I8ank66g7Z5+d6Vw9uio4AspA8FxkwhsqHMQMs8QHtpu4kB1/lGs D2yJtMAthtgyPaEq+Ucd6V6lrKDpciD8Sik0tnqtGg6+KdimpHAs/Dz10joGKvHttTRYZSZMeL/ rQPU+zPHWF0UAXjfijILbD3p3Kb1H8pB7iSFpXhh4h+VLDMS2DaJcHGgnEWSc9GtHm+LrjLPWpP tdqbSGIZYyAx4kanWc+8BTPfed5OhiqIwaWqLXG/oUOCvzV+EOsHfLlxYGgkVNqYdwEqbXy4hp0 cB4HFXf2gl1wKJzc5gz7ivPe3BZ2HG4IofAVQ8gF6PzIkkKQyWrbcpwzfq1rrtv21aSLF1vfv8A Qa5fQ19ZA8xkXUXw== X-Google-Smtp-Source: AGHT+IGzb+yApYHtjewkoQzx7FPWIVvgfb9lCElhP6A4EWOQNvayCoMjjLyY5L5QUpilRr8Cj3haxw== X-Received: by 2002:a05:6512:104a:b0:595:90ee:f476 with SMTP id 2adb3069b0e04-596a3edab46mr4292946e87.28.1763974136131; Mon, 24 Nov 2025 00:48:56 -0800 (PST) Received: from [10.38.18.76] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5969dbc5c5dsm4019850e87.79.2025.11.24.00.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 00:48:55 -0800 (PST) Message-ID: <6ee209b3-4d7a-45a8-bd65-6a51730d458d@gmail.com> Date: Mon, 24 Nov 2025 10:48:54 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Revert "treewide: Fix probing of devices in DT overlays" To: Saravana Kannan , Herve Codina , Greg Kroah-Hartman , "Rafael J. Wysocki" , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Wolfram Sang , Rob Herring , Mark Brown , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Geert Uytterhoeven Cc: kernel-team@android.com, Wolfram Sang , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, Matti Vaittinen References: <20240411235623.1260061-1-saravanak@google.com> <20240411235623.1260061-2-saravanak@google.com> Content-Language: en-US From: Kalle Niemi In-Reply-To: <20240411235623.1260061-2-saravanak@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/12/24 02:56, Saravana Kannan wrote: > This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. > > While the commit fixed fw_devlink overlay handling for one case, it > broke it for another case. So revert it and redo the fix in a separate > patch. > > Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT overlays") > Reported-by: Herve Codina > Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ > Closes: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ > Closes: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ > Signed-off-by: Saravana Kannan > --- > drivers/bus/imx-weim.c | 6 ------ > drivers/i2c/i2c-core-of.c | 5 ----- > drivers/of/dynamic.c | 1 - > drivers/of/platform.c | 5 ----- > drivers/spi/spi.c | 5 ----- > 5 files changed, 22 deletions(-) > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index 837bf9d51c6e..caaf887e0ccc 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -331,12 +331,6 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action, > "Failed to setup timing for '%pOF'\n", rd->dn); > > if (!of_node_check_flag(rd->dn, OF_POPULATED)) { > - /* > - * Clear the flag before adding the device so that > - * fw_devlink doesn't skip adding consumers to this > - * device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > if (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) { > dev_err(&pdev->dev, > "Failed to create child device '%pOF'\n", > diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c > index a6c407d36800..a250921bbce0 100644 > --- a/drivers/i2c/i2c-core-of.c > +++ b/drivers/i2c/i2c-core-of.c > @@ -178,11 +178,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, > return NOTIFY_OK; > } > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > client = of_i2c_register_device(adap, rd->dn); > if (IS_ERR(client)) { > dev_err(&adap->dev, "failed to create client for '%pOF'\n", > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index 4d57a4e34105..19a1a38554f2 100644 > --- a/drivers/of/dynamic.c > +++ b/drivers/of/dynamic.c > @@ -224,7 +224,6 @@ static void __of_attach_node(struct device_node *np) > np->sibling = np->parent->child; > np->parent->child = np; > of_node_clear_flag(np, OF_DETACHED); > - np->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; > > raw_spin_unlock_irqrestore(&devtree_lock, flags); > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 389d4ea6bfc1..efd861fa254f 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -743,11 +743,6 @@ static int of_platform_notify(struct notifier_block *nb, > if (of_node_check_flag(rd->dn, OF_POPULATED)) > return NOTIFY_OK; > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > /* pdev_parent may be NULL when no bus platform device */ > pdev_parent = of_find_device_by_node(rd->dn->parent); > pdev = of_platform_device_create(rd->dn, NULL, > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index ff75838c1b5d..17cd417f7681 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -4761,11 +4761,6 @@ static int of_spi_notify(struct notifier_block *nb, unsigned long action, > return NOTIFY_OK; > } > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > spi = of_register_spi_device(ctlr, rd->dn); > put_device(&ctlr->dev); > Hello, Test system testing drivers for ROHM ICs bisected this commit to cause BD71847 drivers probe to not be called. The devicetree blob overlay describing bd71847 enables I2C1 bus on BeagleBone Black aswell. Probe is called when the driver is used with HW connected to I2C2 bus. I2C2 bus is enabled before overlaying devicetree blobs. ---- BD71847 Devicetree overlay source ---- /dts-v1/; /plugin/; /{ /* this is our device tree overlay root node */ compatible = "ti,beaglebone", "ti,beaglebone-black"; part-number = "BBB-I2C1"; version = "00A0"; fragment@0 { target = <&am33xx_pinmux>; // this is a link to an already defined node in the device tree, so that node is overlayed with our modification __overlay__ { i2c1_pins: pinmux_i2c1_pins { pinctrl-single,pins = < 0x158 0x72 /* spi0_d1.i2c1_sda */ 0x15C 0x72 /* spi0_cs0.i2c1_sdl */ >; }; }; }; .... .... fragment@2 { target = <&i2c1>; __overlay__ { pinctrl-0 = <&i2c1_pins>; clock-frequency = <100000>; status = "okay"; pmic: pmic@4b { /* the "test" defined as child of the i2c1 bus */ compatible = "rohm,bd71847"; reg = <0x4b>; .... .... }; /* root node end */ ---- END OF BD71847 Devicetree overlay source ---- Reverting this patch from linux-next from last friday fixes the issue. BR Kalle Niemi