* [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio
@ 2025-07-29 3:13 WangErQian
2025-07-29 7:14 ` Krzysztof Kozlowski
2025-07-29 13:12 ` Rob Herring (Arm)
0 siblings, 2 replies; 4+ messages in thread
From: WangErQian @ 2025-07-29 3:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, imx
Cc: WangErQian, linux-arm-kernel, john
Add bindings for Debix Model A Bluetooth and audio
This patch adds device tree binding documentation for:
- fsl,mxc_bt_rfkill.yaml: Bluetooth RF control node
- fsl,imx-audio-es8316.yaml: Audio codec interface
Signed-off-by: WangErQian <WangErQianY@icloud.com>
---
.../bindings/bluetooth/fsl,mxc_bt_rfkill.yaml | 70 +++++++++++++++
.../bindings/sound/fsl,imx-audio-es8316.yaml | 88 +++++++++++++++++++
2 files changed, 158 insertions(+)
create mode 100644 Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
diff --git a/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml b/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
new file mode 100644
index 000000000000..b173de7a4102
--- /dev/null
+++ b/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+$id: http://devicetree.org/schemas/bluetooth/fsl,mxc_bt_rfkill.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX Bluetooth RFKill Controller
+
+maintainers:
+ - WangErQian <wangerqiany@icloud.com>
+
+description: |
+ Binding for NXP i.MX Bluetooth RFKill controller, managing power and wake signals via GPIOs.
+
+properties:
+ compatible:
+ const: fsl,mxc_bt_rfkill
+
+ pinctrl-names:
+ maxItems: 1
+ items:
+ - const: default
+
+ pinctrl-0:
+ type: phandle
+ description: Phandle to default pin control configuration
+
+ bt-power-gpios:
+ description: GPIO controlling Bluetooth power (active low)
+ maxItems: 1
+
+ wake-bt-gpios:
+ description: GPIO for waking Bluetooth device (active low)
+ maxItems: 1
+
+ wake-host-gpios:
+ description: GPIO for host wake-up signal (active low)
+ maxItems: 1
+
+ status:
+ type: string
+ enum: [ "okay", "disabled" ]
+ default: "okay"
+
+required:
+ - compatible
+ - bt-power-gpios
+ - wake-bt-gpios
+ - wake-host-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ pinctrl_bt_ctrl: bt_ctrl_grp {
+ fsl,pins = <
+ MX6UL_PAD_GPIO1_IO06__GPIO1_IO06 0x13059 /* BT_POWER */
+ MX6UL_PAD_GPIO1_IO07__GPIO1_IO07 0x13059 /* WAKE_BT */
+ MX6UL_PAD_GPIO1_IO08__GPIO1_IO08 0x13059 /* WAKE_HOST */
+ >;
+ };
+
+ bt_rfkill {
+ compatible = "fsl,mxc_bt_rfkill";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_bt_ctrl>;
+ bt-power-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+ wake-bt-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
+ wake-host-gpios = <&gpio1 8 GPIO_ACTIVE_LOW>;
+ status = "okay";
+ };
diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
new file mode 100644
index 000000000000..35f13d656caf
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
@@ -0,0 +1,88 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+$id: http://devicetree.org/schemas/sound/fsl,imx-audio-es8316.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX Audio Interface with ES8316 Codec
+
+maintainers:
+ - WangErQian <wangerqiany@icloud.com>
+
+description: |
+ Binding for NXP i.MX platforms using the Everest ES8316 audio codec.
+ Defines the connections between CPU DAI (SAI), codec, and audio routing.
+
+properties:
+ compatible:
+ const: fsl,imx-audio-es8316
+
+ model:
+ type: string
+ description: Descriptive name of the audio setup (e.g., board-specific)
+ default: "imx-audio-es8316"
+
+ audio-cpu:
+ type: phandle
+ description: Phandle to the CPU audio interface (e.g., SAI node)
+ maxItems: 1
+
+ audio-codec:
+ type: phandle
+ description: Phandle to the audio codec (ES8316 node)
+ maxItems: 1
+
+ format:
+ type: string
+ description: Audio data format (e.g., i2s, left-justified)
+ enum: ["i2s", "right-justified", "left-justified", "dsp-a", "dsp-b"]
+ default: "i2s"
+
+ hp-det-gpio:
+ type: phandle-array
+ description: GPIO for headphone detection (active high)
+ maxItems: 1
+ items:
+ - description: GPIO specifier (controller + pin + flags)
+
+ audio-routing:
+ type: string-array
+ description: Connection mapping between codec pins and audio components
+ items:
+ minItems: 2
+ maxItems: 2
+ items:
+ - description: Source endpoint (e.g., "Mic Jack")
+ - description: Sink endpoint (e.g., "MIC2")
+
+required:
+ - compatible
+ - audio-cpu
+ - audio-codec
+ - audio-routing
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ sai3: sai@40031000 {
+ compatible = "fsl,imx8mp-sai";
+ reg = <0x40031000 0x1000>;
+ };
+
+ codec: es8316@11 {
+ compatible = "everest,es8316";
+ reg = <0x11>;
+ };
+
+ sound {
+ compatible = "fsl,imx-audio-es8316";
+ model = "imx-audio-es8316";
+ audio-cpu = <&sai3>;
+ audio-codec = <&codec>;
+ format = "i2s";
+ hp-det-gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
+ audio-routing =
+ "Mic Jack", "MIC2",
+ "Headphone Jack", "HPOL",
+ "Headphone Jack", "HPOR";
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio
2025-07-29 3:13 [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio WangErQian
@ 2025-07-29 7:14 ` Krzysztof Kozlowski
2025-07-29 7:34 ` Krzysztof Kozlowski
2025-07-29 13:12 ` Rob Herring (Arm)
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-29 7:14 UTC (permalink / raw)
To: WangErQian, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, imx
Cc: linux-arm-kernel, john
On 29/07/2025 05:13, WangErQian wrote:
> Add bindings for Debix Model A Bluetooth and audio
>
> This patch adds device tree binding documentation for:
Read submitting patches. It explains how to write appropriate commit msg
and what should be in the patchset.
> - fsl,mxc_bt_rfkill.yaml: Bluetooth RF control node
> - fsl,imx-audio-es8316.yaml: Audio codec interface
Read submitting patches. There is VERY important paragraph called -
separate your changes.
>
> Signed-off-by: WangErQian <WangErQianY@icloud.com>
No, you need real name.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch -vX` helps here to create proper versioned
patches. Another useful tool is b4. Skipping the PATCH keyword makes
filtering of emails more difficult thus making the review process less
convenient.
There is no patch prefix called "dt-bindings".
> ---
> .../bindings/bluetooth/fsl,mxc_bt_rfkill.yaml | 70 +++++++++++++++
> .../bindings/sound/fsl,imx-audio-es8316.yaml | 88 +++++++++++++++++++
> 2 files changed, 158 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
>
> diff --git a/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml b/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
> new file mode 100644
> index 000000000000..b173de7a4102
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +$id: http://devicetree.org/schemas/bluetooth/fsl,mxc_bt_rfkill.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX Bluetooth RFKill Controller
> +
> +maintainers:
> + - WangErQian <wangerqiany@icloud.com>
> +
> +description: |
> + Binding for NXP i.MX Bluetooth RFKill controller, managing power and wake signals via GPIOs.
No, explain the hardware, not what binding is.
> +
> +properties:
> + compatible:
> + const: fsl,mxc_bt_rfkill
There is no user of this, so why posting this binding?
> +
> + pinctrl-names:
> + maxItems: 1
> + items:
> + - const: default
> +
> + pinctrl-0:
> + type: phandle
> + description: Phandle to default pin control configuration
> +
> + bt-power-gpios:
> + description: GPIO controlling Bluetooth power (active low)
> + maxItems: 1
> +
> + wake-bt-gpios:
> + description: GPIO for waking Bluetooth device (active low)
> + maxItems: 1
> +
> + wake-host-gpios:
> + description: GPIO for host wake-up signal (active low)
> + maxItems: 1
> +
> + status:
> + type: string
> + enum: [ "okay", "disabled" ]
> + default: "okay"
Do you see ANY binding with such syntax? No. There is no and this should
be a hint that you are doing something wrong.
Anyway, entire binding does not describe the hardware, so this cannot be
accepted. Bindings describe real hardware devices, not virtual beings
like some containers for GPIOs.
...
> diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
> new file mode 100644
> index 000000000000..35f13d656caf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +$id: http://devicetree.org/schemas/sound/fsl,imx-audio-es8316.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX Audio Interface with ES8316 Codec
> +
> +maintainers:
> + - WangErQian <wangerqiany@icloud.com>
> +
> +description: |
> + Binding for NXP i.MX platforms using the Everest ES8316 audio codec.
Same comments
> + Defines the connections between CPU DAI (SAI), codec, and audio routing.
> +
> +properties:
> + compatible:
> + const: fsl,imx-audio-es8316
There is no user for it or your commit msg is incomplete.
> +
> + model:
> + type: string
> + description: Descriptive name of the audio setup (e.g., board-specific)
> + default: "imx-audio-es8316"
How other bindings do this?
> +
> + audio-cpu:
> + type: phandle
> + description: Phandle to the CPU audio interface (e.g., SAI node)
> + maxItems: 1
> +
> + audio-codec:
> + type: phandle
> + description: Phandle to the audio codec (ES8316 node)
> + maxItems: 1
> +
> + format:
> + type: string
> + description: Audio data format (e.g., i2s, left-justified)
> + enum: ["i2s", "right-justified", "left-justified", "dsp-a", "dsp-b"]
> + default: "i2s"
How other bindings do this?
> +
> + hp-det-gpio:
> + type: phandle-array
> + description: GPIO for headphone detection (active high)
> + maxItems: 1
> + items:
> + - description: GPIO specifier (controller + pin + flags)
> +
> + audio-routing:
> + type: string-array
> + description: Connection mapping between codec pins and audio components
> + items:
> + minItems: 2
> + maxItems: 2
These are redundant. I don't think this was tested.
> + items:
> + - description: Source endpoint (e.g., "Mic Jack")
> + - description: Sink endpoint (e.g., "MIC2")
> +
> +required:
> + - compatible
> + - audio-cpu
> + - audio-codec
> + - audio-routing
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + sai3: sai@40031000 {
> + compatible = "fsl,imx8mp-sai";
> + reg = <0x40031000 0x1000>;
> + };
Drop node, not relevant.
> +
> + codec: es8316@11 {
> + compatible = "everest,es8316";
> + reg = <0x11>;
> + };
Drop node, not relevant.
> +
> + sound {
> + compatible = "fsl,imx-audio-es8316";
> + model = "imx-audio-es8316";
> + audio-cpu = <&sai3>;
> + audio-codec = <&codec>;
> + format = "i2s";
> + hp-det-gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
> + audio-routing =
> + "Mic Jack", "MIC2",
> + "Headphone Jack", "HPOL",
> + "Headphone Jack", "HPOR";
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio
2025-07-29 7:14 ` Krzysztof Kozlowski
@ 2025-07-29 7:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-29 7:34 UTC (permalink / raw)
To: WangErQian, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, imx
Cc: linux-arm-kernel, john
On 29/07/2025 09:14, Krzysztof Kozlowski wrote:
>> +
>> + status:
>> + type: string
>> + enum: [ "okay", "disabled" ]
>> + default: "okay"
>
> Do you see ANY binding with such syntax? No. There is no and this should
> be a hint that you are doing something wrong.
Unless you wrote it with AI. This would explain a lot.
That's a no go and waste of our time. Don't do that.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio
2025-07-29 3:13 [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio WangErQian
2025-07-29 7:14 ` Krzysztof Kozlowski
@ 2025-07-29 13:12 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-07-29 13:12 UTC (permalink / raw)
To: WangErQian
Cc: Conor Dooley, linux-arm-kernel, devicetree, Krzysztof Kozlowski,
john, imx
On Tue, 29 Jul 2025 11:13:52 +0800, WangErQian wrote:
> Add bindings for Debix Model A Bluetooth and audio
>
> This patch adds device tree binding documentation for:
> - fsl,mxc_bt_rfkill.yaml: Bluetooth RF control node
> - fsl,imx-audio-es8316.yaml: Audio codec interface
>
> Signed-off-by: WangErQian <WangErQianY@icloud.com>
> ---
> .../bindings/bluetooth/fsl,mxc_bt_rfkill.yaml | 70 +++++++++++++++
> .../bindings/sound/fsl,imx-audio-es8316.yaml | 88 +++++++++++++++++++
> 2 files changed, 158 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml:2:1: [error] missing document start "---" (document-start)
./Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml:40:13: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml:40:21: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml:41:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:2:1: [error] missing document start "---" (document-start)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:21:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:36:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:36:19: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:36:38: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:36:56: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:36:65: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml:37:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml: ignoring, error in schema: properties: pinctrl-0: type
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: ignoring, error in schema: properties: hp-det-gpio: type
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml: properties:pinctrl-0:type: 'anyOf' conditional failed, one must be fixed:
'phandle' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']
'phandle' is not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml: properties:pinctrl-names: {'maxItems': 1, 'items': [{'const': 'default'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml: properties:pinctrl-0:type: 'phandle' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.yaml: properties:status:type: 'string' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-routing:type: 'anyOf' conditional failed, one must be fixed:
'string-array' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']
'string-array' is not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-cpu:type: 'anyOf' conditional failed, one must be fixed:
'phandle' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']
'phandle' is not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-codec:type: 'anyOf' conditional failed, one must be fixed:
'phandle' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']
'phandle' is not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:hp-det-gpio:type: 'anyOf' conditional failed, one must be fixed:
'phandle-array' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']
'phandle-array' is not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-routing:items: {'minItems': 2, 'maxItems': 2, 'items': [{'description': 'Source endpoint (e.g., "Mic Jack")'}, {'description': 'Sink endpoint (e.g., "MIC2")'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-routing:items: 'oneOf' conditional failed, one must be fixed:
[{'description': 'Source endpoint (e.g., "Mic Jack")'}, {'description': 'Sink endpoint (e.g., "MIC2")'}] is too long
[{'description': 'Source endpoint (e.g., "Mic Jack")'}, {'description': 'Sink endpoint (e.g., "MIC2")'}] is too short
False schema does not allow 2
1 was expected
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:hp-det-gpio: {'type': 'phandle-array', 'description': 'GPIO for headphone detection (active high)', 'maxItems': 1, 'items': [{'description': 'GPIO specifier (controller + pin + flags)'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:model:type: 'string' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-cpu:type: 'phandle' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-codec:type: 'phandle' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:format:type: 'string' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:hp-det-gpio:type: 'phandle-array' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:audio-routing:type: 'string-array' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.yaml: properties:hp-det-gpio: 'anyOf' conditional failed, one must be fixed:
'type' is not one of ['maxItems', 'description', 'deprecated']
hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values.
'items' is not one of ['maxItems', 'description', 'deprecated']
hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values.
Additional properties are not allowed ('type' was unexpected)
hint: Arrays must be described with a combination of minItems/maxItems/items
'type' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
'items' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
1 is less than the minimum of 2
hint: Arrays must be described with a combination of minItems/maxItems/items
hint: cell array properties must define how many entries and what the entries are when there is more than one entry.
from schema $id: http://devicetree.org/meta-schemas/gpios.yaml#
Error: Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.example.dts:21.17-18 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/bluetooth/fsl,mxc_bt_rfkill.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dts:26.13-26: Warning (reg_format): /example-0/es8316@11:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx8mp-sai'] is too short
'fsl,imx8mp-sai' is not one of ['fsl,imx6ul-sai', 'fsl,imx7d-sai']
'fsl,imx8mp-sai' is not one of ['fsl,imx6sx-sai', 'fsl,imx7ulp-sai', 'fsl,imx8mq-sai', 'fsl,imx8qm-sai', 'fsl,imx8ulp-sai', 'fsl,imx93-sai', 'fsl,imx95-sai', 'fsl,vf610-sai']
'fsl,imx8mp-sai' is not one of ['fsl,imx94-sai']
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): 'clock-names' is a required property
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): 'dmas' is a required property
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): 'dma-names' is a required property
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: sai@40031000 (fsl,imx8mp-sai): Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/sound/fsl,sai.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: es8316@11 (everest,es8316): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/sound/everest,es8316.yaml#
Documentation/devicetree/bindings/sound/fsl,imx-audio-es8316.example.dtb: /example-0/sound: failed to match any schema with compatible: ['fsl,imx-audio-es8316']
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1526: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250729031351.3875406-1-WangErQianY@icloud.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-29 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 3:13 [PATCH v1 dt-bindings]dt-bindings: debix-model-a: Add bindings for BT and audio WangErQian
2025-07-29 7:14 ` Krzysztof Kozlowski
2025-07-29 7:34 ` Krzysztof Kozlowski
2025-07-29 13:12 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).