From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joy Zou <joy.zou@nxp.com>,
frank.li@nxp.com, peng.fan@nxp.com, vkoul@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
Date: Thu, 11 Apr 2024 10:13:38 +0200 [thread overview]
Message-ID: <703311b6-ee3a-4131-ae11-57b8d765db5c@kernel.org> (raw)
In-Reply-To: <20240411074326.2462497-3-joy.zou@nxp.com>
On 11/04/2024 09:43, Joy Zou wrote:
> The compatible string "fsl,imx8qm-adma" is unused.
Why? Commit must stand on its own.
>
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
> Documentation/devicetree/bindings/dma/fsl,edma.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e..64fa27d0cd9b 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,7 +21,6 @@ properties:
> - enum:
> - fsl,vf610-edma
> - fsl,imx7ulp-edma
> - - fsl,imx8qm-adma
I see more usages. One more trivial patch which is incorrect.
Did you implement the internal review?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-11 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 7:43 [PATCH v2 0/2] clean up unused "fsl,imx8qm-adma" compatible string Joy Zou
2024-04-11 7:43 ` [PATCH v2 1/2] dmaengine: fsl-edma: Remove " Joy Zou
2024-04-11 14:29 ` Frank Li
2024-04-11 7:43 ` [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up " Joy Zou
2024-04-11 8:13 ` Krzysztof Kozlowski [this message]
2024-04-11 13:21 ` [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible stringg Frank Li
2024-04-12 1:59 ` Joy Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703311b6-ee3a-4131-ae11-57b8d765db5c@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox