From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.denx.de (mx.denx.de [89.58.32.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A10861DFE1 for ; Wed, 25 Dec 2024 20:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.32.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735159815; cv=none; b=fD8d9YgTbWVrOBj5SmAafdG/SNdAfabTgCdEwJGvmw1GnvQ/Kt2NPqcdOt5JGm4N6b/sx6yhMKYvvTnQ3Wb072WRRxABEJAjRfYmncvM7zteDOHypAO+fQ/KGprvn9gJx52wMqu/hypqIe8X+HksstWlZLp4DEWX4mVAbNlvkWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735159815; c=relaxed/simple; bh=BNmb2VVZFsIjMRcdliG2H8NqXsv1KtwdPvJJvoIJSv4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jkxe5BoUcUbcbVa8yUpDUk9LdsGkINAVz/QdJ7RHVMbnFtw1qW0p68KN1XOLKWcm4QUUvLodyRwbSBM6GZKzMYmo/iM8JG3sxhshy8HZ1AoU268vaGBlZruAN+O1mJHH0I0OyRW3PfnJ6OsaGYN9V8Yt5bc1KgUv+GSkfQ1uMcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=XUtzIYse; arc=none smtp.client-ip=89.58.32.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="XUtzIYse" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 98BA8101ECBAB; Wed, 25 Dec 2024 21:49:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=mx-20241105; t=1735159804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j1aKFcorootUYVtMFPW/mgDVu+jID0c/UKLZ3rEjMkg=; b=XUtzIYseNKvVglNpfrWy4JZf5UDR0LygYVLIYjGMWIURe2VGSw9m0BROpIjFW2GcVwxZRT oNwxXTpw+o6ZmvcOXTds7frgeDq7nNDDYth7iqUblMu674db0ZH7ePk0lzc5yj7NEbWQlP 3jtFBLB8O01UirBg9mgK4ogojhovYOFt9G+S9MO+qWXcS7fqhj6ELZH/zsXZkpoeCddi3m VKHgyOGExi6RlKiCfKju+ViFFe9s55r6XyVnt/sb58M/QvOL7VbJ6o2QO72deVIDebzHgE PhRUAwHy/97CxNBvsiTZ83BoJ5V0Wn3ExPJNKc9wbSlAMkXsaLP8Tk8WAiHRzQ== Message-ID: <75dc6f74-f828-49ac-8bf6-41fd4e197855@denx.de> Date: Wed, 25 Dec 2024 21:40:55 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR To: Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , David Airlie , Fabio Estevam , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Liu Ying , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Pengutronix Kernel Team , Robert Foss , Sascha Hauer , Shawn Guo , Simona Vetter , Stefan Agner , Thomas Zimmermann , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20241224014701.253490-1-marex@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 12/24/24 5:21 AM, Dmitry Baryshkov wrote: > On Tue, Dec 24, 2024 at 02:46:14AM +0100, Marek Vasut wrote: >> The dw-hdmi output_port is set to 1 in order to look for a connector >> next bridge in order to get DRM_BRIDGE_ATTACH_NO_CONNECTOR working. >> The output_port set to 1 makes the DW HDMI driver core look up the >> next bridge in DT, where the next bridge is often the hdmi-connector . >> >> Similar to 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR") >> >> Signed-off-by: Marek Vasut >> --- >> Cc: Andrzej Hajda >> Cc: David Airlie >> Cc: Fabio Estevam >> Cc: Jernej Skrabec >> Cc: Jonas Karlman >> Cc: Laurent Pinchart >> Cc: Liu Ying >> Cc: Maarten Lankhorst >> Cc: Maxime Ripard >> Cc: Neil Armstrong >> Cc: Pengutronix Kernel Team >> Cc: Robert Foss >> Cc: Sascha Hauer >> Cc: Shawn Guo >> Cc: Simona Vetter >> Cc: Stefan Agner >> Cc: Thomas Zimmermann >> Cc: dri-devel@lists.freedesktop.org >> Cc: imx@lists.linux.dev >> Cc: linux-arm-kernel@lists.infradead.org >> --- >> V2: No change >> --- >> drivers/gpu/drm/bridge/imx/Kconfig | 1 + >> drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig >> index 9a480c6abb856..d8e9fbf75edbb 100644 >> --- a/drivers/gpu/drm/bridge/imx/Kconfig >> +++ b/drivers/gpu/drm/bridge/imx/Kconfig >> @@ -27,6 +27,7 @@ config DRM_IMX8MP_DW_HDMI_BRIDGE >> config DRM_IMX8MP_HDMI_PVI >> tristate "Freescale i.MX8MP HDMI PVI bridge support" >> depends on OF >> + select DRM_DISPLAY_CONNECTOR >> help >> Choose this to enable support for the internal HDMI TX Parallel >> Video Interface found on the Freescale i.MX8MP SoC. >> diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c >> index 1e7a789ec2890..4ebae5ad072ad 100644 >> --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c >> +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c >> @@ -101,6 +101,7 @@ static int imx8mp_dw_hdmi_probe(struct platform_device *pdev) >> plat_data->phy_name = "SAMSUNG HDMI TX PHY"; >> plat_data->priv_data = hdmi; >> plat_data->phy_force_vendor = true; >> + plat_data->output_port = 1; > > Quoting my feedback to a similar Liu's patch: > > This will break compatibility with older DT files, which don't have > output port. I think you need to add output_port_optional flag to > dw_hdmi_plat_data and still return 0 from dw_hdmi_parse_dt() if the flag > is set, but there is no remote node. Looking at the upstream imx8mp*dts , the oldest commit which adds HDMI support is commit: 3e67a1ddd56d ("arm64: dts: imx8mp: Enable HDMI on TQMa8MPxL/MBa8MPxL") That already contains the HDMI connector node. Every follow up addition of HDMI to another device has been a copy of the same commit, with connector, so I think it is safe to say, no upstream DT is going to be broken by this change. Do we care about hypothetical downstream DTs which may be missing the connector ?