Re: [PATCH 1/2] arm64: dts: freescale: Add FRDM-IMX91 basic support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/11/2025 07:55, Joseph Guo wrote:
> +
> +	reserved-memory {
> +		ranges;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +
> +		linux,cma {
> +			compatible = "shared-dma-pool";
> +			alloc-ranges = <0 0x80000000 0 0x30000000>;
> +			reusable;
> +			size = <0 0x10000000>;
> +			linux,cma-default;
> +		};
> +	};
> +
> +	sound-mqs {
> +		compatible = "fsl,imx6sx-sdb-mqs",
> +			     "fsl,imx-audio-mqs";
> +		audio-codec = <&mqs1>;
> +		audio-cpu = <&sai1>;
> +		model = "mqs-audio";
> +	};
> +
> +	sw-keys {

That's not how the node is called. Either use existing name or follow DT
spec in node naming.

> +		compatible = "gpio-keys";
> +
> +		K2: user_btn1 {


It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.

And underscore used... Please do not send us downstream code.

You need to write it from scratch from usptream code, not send us what
you have in downstream.

...

> +	};
> +
> +	pcf2131: rtc@53 {
> +		compatible = "nxp,pcf2131";
> +		reg = <0x53>;
> +		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-parent = <&pcal6524>;
> +		status = "okay";

Why?

> +	};
> +};
> +
> +&lpspi3 {
> +	cs-gpios = <&gpio2 8 GPIO_ACTIVE_LOW>;
> +	pinctrl-0 = <&pinctrl_lpspi3>;
> +	pinctrl-1 = <&pinctrl_lpspi3>;
> +	pinctrl-names = "default", "sleep";
> +	gpio = <&pcal6408 0 GPIO_ACTIVE_HIGH>;
> +	status = "okay";
> +
> +	spidev0: spi@0 {
> +		compatible = "lwn,bk4";

NAK, don't fake nodes. Just because downstream uses this, is not correct
argument. This does not exist here.

...

> +
> +	pinctrl_usdhc2_gpio_sleep: usdhc2gpiogrpsleep {

You still not bother to test your own code... Again, why are you sending
downstream code?

Best regards,
Krzysztof