Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/03/2025 13:39, Lukasz Majewski wrote:
> Hi Krzysztof,
> 
>> On 25/03/2025 13:15, Lukasz Majewski wrote:
>>> Hi Krzysztof,
>>>   
>>>> On 25/03/2025 12:57, Lukasz Majewski wrote:  
>>>>> This patch provides description of the MTIP L2 switch available in
>>>>> some NXP's SOCs - imx287, vf610.
>>>>>
>>>>> Signed-off-by: Lukasz Majewski <lukma@denx.de>
>>>>> ---
>>>>>  .../bindings/net/fec,mtip-switch.yaml         | 160
>>>>> ++++++++++++++++++    
>>>>
>>>> Use compatible as filename.  
>>>
>>> I've followed the fsl,fec.yaml as an example. This file has
>>> description for all the device tree sources from fec_main.c  
>>
>>
>> That's a 14 year old binding, so clear antipattern.
> 
> For some reason it is still there...

And it will be there for very long time. Bindings are not removed just
because they are old, because they are an ABI. That's still not a reason
to use something old as starting point.

It's the same with drivers, although driver can be easier changed and
old pattern can be dropped. You cannot easily drop old, anti-patterns
from the binding.

Best regards,
Krzysztof