From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Frank Li <Frank.li@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com,
sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, marex@denx.de,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de
Subject: Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller
Date: Mon, 27 May 2024 11:01:09 +0300 [thread overview]
Message-ID: <7ee00c15-ed39-4092-be79-d4683d1c3ee2@moroto.mountain> (raw)
In-Reply-To: <CAA+D8ANOQ8Pgt8QZWduZoVKCcb8Mdc=Xzotu4zAqakTjHO8pBQ@mail.gmail.com>
On Fri, May 24, 2024 at 09:49:08AM +0800, Shengjiu Wang wrote:
> On Fri, May 24, 2024 at 4:36 AM Frank Li <Frank.li@nxp.com> wrote:
> > > +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
> > > + struct clk_imx8mp_audiomix_priv *priv)
> > > +{
> > > + struct auxiliary_device __free(kfree) * adev = NULL;
> >
> > nit: *adev = NULL;
>
> Actually, the checkpatch.pl told me need to have space after '*'...
Someone should fix checkpatch so that it knows that __free() is an
attribute, not a function call. (The cleanup.h stuff is quite new).
regards,
dan carpenter
next prev parent reply other threads:[~2024-05-27 8:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 9:59 [PATCH v5 0/5] clk: imx: clk-audiomix: Improvement for audiomix Shengjiu Wang
2024-05-23 9:59 ` [PATCH v5 1/5] dt-bindings: clock: imx8mp: Add #reset-cells property Shengjiu Wang
2024-05-23 9:59 ` [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller Shengjiu Wang
2024-05-23 20:36 ` Frank Li
2024-05-24 1:49 ` Shengjiu Wang
2024-05-27 8:01 ` Dan Carpenter [this message]
2024-05-25 7:26 ` Markus Elfring
2024-05-27 3:43 ` Shengjiu Wang
2024-05-23 9:59 ` [PATCH v5 3/5] reset: imx-aux: Add i.MX auxiliary reset driver Shengjiu Wang
2024-05-23 9:59 ` [PATCH v5 4/5] clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks Shengjiu Wang
2024-05-24 1:04 ` Peng Fan
2024-05-23 9:59 ` [PATCH v5 5/5] clk: imx: clk-audiomix: Corrent parent clock for earc_phy and audpll Shengjiu Wang
2024-05-24 1:05 ` Peng Fan
2024-05-25 7:55 ` Markus Elfring
2024-05-27 3:44 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee00c15-ed39-4092-be79-d4683d1c3ee2@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=Frank.li@nxp.com \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox