From: Marek Vasut <marex@denx.de>
To: Liu Ying <victor.liu@nxp.com>, dri-devel@lists.freedesktop.org
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
David Airlie <airlied@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Robert Foss <rfoss@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Simona Vetter <simona@ffwll.ch>,
Stefan Agner <stefan@agner.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] drm/mxsfb: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach
Date: Mon, 30 Dec 2024 22:50:16 +0100 [thread overview]
Message-ID: <828f28ce-007b-43c1-9ea4-98be5c14078e@denx.de> (raw)
In-Reply-To: <20f33e1e-b531-4755-b414-02ab897e16af@nxp.com>
On 12/30/24 8:29 AM, Liu Ying wrote:
[...]
>> @@ -139,21 +140,35 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
>> if (!bridge)
>> return -ENODEV;
>>
>> - ret = drm_bridge_attach(&mxsfb->encoder, bridge, NULL, 0);
>> + ret = drm_bridge_attach(&mxsfb->encoder, bridge, NULL,
>> + DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>> if (ret)
>> return dev_err_probe(drm->dev, ret, "Failed to attach bridge\n");
>>
>> - mxsfb->bridge = bridge;
>> + connector = drm_bridge_connector_init(drm, &mxsfb->encoder);
>
> Nit: Drop connector and use mxsfb->connector?
The code becomes too wide. The rest is fixed in V3.
next prev parent reply other threads:[~2024-12-30 22:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 1:46 [PATCH v2 1/3] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR Marek Vasut
2024-12-24 1:46 ` [PATCH v2 2/3] drm/lcdif: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach Marek Vasut
2024-12-30 7:18 ` Liu Ying
2024-12-30 22:11 ` Marek Vasut
2024-12-30 22:42 ` Dmitry Baryshkov
2024-12-24 1:46 ` [PATCH v2 3/3] drm/mxsfb: " Marek Vasut
2024-12-24 4:09 ` Dmitry Baryshkov
2024-12-30 7:29 ` Liu Ying
2024-12-30 21:50 ` Marek Vasut [this message]
2024-12-24 4:21 ` [PATCH v2 1/3] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR Dmitry Baryshkov
2024-12-25 20:40 ` Marek Vasut
2024-12-26 20:21 ` Dmitry Baryshkov
2024-12-30 7:04 ` Ying Liu
2024-12-30 13:48 ` Dmitry Baryshkov
2024-12-30 21:44 ` Marek Vasut
2024-12-30 23:48 ` Dmitry Baryshkov
2025-01-13 9:13 ` Frieder Schrempf
2024-12-30 6:57 ` Liu Ying
2024-12-30 21:41 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=828f28ce-007b-43c1-9ea4-98be5c14078e@denx.de \
--to=marex@denx.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=stefan@agner.ch \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox