From: Andrew Lunn <andrew@lunn.ch>
To: "Joseph Guo (OSS)" <qijian.guo@oss.nxp.com>
Cc: Joseph Guo <qijian.guo@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Justin Jiang <justin.jiang@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Tom Zheng <haidong.zheng@nxp.com>,
Steven Yang <steven.yang@nxp.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: Add FRDM-IMX91 basic support
Date: Fri, 12 Dec 2025 14:32:59 +0100 [thread overview]
Message-ID: <8334a902-fd56-4860-82c5-402e1d982fa9@lunn.ch> (raw)
In-Reply-To: <15608952-e974-4b9f-9832-e6a23860fc62@oss.nxp.com>
On Fri, Dec 12, 2025 at 02:03:03PM +0800, Joseph Guo (OSS) wrote:
>
>
> On 12/12/2025 11:39 AM, Andrew Lunn wrote:
> > [You don't often get email from andrew@lunn.ch. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > > +&fec {
> > > + phy-handle = <ðphy2>;
> > > + phy-mode = "rgmii-id";
> > > + pinctrl-0 = <&pinctrl_fec>;
> > > + pinctrl-1 = <&pinctrl_fec_sleep>;
> > > + pinctrl-names = "default", "sleep";
> > > + fsl,magic-packet;
> >
> > Have you tested WoL?
> >
> > Andrew
>
> Hi Andrew,
>
> Yes, already tested.
Great. There is a tendency to just copy/paste this propriety without
understanding what it implies, so i just wanted to check...
For the Ethernet & PHY nodes only:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-12-12 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 2:31 [PATCH v2 0/2] Add FRDM i.MX 91 Development board support Joseph Guo
2025-12-12 2:31 ` [PATCH v2 1/2] dt-bindings: arm: imx Add FRDM-IMX91 board Joseph Guo
2025-12-12 9:57 ` Daniel Baluta
2025-12-16 6:02 ` Krzysztof Kozlowski
2025-12-12 2:31 ` [PATCH v2 2/2] arm64: dts: freescale: Add FRDM-IMX91 basic support Joseph Guo
2025-12-12 3:39 ` Andrew Lunn
2025-12-12 6:03 ` Joseph Guo (OSS)
2025-12-12 13:32 ` Andrew Lunn [this message]
2025-12-30 4:11 ` Shawn Guo
2025-12-13 14:48 ` [PATCH v2 0/2] Add FRDM i.MX 91 Development board support Francesco Valla
2025-12-15 2:36 ` Joseph Guo (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8334a902-fd56-4860-82c5-402e1d982fa9@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haidong.zheng@nxp.com \
--cc=imx@lists.linux.dev \
--cc=justin.jiang@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qijian.guo@nxp.com \
--cc=qijian.guo@oss.nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=steven.yang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox