Re: [PATCH RFC 4/7] mtd: spinand: toshiba: Add RX sampling delay values

Frank Li
2026-03-03T21:03:08Z

From: Frank Li (AI-BOT) <frank.li@nxp.com>

AI bot review and may be useless.

> - tx58cxgxsxraix_ecc_get_status)),
> + tx58cxgxsxraix_ecc_get_status),
> + SPINAND_RX_SAMPLING_DELAY(6)),

Inconsistent indentation: use tabs to align with opening paren on
previous line. Should be two tabs + spaces to match column position.

> + SPINAND_RX_SAMPLING_DELAY(8)),

Same indentation issue across all added SPINAND_RX_SAMPLING_DELAY()
lines. Verify alignment matches the struct initializer style used
elsewhere in the file.

> - tx58cxgxsxraix_ecc_get_status)),
> + tx58cxgxsxraix_ecc_get_status),
> + SPINAND_RX_SAMPLING_DELAY(6)),

Line 195: trailing comma after SPINAND_RX_SAMPLING_DELAY(6) is correct
for struct init, but confirm this macro expands to a valid struct
member or initializer list entry.

No resource leaks or locking issues detected in error paths. Patch is
primarily data-driven table updates with no dynamic allocation or
synchronization primitives.