Re: [EXT] Re: [PATCH v9 2/4] irqchip: Add IMX MU MSI controller driver

Marc Zyngier
2022-09-13T17:44:39Z

On Mon, 12 Sep 2022 16:53:40 +0100,
Frank Li <frank.li@nxp.com> wrote:
>
> > > [Frank Li] I remember you said that irq-chip can't be removed.
> > > So I am not sure why need build as module.
> >
> > Not being removed doesn't mean it cannot be built as a module and
> > loaded on demand. Why should I be forced to have this driver built-in
> > if my kernel is used on a variety of systems, only one of them having
> > this device?
>
> [Frank Li] A problem, platform_msi_create_irq_domain have NOT export
> to let module Call it.
> https://elixir.bootlin.com/linux/latest/source/drivers/base/platform-msi.c#L122
>
> Do you want to me add EXPORT_SYMBOL_GPL for it OR keep "bool" here?

Please add a patch exporting the missing symbols, and make the think
modular.

M.

--
Without deviation from the norm, progress is not possible.