Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>,
	imx@lists.linux.dev, linux-sound@vger.kernel.org,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Iuliana Prodan <iuliana.prodan@nxp.com>,
	Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
	Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] ASoC: SOF: imx: introduce more common structures and functions
Date: Fri, 7 Feb 2025 17:35:49 +0100	[thread overview]
Message-ID: <8b96ad7e-5a47-458f-bb42-7b7c9efb82e1@web.de> (raw)
In-Reply-To: <20250207162246.3104-2-laurentiumihalcea111@gmail.com>

…
> +++ b/sound/soc/sof/imx/imx-common.c
> @@ -1,11 +1,16 @@
> +static void imx_handle_reply(struct imx_dsp_ipc *ipc)
> +{
> +	spin_lock_irqsave(&sdev->ipc_lock, flags);
> +	snd_sof_ipc_process_reply(sdev, 0);
> +	spin_unlock_irqrestore(&sdev->ipc_lock, flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&sdev->ipc_lock);”?
https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/spinlock.h#L572

Regards,
Markus

  reply	other threads:[~2025-02-07 16:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 16:22 [PATCH v3 0/7] Refactor imx drivers and introduce support for imx95 Laurentiu Mihalcea
2025-02-07 16:22 ` [PATCH v3 1/7] ASoC: SOF: imx: introduce more common structures and functions Laurentiu Mihalcea
2025-02-07 16:35   ` Markus Elfring [this message]
2025-02-07 16:22 ` [PATCH v3 2/7] ASoC: SOF: imx8: use common imx chip interface Laurentiu Mihalcea
2025-02-07 16:22 ` [PATCH v3 3/7] ASoC: SOF: imx8: use IMX_SOF_* macros Laurentiu Mihalcea
2025-02-07 16:22 ` [PATCH v3 4/7] ASoC: SOF: imx8: drop unneeded/unused macros/header includes Laurentiu Mihalcea
2025-02-07 16:22 ` [PATCH v3 5/7] ASoC: SOF: imx: merge imx8 and imx8m drivers Laurentiu Mihalcea
2025-02-07 16:22 ` [PATCH v3 6/7] ASoC: SOF: imx: merge imx8 and imx8ulp drivers Laurentiu Mihalcea
2025-02-07 16:22 ` [PATCH v3 7/7] ASoC: SOF: imx: add driver for the imx95 chip Laurentiu Mihalcea
2025-02-10 16:30 ` [PATCH v3 0/7] Refactor imx drivers and introduce support for imx95 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b96ad7e-5a47-458f-bb42-7b7c9efb82e1@web.de \
    --to=markus.elfring@web.de \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=iuliana.prodan@nxp.com \
    --cc=laurentiu.mihalcea@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox