From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: Marek Vasut <marek.vasut@mailbox.org>,
Eduard Bostina <egbostina@gmail.com>,
daniel.baluta@nxp.com, simona.toaca@nxp.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Marek Vasut <marex@denx.de>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, kernel@dh-electronics.com,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
Date: Tue, 17 Mar 2026 09:36:42 +0200 [thread overview]
Message-ID: <8e3f6df0-9d93-4e17-8db5-1dc96999006e@oss.nxp.com> (raw)
In-Reply-To: <2313c717-1729-48a2-8fc7-63b68ce0a0e6@mailbox.org>
On 3/13/26 18:44, Marek Vasut wrote:
> On 3/9/26 7:15 PM, Eduard Bostina wrote:
>> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
>> raw value is written in this register. This makes the code not obvious
>> to read and modify.
[..]
>> pinctrl_ptn5150: ptn5150grp {
>> fsl,pins = <
>> - MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x40000000
>> + MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 MX8MP_SION
> Isn't the SION bit at the same bit offset at least since iMX5x ? Maybe
> the MX8MP_* prefix isn't necessary ?
>
Hi Marek,
I think this can be factored out once we finish moving all the configs to symbolic macros.
prev parent reply other threads:[~2026-03-17 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 18:15 [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25 Eduard Bostina
2026-03-11 8:00 ` Daniel Baluta
2026-03-13 16:26 ` Frank Li
2026-03-13 16:44 ` Marek Vasut
2026-03-17 7:36 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3f6df0-9d93-4e17-8db5-1dc96999006e@oss.nxp.com \
--to=daniel.baluta@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=cniedermaier@dh-electronics.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=egbostina@gmail.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@mailbox.org \
--cc=marex@denx.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=simona.toaca@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox