Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	imx@lists.linux.dev, kernel@dh-electronics.com,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: Convert i.MX35/5x/6 to YAML
Date: Thu, 17 Oct 2024 01:16:02 +0200	[thread overview]
Message-ID: <9265a263-ccf3-4e9f-b7e0-69f62ec61eba@denx.de> (raw)
In-Reply-To: <20241016172642.GA1991636-robh@kernel.org>

On 10/16/24 7:26 PM, Rob Herring wrote:
> On Wed, Oct 16, 2024 at 01:20:51AM +0200, Marek Vasut wrote:
>> The IOMUXC controller description is almost identical on i.MX35/5x/6 SoCs,
>> except for the configuration bits which differ across SoCs. Rename the
>> fsl,imx6ul-pinctrl.yaml to fsl,imx35-pinctrl.yaml, fill in compatible
>> strings for the other SoCs and fill in the various bits into desciption.
>> This way, i.MX35/5x/6 series SoCs can all be converted to YAML DT. Remove
>> the old text DT bindings description.
> 
> Just a nit, but I prefer 'DT schema' over using 'YAML DT' or just
> 'YAML'. YAML is just the file format we use and YAML is a lot of things
> that's not DT schema including other uses/attempts with DT.

Fixed in V2 and also in the LTC3676 conversion, thanks.

> This generates lots of warnings (patchwork has the output) for pincfg
> nodes which don't match 'grp$' node name convention. Do we really want
> to "fix" all of those?

I had a look and many of those are simple, so I would say yes.

> We could allow anything, but then we don't
> enforce anything on new stuff.

We do enforce grp$ on iMX8M , it just wasn't enforced on old DTs yet.

> Or this could be split between new and
> old platforms. If we decide to fix any old ones, then just have to move
> them to the "new" schema.
Strictly speaking, iMX6 and older are all old platforms, but I think it 
should be easy to fix them up.

  reply	other threads:[~2024-10-17  0:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 23:20 [PATCH] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: Convert i.MX35/5x/6 to YAML Marek Vasut
2024-10-16  6:58 ` [PATCH] dt-bindings: pinctrl: fsl, imx6ul-pinctrl: " Alexander Stein
2024-10-16 23:13   ` Marek Vasut
2024-10-16 17:26 ` [PATCH] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: " Rob Herring
2024-10-16 23:16   ` Marek Vasut [this message]
2024-10-17  0:23     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9265a263-ccf3-4e9f-b7e0-69f62ec61eba@denx.de \
    --to=marex@denx.de \
    --cc=aisheng.dong@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@dh-electronics.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox