From: Markus Elfring <Markus.Elfring@web.de>
To: Wei Fang <wei.fang@nxp.com>, Julia Lawall <julia.lawall@inria.fr>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
imx@lists.linux.dev
Cc: Peter Zijlstra <peterz@infradead.org>,
Simon Horman <horms@kernel.org>, Waiman Long <longman@redhat.com>,
Andrew Lunn <andrew@lunn.ch>, Clark Wang <xiaoning.wang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Shenwei Wang <shenwei.wang@nxp.com>
Subject: Re: [v2] net: fec: Convert fec driver to use lock guards
Date: Mon, 24 Jun 2024 08:33:24 +0200 [thread overview]
Message-ID: <94b76f8d-5886-4a1e-8469-712be369ee9e@web.de> (raw)
In-Reply-To: <PAXPR04MB85106653965E0694C2C84E4C88D42@PAXPR04MB8510.eurprd04.prod.outlook.com>
> This patch has been rejected because netdev people don't want these sort of
> conversions at present which will make backporting more difficult.
Advanced development tools can help to adjust involved concerns another bit.
Some contributors got used to capabilities of the semantic patch language
(Coccinelle software) for example.
Will any clarifications become more helpful here?
Would you get useful insights from special information sources?
Looking at guard usage (with SmPL)
https://lore.kernel.org/cocci/2dc6a1c7-79bf-42e3-95cc-599a1e154f57@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2024-05/msg00090.html
> The LOCK EVASION issue has been fixed by another patch.
https://lore.kernel.org/r/20240521023800.17102-1-wei.fang@nxp.com
Further software evolution might become more interesting also around
the commit 3b1c92f8e5371700fada307cc8fd2c51fa7bc8c1 ("net: fec:
avoid lock evasion when reading pps_enable").
Regards,
Markus
prev parent reply other threads:[~2024-06-24 6:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 3:02 [PATCH v2 net-next] net: fec: Convert fec driver to use lock guards Wei Fang
2024-05-11 14:29 ` Andrew Lunn
2024-05-13 1:21 ` Wei Fang
2024-06-23 11:01 ` Markus Elfring
2024-06-23 11:43 ` Markus Elfring
2024-06-24 1:35 ` [PATCH v2 net-next] " Wei Fang
2024-06-24 6:33 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94b76f8d-5886-4a1e-8469-712be369ee9e@web.de \
--to=markus.elfring@web.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=longman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox