From: Roger Quadros <rogerq@kernel.org>
To: Frank Li <Frank.Li@nxp.com>, Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
"open list:CADENCE USB3 DRD IP DRIVER"
<linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH 1/2] usb: cdns3: fixed memory use after free at cdns3_gadget_ep_disable()
Date: Fri, 2 Feb 2024 13:40:21 +0200 [thread overview]
Message-ID: <9530e4c2-1da9-43a0-b40d-f877aad61319@kernel.org> (raw)
In-Reply-To: <20240202051829.623273-1-Frank.Li@nxp.com>
On 02/02/2024 07:18, Frank Li wrote:
> ...
> cdns3_gadget_ep_free_request(&priv_ep->endpoint, &priv_req->request);
> list_del_init(&priv_req->list);
> ...
>
> 'priv_req' actually free at cdns3_gadget_ep_free_request(). But
> list_del_init() use priv_req->list after it.
>
> [ 1542.642868][ T534] BUG: KFENCE: use-after-free read in __list_del_entry_valid+0x10/0xd4
> [ 1542.642868][ T534]
> [ 1542.653162][ T534] Use-after-free read at 0x000000009ed0ba99 (in kfence-#3):
> [ 1542.660311][ T534] __list_del_entry_valid+0x10/0xd4
> [ 1542.665375][ T534] cdns3_gadget_ep_disable+0x1f8/0x388 [cdns3]
> [ 1542.671571][ T534] usb_ep_disable+0x44/0xe4
> [ 1542.675948][ T534] ffs_func_eps_disable+0x64/0xc8
> [ 1542.680839][ T534] ffs_func_set_alt+0x74/0x368
> [ 1542.685478][ T534] ffs_func_disable+0x18/0x28
>
> Move list_del_init() before cdns3_gadget_ep_free_request() to resolve this
> problem.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
prev parent reply other threads:[~2024-02-02 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 5:18 [PATCH 1/2] usb: cdns3: fixed memory use after free at cdns3_gadget_ep_disable() Frank Li
2024-02-02 5:18 ` [PATCH 2/2] usb: cdns3: fix memory double free when handle zero package Frank Li
2024-02-02 11:42 ` Roger Quadros
2024-02-02 11:40 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9530e4c2-1da9-43a0-b40d-f877aad61319@kernel.org \
--to=rogerq@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox