From: Edward Cree <ecree.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
bharat@chelsio.com, benve@cisco.com, satishkh@cisco.com,
claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
wei.fang@nxp.com, xiaoning.wang@nxp.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
bryan.whitehead@microchip.com, rosenp@gmail.com,
imx@lists.linux.dev
Subject: Re: [PATCH net-next 6/6] eth: sfc: falcon: migrate to new RXFH callbacks
Date: Mon, 16 Jun 2025 16:32:25 +0100 [thread overview]
Message-ID: <98a48c7b-539e-41b3-ab3c-e2398401c7f7@gmail.com> (raw)
In-Reply-To: <20250613075010.0b59564d@kernel.org>
On 13/06/2025 15:50, Jakub Kicinski wrote:
> On Fri, 13 Jun 2025 14:44:40 +0100 Edward Cree wrote:
>> So granted that you're only moving code, but looking at this it doesn't
>> actually make sense, since every path that sets info->data to nonzero
>> also sets min_revision, so why not just do the ef4_nic_rev() check at
>> the start? Answer, from git log spelunking, is that when this code was
>> shared with Siena, EFX_REV_SIENA_A0 supported IPv6 here.
>
> Ack, I was tempted to clean this up, but it felt slightly outside of
> the objective. Looks like I need to respin for enetc - I can change
> it in v2 if you'd like?
I'd say just keep your patch as is, then I'll send a follow-up that does
the refactor and also adds a comment about why the hashing config is what
it is.
prev parent reply other threads:[~2025-06-16 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 0:54 [PATCH net-next 0/6] eth: migrate to new RXFH callbacks (get-only drivres) Jakub Kicinski
2025-06-13 0:54 ` [PATCH net-next 1/6] eth: cisco: migrate to new RXFH callbacks Jakub Kicinski
2025-06-13 5:42 ` Joe Damato
2025-06-13 0:54 ` [PATCH net-next 2/6] eth: cxgb4: " Jakub Kicinski
2025-06-13 5:43 ` Joe Damato
2025-06-13 0:54 ` [PATCH net-next 3/6] eth: lan743x: " Jakub Kicinski
2025-06-13 5:44 ` Joe Damato
2025-06-13 0:54 ` [PATCH net-next 4/6] eth: e1000e: " Jakub Kicinski
2025-06-13 5:46 ` Joe Damato
2025-06-13 0:54 ` [PATCH net-next 5/6] eth: enetc: " Jakub Kicinski
2025-06-13 2:00 ` Wei Fang
2025-06-13 0:54 ` [PATCH net-next 6/6] eth: sfc: falcon: " Jakub Kicinski
2025-06-13 13:44 ` Edward Cree
2025-06-13 14:50 ` Jakub Kicinski
2025-06-16 15:32 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a48c7b-539e-41b3-ab3c-e2398401c7f7@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bryan.whitehead@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rosenp@gmail.com \
--cc=satishkh@cisco.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox