From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from uho.ysoft.cz (uho.ysoft.cz [81.19.3.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E8514D6E6 for ; Wed, 18 Sep 2024 08:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=81.19.3.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726648364; cv=none; b=JRc+WYwPiFsdA4qosJ1AoqD9PEtmCPTsQGkWeNs4KAqILVSqmF1vMK0stu1OlKqSXu1mEkTzwDiWeo820JBIQXm4BxF06ZmvTyOEwE1RbPMXeAASzllbXGLd67USpFdObroAVM6K0psHtNKKLJ6HWrOp2UHUx4D56lViJLYi79w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726648364; c=relaxed/simple; bh=4bdcaWigprfYvBVzSps/LxeQRSmCfy9YoxxwSIdXq2c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bG7nrl9dvNeQpgHY2NoHmmXSfcEKpb1Y0eg9BG3fDt8eg9kjG93xgRvePLGutVkI63VWQygGktNd3OWYwQpTksPiK9Ndp91cHufKxB5RLDF+TgJoTIfTUocoQ5nL4qaA+5cLoj/Hsj5r+adEUakhpRs9BxM979oVs22SznWm7/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ysoft.com; spf=pass smtp.mailfrom=ysoft.com; dkim=pass (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b=gtTqPTWV; arc=none smtp.client-ip=81.19.3.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ysoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ysoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="gtTqPTWV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1726648359; bh=Y6OULQl6Ue3orcYsxG9AXjPiGVo+Zb0pbCMaMnhulC8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gtTqPTWVle/Hnqk+/UsZ5sGyHLenCiRzDxJgz0bNIUW3j7YymUZCb3uKf2ot9Le06 TSnlO5Tp0TEMq2Y7MPI1PyUhQVHyHoWFACpsCRkVpYsFCUyUxDADQT/itSt0aOSrKb AsB4C/WwxTDSg5eSQdSa6GF8rMOBmlpyfJN70j4w= Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 32E4FA0419; Wed, 18 Sep 2024 10:32:39 +0200 (CEST) Message-ID: <9c8410cb-cae4-458c-ac08-0fbe30956414@ysoft.com> Date: Wed, 18 Sep 2024 10:32:38 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: imx: Add imx8mp-iota2-lumpy board To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Shawn Guo , Petr Benes , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Herburger , Hiago De Franco , Hugo Villeneuve , Joao Paulo Goncalves , Michael Walle , Alexander Stein , Mathieu Othacehe , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240917151001.1289399-1-michal.vokac@ysoft.com> <20240917151001.1289399-3-michal.vokac@ysoft.com> Content-Language: en-US From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17. 09. 24 21:07, Frank Li wrote: > On Tue, Sep 17, 2024 at 05:09:59PM +0200, Michal Vokáč wrote: >> The IOTA2 Lumpy board is based on the i.MX8MPlus EVK. >> >> Basic features are: >> - 4GB LPDDR4 >> - 64GB eMMC >> - 2x 1GB Ethernet >> - USB 3.0 Type-C dual role port, without power delivery >> - USB 3.0 Type-A host port >> - RGB LED - PWM driven >> - speaker - PWM driven >> - RTC with super capacitor backup >> >> Signed-off-by: Michal Vokáč >> --- > > Suggest you try tools https://github.com/lznuaa/dt-format > > Any issue let me know. Hi Frank, I was aware of some non-written rules how the nodes and properties should be sorted but this will definitely help! I will try it for v2. Thanks a lot. >> arch/arm64/boot/dts/freescale/Makefile | 1 + >> .../boot/dts/freescale/imx8mp-iota2-lumpy.dts | 425 ++++++++++++++++++ >> 2 files changed, 426 insertions(+) >> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts >> >> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile >> index f04c22b7de72..421c36c5ae68 100644 >> --- a/arch/arm64/boot/dts/freescale/Makefile >> +++ b/arch/arm64/boot/dts/freescale/Makefile >> @@ -171,6 +171,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb >> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-iota2-lumpy.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mp-navqp.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts >> new file mode 100644 ... [snip] ... >> + >> +&pwm4 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm4>; >> + pwm-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>; ^^^ The pwm-gpios property should not be here. I will remove it in v2. >> + status = "okay"; >> +};