From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-108-mta59.mxroute.com (mail-108-mta59.mxroute.com [136.175.108.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA8F913AA59 for ; Thu, 28 Mar 2024 21:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.59 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711660300; cv=none; b=Gds0xu7xwbjXGa+zy+TDmORU+aSoPUXTMKJih22IakmaC0wXzafISwojmvR1f1yri/ruNNEtYfkVcR8pLjJll8ImmaJoj9+pqvWhbOe+uyYy/RBu1IvSD14XB1eoCehujpSNb3fuipROmW/Ps6QNdiuKr9fUC4c67tYWAqv6/HE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711660300; c=relaxed/simple; bh=SmKe/yhbdoqPTkVgza3Z9zpPopSENs97/wuhoRbvMyY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TUdKKkp9DYcvTzQC3xsZV6k/oAn2esQrtWChUwk0rtnR9a/m3oIibX4qTuTYWXFcRr5di9n4SDDfy6qzsXpuGcKrBso8JpVqytaJcqPOVXtInOy2HkU6gusi8jPc17LQZX25KbOqDtfvDtQCr5+qpGriwnOzMDIZn5Fa+TXfotU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=TtnrXRvD; arc=none smtp.client-ip=136.175.108.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="TtnrXRvD" Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta59.mxroute.com (ZoneMTA) with ESMTPSA id 18e86e7622a0003bea.00a for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 28 Mar 2024 21:11:34 +0000 X-Zone-Loop: c49159b08e1f694f0adafc565fe75c0696caf5afa3f1 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U3vA31p2lCcvrgxArhpPfKr/obl7YqxdRKOAsY1yIDU=; b=TtnrXRvDf5iKOq9md3gYBJgkd+ 50j/o9jDkhCu8YIyPGLZw7E8WigRPTOJ4G4Nrz0UCRzmgneGbOKLcrTJ04VfhTVa/2PLU/ijkI1G2 ww+ltK+lO8BBfeUpQt/gsDb6UcypvcsIvwstVAEF58qAa4Lj+wffl5isvD+HbVFRsOlEBvtkPkqbp jS685hwqLYFwrghjaoXJwzVL5nVp3gsf9/Z/lR2OsKS74T3OIFF1Wik5emFkVsK7JMbVJcnTliM+H gqLdWV+Kfb24IjgwIP54HbSboM9aPHHavSSpL2ruScZxIHMi79z0E7fJ1Kmp7UKA3p8qcOMCNcg3Q kAi/Moww==; Message-ID: <9cb0756c-466e-4e1c-8eb1-3a98bbfa0cac@luigi311.com> Date: Thu, 28 Mar 2024 15:11:28 -0600 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 22/23] drivers: media: i2c: imx258: Add support for powerdown gpio Content-Language: en-US To: Rob Herring Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ondrej Jirman References: <20240327231710.53188-1-git@luigi311.com> <20240327231710.53188-23-git@luigi311.com> <20240328204841.GA318468-robh@kernel.org> From: Luigi311 In-Reply-To: <20240328204841.GA318468-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authenticated-Id: git@luigi311.com On 3/28/24 14:48, Rob Herring wrote: > On Wed, Mar 27, 2024 at 05:17:08PM -0600, git@luigi311.com wrote: >> From: Luigi311 >> >> On some boards powerdown signal needs to be deasserted for this >> sensor to be enabled. >> >> Signed-off-by: Ondrej Jirman >> --- >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ++++ > > Bindings should be a separate patch. > Ok ill create separate patch for adding in the binding and then a follow up patch with the other half that actually adds it to the driver >> drivers/media/i2c/imx258.c | 13 +++++++++++++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index c7856de15ba3..0414085bf22f 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -35,6 +35,10 @@ properties: >> reg: >> maxItems: 1 >> >> + powerdown-gpios: >> + description: |- > > Don't need '|-' if no formatting> Done >> + Reference to the GPIO connected to the PWDN pin, if any. >> + >> reset-gpios: >> description: |- >> Reference to the GPIO connected to the XCLR pin, if any.