From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA4D2FB0AF for ; Mon, 27 Oct 2025 09:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761558666; cv=none; b=OXI1n6UlYf16LWTMlTNQB/rKTzvdPhA/xf+MJWDC/2hARRBhUNu6HP/uYvpUjvlB+klczXCItCyR579qqyLjcxfujbpUBgQyTxatV53dzrwkqMnkLpZXXLz9VkKd3N5VXVQGfNThu4mXY+prcQs8zF4LHpmtOhZ77gF/0MaFWC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761558666; c=relaxed/simple; bh=9KuN2Xm5jw7TgRZXPSk3P9TAJLH7k2ZyHKs1la0a+4k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AVgqyKDC4Ol0iRSiWtIodKtQdptVNRLpdJCM1U56lKCsl60NxsF6AeYV+dHrfYuRoFiI0NcrZBor2URPPBwYETHP4iou0x8MhEYXJjIjp4111ncRJ4NylQaSxOp2B5E+dza6HhE1mfYhfnlj0imL6+Z8JIRDo94Vtvq5qZOLIWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gq2FUEh8; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gq2FUEh8" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-63e076e24f2so345737a12.3 for ; Mon, 27 Oct 2025 02:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761558661; x=1762163461; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mw12YdzTi9NB3y1kJkoK+Kxt9YSNjct8ry46vaendzw=; b=gq2FUEh8pk9YFVKKfMoO/t1SH8RCUXn8cQqkSWXk+jTefOU4hYHYtV8WGUMFKxKWw9 SOPj0di7mY61Ofsn/tmUsh1enIgbYO1R2zrusUiC4FzHGru6YcuK8Wn9HODX3PRRHSXW cepdt5lX7Lvz4ndmJE5i2oDeaV1hClRVZfvFHPewXQkT11bKDtQjqVcQ26k/HO8tp38u sRt+fDDDSsj2AMybPi73A05OUlse4PJdvDxUGjiwlFnbIMtOy7l0HqJxl2otmcyQ0wco tTCRtFF/oYovAD7hnIHqpRJu3e7x9ppi9ozfsewmJ6hjKxQzTZRZl8sn114h8177K3ur v6dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761558661; x=1762163461; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mw12YdzTi9NB3y1kJkoK+Kxt9YSNjct8ry46vaendzw=; b=hOhBcJOg42Nh4tWCFsvm53mPmLq6ruxvhB6NeRld5wzMjR0n4mGF171Sdmzf5VaZ68 YKScSrPUxSxqc7Gt89+e2i95hcYepo+SnLVVEj1BEPrqVoqcD1lTSigeZVha4gYdH2j+ wz520k6Q/rsjLe5z2iZaj/HvNym8Ed1qRPli9ZxLIPII4BusRvacYLhn1QvqpvWu0ZtR wh8jtEzD0aiPy5i1sODldJYxG2+/hUiivJS6XXuhx4glulKOG2Uf+5hQcFBrrByZl0NL 0Qngl+Ko66+j+Lk5b8oNdof/jOnEkgpYhfQoCp428K/PElO8dVJZWbVpjX8wllVeFtka 7OMQ== X-Forwarded-Encrypted: i=1; AJvYcCXDEyYTjKVRRfJY/Uqm0mXJl0am8VJEJL5XDv99B2LUGMz9XvO6BEcGlTISQnly9VzW9Ao=@lists.linux.dev X-Gm-Message-State: AOJu0YyIKT9lt/IfsLzibH8UsgUMazmmXSZ5mWbi2omMXbaaiMDote1O iaRwvYkG8zpjbUC9ighfI3ka9If6Iq14FDINBFlOp4kWUicofGd7dW/I X-Gm-Gg: ASbGncsqEoI+vTGzkdPEjebzN5EtVq4rHmWIo8obYN9uCJc37HzkFiwKf0KWkJxdetD QL8KxAsvkzRxHrfFK0Fn3PnXPooKxxamDd702Co5fv2jS3nILMQfS1krFiVWPokN3QeaK/cjsAO ZnzvM4aTB+D2RSARZ97IK7XPIgtMYWUjgA9dM+yE7hZHk+L238r1VA9TFKRfIoiBJjraqU5NpFa BtcET6KE/BQ7fsX5zCTI6SPIv5oQEjsxnaDDd8bBhJOyPDsh02MYa1So2Ez0vege9askB+rO80h 2vEmbxKAhcZ13WpyEx0Tsfz3mNyBkQzLmjQ+nnwBpUnWGeO+2xanUJnPHJz3/wyKnfMQdIi8A53 sk6MnzkpDZkUdZmHbwTRM/CtK+M46W5mHsc83xMiZvJOwis2NON3UTSmNvs7W4KEQmKWqDRrNWX jSU3viA6CxIOr5TL2UKwCltgUOx9pxmg== X-Google-Smtp-Source: AGHT+IERBzNr1pRW9aQQMHx51xdoW3UzXmbId6nlUYrZzGZ0Z6AgDbAWku/q0c+3JyA6dFoSGcQW5w== X-Received: by 2002:a05:6402:2787:b0:63b:d7f0:d940 with SMTP id 4fb4d7f45d1cf-63c1f6300fbmr32209099a12.1.1761558661210; Mon, 27 Oct 2025 02:51:01 -0700 (PDT) Received: from [10.25.208.2] ([128.77.115.157]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63e7ef82907sm5888719a12.12.2025.10.27.02.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 02:51:00 -0700 (PDT) Message-ID: <9e5f5166-75c3-4c7c-804a-8cb24c67f416@gmail.com> Date: Mon, 27 Oct 2025 02:50:58 -0700 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/8] clk: imx: add driver for imx8ulp's sim lpav To: Peng Fan Cc: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team References: <20251017112025.11997-1-laurentiumihalcea111@gmail.com> <20251017112025.11997-4-laurentiumihalcea111@gmail.com> <20251022140315.GA11174@nxa18884-linux.ap.freescale.net> Content-Language: en-US From: Laurentiu Mihalcea In-Reply-To: <20251022140315.GA11174@nxa18884-linux.ap.freescale.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/22/2025 7:03 AM, Peng Fan wrote: > Hi Laurentiu, > > On Fri, Oct 17, 2025 at 04:20:20AM -0700, Laurentiu Mihalcea wrote: >> From: Laurentiu Mihalcea >> >> The i.MX8ULP System Integration Module (SIM) LPAV module is a block >> control module found inside the LPAV subsystem, which offers some clock >> gating options and reset line assertion/de-assertion capabilities. >> >> Therefore, the clock gate management is supported by registering the >> module's driver as a clock provider, while the reset capabilities are >> managed via the auxiliary device API to allow the DT node to act as a >> reset and clock provider. >> >> Signed-off-by: Laurentiu Mihalcea >> --- > .... >> +struct clk_imx8ulp_sim_lpav_data { >> + void __iomem *base; >> + struct regmap *regmap; >> + spinlock_t lock; /* shared by MUX, clock gate and reset */ >> + unsigned long flags; /* for spinlock usage */ > This does not need to be here, put it as function local variable should > be fine. > >> + struct clk_hw_onecell_data clk_data; /* keep last */ >> +}; >> + >> +struct clk_imx8ulp_sim_lpav_gate { >> + const char *name; >> + int id; >> + const struct clk_parent_data parent; >> + u8 bit; >> +}; >> + >> +static struct clk_imx8ulp_sim_lpav_gate gates[] = { >> + IMX8ULP_HIFI_CLK_GATE("hifi_core", CORE, "hifi_core", 17), >> + IMX8ULP_HIFI_CLK_GATE("hifi_pbclk", PBCLK, "lpav_bus", 18), >> + IMX8ULP_HIFI_CLK_GATE("hifi_plat", PLAT, "hifi_plat", 19) > For the parent name, my understanding is they should be the one > from clk-imx8ulp.c, but I not find them, or may I miss something? we want to use parent names local to the SIM LPAV provider (i.e. names specified via clock-names) instead of the global ones. See definition of "struct clk_parent_data". while we're at it, maybe it would be a good idea to drop the ".name = pname" assignment bit as that won't work anyways since we're relying on local parent names? > >> +}; >> + >> +#ifdef CONFIG_RESET_CONTROLLER >> +static void clk_imx8ulp_sim_lpav_aux_reset_release(struct device *dev) >> +{ >> + struct auxiliary_device *adev = to_auxiliary_dev(dev); >> + >> + kfree(adev); >> +} >> + >> +static void clk_imx8ulp_sim_lpav_unregister_aux_reset(void *data) >> +{ >> + struct auxiliary_device *adev = data; >> + >> + auxiliary_device_delete(adev); >> + auxiliary_device_uninit(adev); >> +} >> + >> +static int clk_imx8ulp_sim_lpav_register_aux_reset(struct platform_device *pdev) >> +{ >> + struct auxiliary_device *adev __free(kfree) = NULL; >> + int ret; >> + >> + adev = kzalloc(sizeof(*adev), GFP_KERNEL); >> + if (!adev) >> + return -ENOMEM; >> + >> + adev->name = "reset"; >> + adev->dev.parent = &pdev->dev; >> + adev->dev.release = clk_imx8ulp_sim_lpav_aux_reset_release; >> + >> + ret = auxiliary_device_init(adev); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to initialize aux dev\n"); >> + return ret; >> + } >> + >> + ret = auxiliary_device_add(adev); >> + if (ret) { >> + auxiliary_device_uninit(adev); >> + dev_err(&pdev->dev, "failed to add aux dev\n"); >> + return ret; >> + } >> + >> + return devm_add_action_or_reset(&pdev->dev, >> + clk_imx8ulp_sim_lpav_unregister_aux_reset, >> + no_free_ptr(adev)); > clk_imx8ulp_sim_lpav_unregister_aux_reset() clean up the resources, if > moving this before auxiliary_device_add(), then no need > auxiliary_device_uninit() when add fails? the whole chunk guarded by the #ifdef CONFIG_RESET_CONTROLLER should go away anyways once I switch to devres as Frank suggested > >> +} > Regards > Peng