From: Krzysztof Kozlowski <krzk@kernel.org>
To: Umang Jain <umang.jain@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"Paul J. Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Martina Krasteva <martinax.krasteva@intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 2/2] media: imx335: Fix reset-gpio handling
Date: Wed, 31 Jul 2024 09:29:30 +0200 [thread overview]
Message-ID: <9e6c24c2-bdf3-4c44-8447-ca61e0e3e06b@kernel.org> (raw)
In-Reply-To: <20240731-imx335-gpio-v3-2-443bfa6ce864@ideasonboard.com>
On 31/07/2024 09:02, Umang Jain wrote:
> Rectify the logical value of reset-gpio so that it is set to
> 0 (disabled) during power-on and to 1 (enabled) during power-off.
>
> Meanwhile at it, set the reset-gpio to GPIO_OUT_HIGH at initialization
> time to make sure it starts off in reset. Also drop the "Set XCLR"
> comment which is not-so-informative.
>
None of our conclusions are explained, which I requested.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-07-31 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 7:02 [PATCH v3 0/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-31 7:02 ` [PATCH v3 1/2] dt-bindings: media: imx335: Add reset-gpios to the DT example Umang Jain
2024-07-31 7:32 ` Krzysztof Kozlowski
2024-07-31 7:02 ` [PATCH v3 2/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-31 7:29 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e6c24c2-bdf3-4c44-8447-ca61e0e3e06b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martinax.krasteva@intel.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox