Re: [PATCH net-next 2/4] net: fec: use new iterator phy_for_each

[Gerhard Engleder <gerhard@engleder-embedded.com>]

On 17.10.25 22:41, Heiner Kallweit wrote:
> Use new iterator phy_for_each() to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>   drivers/net/ethernet/freescale/fec_main.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 1edcfaee6..d7c39ef2d 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2552,7 +2552,6 @@ static int fec_enet_mii_init(struct platform_device *pdev)
>   	int err = -ENXIO;
>   	u32 mii_speed, holdtime;
>   	u32 bus_freq;
> -	int addr;
>   
>   	/*
>   	 * The i.MX28 dual fec interfaces are not equal.
> @@ -2667,11 +2666,8 @@ static int fec_enet_mii_init(struct platform_device *pdev)
>   	of_node_put(node);
>   
>   	/* find all the PHY devices on the bus and set mac_managed_pm to true */
> -	for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> -		phydev = mdiobus_get_phy(fep->mii_bus, addr);
> -		if (phydev)
> -			phydev->mac_managed_pm = true;
> -	}
> +	phy_for_each(fep->mii_bus, phydev)
> +		phydev->mac_managed_pm = true;
>   
>   	mii_cnt++;
>   

Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>