From: Erik Schumacher <erik.schumacher@iris-sensing.com>
To: "Frank.li@nxp.com" <Frank.li@nxp.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ukleinek@kernel.org" <ukleinek@kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH] pwm: imx-tpm: Use correct MODULO value for EPWM mode
Date: Thu, 24 Oct 2024 06:11:04 +0000 [thread overview]
Message-ID: <9f65248cd396524ebe977ea48d87284e14c399c9.camel@iris-sensing.com> (raw)
In-Reply-To: <ZxkXwTXwfkC9W5C3@lizhi-Precision-Tower-5810>
Am Mittwoch, dem 23.10.2024 um 11:35 -0400 schrieb Frank Li:
> On Wed, Oct 23, 2024 at 12:33:53PM +0000, Erik Schumacher wrote:
> > The modulo register defines the period of the edge-aligned PWM mode
> > (which is the only mode implemented). The reference manual states:
> > "The EPWM period is determined by (MOD + 0001h) ..." So the value that
> > is written to the MOD register must therefore be one less than the
> > calculated period length.
> > A correct MODULO value is particularly relevant if the PWM has to output
> > a high frequency due to a low period value.
> >
> This is bug fix, add fix tag and cc stable
>
> Frank
That's true. I will do a v2 with these tags.
Thank you!
Erik
>
prev parent reply other threads:[~2024-10-24 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 12:33 [PATCH] pwm: imx-tpm: Use correct MODULO value for EPWM mode Erik Schumacher
2024-10-23 15:35 ` Frank Li
2024-10-24 6:11 ` Erik Schumacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f65248cd396524ebe977ea48d87284e14c399c9.camel@iris-sensing.com \
--to=erik.schumacher@iris-sensing.com \
--cc=Frank.li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox