From: Andrew Lunn <andrew@lunn.ch>
To: Wei Fang <wei.fang@nxp.com>
Cc: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"eric@nelint.com" <eric@nelint.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: phylink: add missing supported link modes for the fixed-link
Date: Mon, 17 Nov 2025 14:22:57 +0100 [thread overview]
Message-ID: <9f9df3b3-ea08-43d7-8075-68b4fe19e6a0@lunn.ch> (raw)
In-Reply-To: <PAXPR04MB8510785AF26E765088D1631788C9A@PAXPR04MB8510.eurprd04.prod.outlook.com>
On Mon, Nov 17, 2025 at 03:23:05AM +0000, Wei Fang wrote:
> > This also seems like two fixes: a regression for the AUTONEG bit, and
> > allowing pause to be set. So maybe this should be two patches?
>
> As Russell explained in the thread, one patch is enough.
>
> >
> > I'm also surprised TCP is collapsing. This is not an unusual setup,
> > e.g. a home wireless network feeding a cable modem. A high speed link
> > feeding a lower speed link. What RTT is there when TCP gets into
>
> The below result is the RTT when doing the iperf TCtestP
> root@imx943evk:~# ./tcping -I swp2 10.193.102.224 5201
> TCPinging 10.193.102.224 on port 5201
> Reply from 10.193.102.224 (10.193.102.224) on port 5201 TCP_conn=2 time=1.004 ms
> Reply from 10.193.102.224 (10.193.102.224) on port 5201 TCP_conn=3 time=0.958 ms
With 1ms ping times, you don't have buffer bloat problems, so that is
not the issue.
I still think you need to look at this some more. Both Russells
comments about it potentially blocking traffic for other ports, and
why TCP is doing so bad, maybe gets some traffic dumps and ask the TCP
experts.
Andrew
next prev parent reply other threads:[~2025-11-17 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 2:38 [PATCH v2] net: phylink: add missing supported link modes for the fixed-link Wei Fang
2025-11-16 16:10 ` Andrew Lunn
2025-11-16 17:33 ` Russell King (Oracle)
2025-11-17 3:23 ` Wei Fang
2025-11-17 13:22 ` Andrew Lunn [this message]
2025-11-17 13:54 ` Wei Fang
2025-11-17 15:01 ` Andrew Lunn
2025-11-18 6:20 ` Wei Fang
2025-11-17 15:17 ` Russell King (Oracle)
2025-11-17 15:24 ` Maxime Chevallier
2025-11-18 2:05 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f9df3b3-ea08-43d7-8075-68b4fe19e6a0@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric@nelint.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox