From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53E933093CE for ; Tue, 2 Sep 2025 13:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756819955; cv=none; b=hSx/mq8oQc8P5//QN6XbYJoU5RoxXX3iz53TCbYJgxggaWbI19oN16R2BMVlNNxUTkTXkCabjTIE7tinNnWuseUG1PjT+jrSXFv5f3vWVHHVkrzq2C1ZLyuKxFkyNZ6c34E0a2Cae5Rhh7wTuVP4l6KRs7y3dvd/s5f309Sosuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756819955; c=relaxed/simple; bh=jQHix6PgeTZogNqwgwBs7BQIhf8j8t/QOXmjjj2gpJg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=CJDd30y8cozbMUUWZIYauBArlkKjo8lH75tghzfD218nBUDnk7ASIcaCpj4D8yreh9j6IguddZnQWSWHp9hvIElz5XYTjbufd4XYgikAh8zLtTJwFo+LFP/ZoSaWl5aEx2L+rgicRHUk0eg4A62uUHXFZi7y2gNEfU+swE3XiIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wULY/XOf; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wULY/XOf" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-55f7039a9fdso3251272e87.1 for ; Tue, 02 Sep 2025 06:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756819951; x=1757424751; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lnoH1+ZsxBYCzbeJtuEiwBsgC/lAs0DmEqE9uy46sWE=; b=wULY/XOfqFO+vDOO8aXUzTvCQoXLhCgfowsKlCGkhZ0dPUa6b5iGaHRWHSip2n7pbN ZHncOsZoE9TUEczRsjd0lQ/S/6kD5R4o3Hvct3RVO1h0NEoi7uui/yEArXSlSn+9eRJq ZPhnO6eF63EU5+doBz7swP512FFzYfpTmjQ7n1AEdUQAWUvjHv61rOMmvgqmCkEReund TJ1qiVxXrXdsvptSgKwXq+3U6KR3ufMwfMStIreyolnNOK8DLazHI1fmB+DJ1KG1X/AT Q/eY5aPCyb4gDIk5oNI4QvR7xex7l4LCv90wpty9MppBR7TZMATdhtLdNF4LKFk/8/Pw 9oXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756819951; x=1757424751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lnoH1+ZsxBYCzbeJtuEiwBsgC/lAs0DmEqE9uy46sWE=; b=PkDfm0i5hVgW6AZbFTh+sit61fHyLYpSM1Jr1B4AsweKCCM95qQa6qoFtdKkJfb/y8 /NhHgUgWqIRqC1uDULqicRWc/NtMgZFr+zL0Yon4lFkzf/sjG5NDmEjeYjzmvJ+ckHRa 7KzsvJGjadvxOBlRVqhVp0o7LfpPd9ihf/xbvWYVE3dxSKZWZhKjbi9OQsfVBLZLQ4Vf Bs/fvPhVKX9ku0PTgX6Tk+cAt+3tRaD0U5s2n3KrDptymrhE4Vwf5JkSxB5eh3i5++36 0stafZks1OXNrjYyygpkszp2IGGh8OtrY2bjWF7CrtcpOlwMHywU+uOsjvcb0OxAyrGD QYQQ== X-Forwarded-Encrypted: i=1; AJvYcCWr03xXWMJoFlNdJOfnzCNky8KTmeBpJyxYLDIxUhAXdsriBETFTHXyllhmLCX255wHQcI=@lists.linux.dev X-Gm-Message-State: AOJu0Yx+LCtsX13lVfi5pvTw9owPV2wqL70bNwIXhks8IqvQgZdNExYI hPmYz6/atvF1xvS4ldSxQgp/i6DBNrUXqJfVOBK126eaLw9ETBUKHWxE95jm5RCciLnL9MoonMQ WsPORQIpqMts0BvmqYtXWoYmIvJPcZ09pxzpH1jIaEg== X-Gm-Gg: ASbGncstFw01Ar9JX1Q0ZjimL8aWjhcSz2Xz1sreBsjw6nYqNWyP0qO0p+AaCc7th2i ZFZlKMNR8ehSKmVc4MSOY/9iQbpgwyJzBad0FKE0Ws4CS2dPucyi3TtCK+qs4jRv26+Wxs1u1uv wcxfPrlxyYqMggEcPsw5mQxgtClk4y1yAdePMRl5J05vev+tlsn8e1hWODNAf7tBhp6aosS2yho V7+mTMqJUtKhY6YYgkM/zvB/4l1gaHEVRJUaCs= X-Google-Smtp-Source: AGHT+IHbC8qI4AC5+0YZNljCnPe19ZYxRaps+B2CcXld1o2mGtDbXzoveQoI0IeEbDNxVlYlEUG/+tn7nGWqsyLzmeE= X-Received: by 2002:a05:6512:3ca9:b0:55f:55ad:2263 with SMTP id 2adb3069b0e04-55f708b6c5bmr4286185e87.16.1756819949961; Tue, 02 Sep 2025 06:32:29 -0700 (PDT) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250902-pinctrl-gpio-pinfuncs-v7-0-bb091daedc52@linaro.org> <20250902-pinctrl-gpio-pinfuncs-v7-12-bb091daedc52@linaro.org> In-Reply-To: From: Bartosz Golaszewski Date: Tue, 2 Sep 2025 15:32:18 +0200 X-Gm-Features: Ac12FXySKFnql5rdsxfRBFF-2EejY2a696V_6zV_jaWq_9WtZl4uQNoHEj4w7YY Message-ID: Subject: Re: [PATCH v7 12/16] pinctrl: qcom: use generic pin function helpers To: Andy Shevchenko Cc: Linus Walleij , Bjorn Andersson , Konrad Dybcio , Alexey Klimov , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Paul Cercueil , Kees Cook , Andy Shevchenko , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , NXP S32 Linux Team , Sascha Hauer , Tony Lindgren , Haojian Zhuang , Geert Uytterhoeven , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Neil Armstrong , Mark Brown , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski , Konrad Dybcio Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 2, 2025 at 3:15=E2=80=AFPM Andy Shevchenko wrote: > > On Tue, Sep 02, 2025 at 01:59:21PM +0200, Bartosz Golaszewski wrote: > > > > With the pinmux core no longer duplicating memory used to store the > > struct pinfunction objects in .rodata, we can now use the existing > > infrastructure for storing and looking up pin functions in qualcomm > > drivers. Remove hand-crafted callbacks. > > ... > > > + for (i =3D 0; i < soc_data->nfunctions; i++) { > > + func =3D &soc_data->functions[i]; > > + > > + ret =3D pinmux_generic_add_pinfunction(pctrl->pctrl, func= , NULL); > > + if (ret < 0) > > Why not simply > > if (ret) > > > + return ret; > > + } Because it returns a possibly positive selector number. Bart