From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F17243A0B2E for ; Wed, 7 Jan 2026 17:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767805403; cv=none; b=FWfuL62WMSLmY4Pvk4zoWA/B+5sjY8HfL/c5soexIngYIea4b4FnkT1JjaDPHRmUkeTWdX7+CpvvSs6V7pNz/zCihpR+GyM2oN0R4TN1Vea7GjE7bF4I/ftgWkthjExpHVRCMsFv2HLaYxKXjtCM3VrsijPOCbR2O7XgKSfIBzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767805403; c=relaxed/simple; bh=oL8OL55SBSSa/kcNiHr9aDvahiZID2IDb22M/LLl2lw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=J4IIdxu4dEULfrwVA1Vs4+8jUYLewEUqi8ny43P7Vj+TOeLQTa6nVJaRL0HAyqXmfpUnNnnRB1brfV7MmaDoNLOyoBBFvptBSrcOnnIPZxZlJIV9kWJLKCpxUbFBZWRhKhaRkAiDDTKB39anIpzkxtaSjo70v419XMZl8hZk9cY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=qjl+IH9e; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="qjl+IH9e" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id BC30FC1EC96; Wed, 7 Jan 2026 17:02:52 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A6BA7606F8; Wed, 7 Jan 2026 17:03:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E9A49103C821A; Wed, 7 Jan 2026 18:03:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767805397; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=vT259SsZbBCgS5jej5uTjBYNLE5xMiwzYalV9DvjFlw=; b=qjl+IH9e6WT/WJbluQMom7WhOSZz91qsguJk+YcCF1ezNfyjR88kSE3TKuk68Dg37xmHw6 XCEK9Mppq0OQq3vc09h0WDsUQxgQoZKm+M/+U+3MgdY0Eb/MK9G6UG+ZlB8NXiAEBbZ6Pi xP9Oxci+bX3nmJSR9oU2MukZpebnHYoGLphjaIxE7AW3mpS/83hzxfcjIax6cip9cRD7lZ Uex/OGHArOy4i/tiS6i8OdbUklSoD4vZR2GIC0hRgcGA3SbizduiTm0dV2HMFCrUGQiGZt cUleZVAvrJ72aqzu/SfKPKbcZV9e9srbSuH73i8GFot6Kr2H131NFf/nJYQ26g== Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 07 Jan 2026 18:03:05 +0100 Message-Id: Subject: Re: [PATCH 3/6] drm/imx/dw-hdmi: convert to of_drm_find_and_get_bridge() Cc: "Hui Pu" , "Thomas Petazzoni" , , , , , , , , To: "Philipp Zabel" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Chun-Kuang Hu" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-3-v1-0-ef48a517828e@bootlin.com> <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-3-v1-3-ef48a517828e@bootlin.com> <3e87a26d067de694273daaf011a50f1a2e7718f1.camel@pengutronix.de> In-Reply-To: <3e87a26d067de694273daaf011a50f1a2e7718f1.camel@pengutronix.de> X-Last-TLS-Session-Version: TLSv1.3 Hello Philipp, On Wed Jan 7, 2026 at 5:34 PM CET, Philipp Zabel wrote: > On Mi, 2026-01-07 at 17:22 +0100, Luca Ceresoli wrote: >> of_drm_find_bridge() is deprecated. Move to its replacement >> of_drm_find_and_get_bridge() which gets a bridge reference, and ensure i= t >> is put when done. >> >> Signed-off-by: Luca Ceresoli >> --- >> drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c b/drivers/gpu/drm/i= mx/ipuv3/dw_hdmi-imx.c >> index 07e5f96202d4..95f629d97bce 100644 >> --- a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c >> +++ b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c >> @@ -241,7 +241,7 @@ static int dw_hdmi_imx_probe(struct platform_device = *pdev) >> if (IS_ERR(hdmi->hdmi)) >> return PTR_ERR(hdmi->hdmi); >> >> - hdmi->bridge =3D of_drm_find_bridge(np); >> + hdmi->bridge =3D of_drm_find_and_get_bridge(np); >> if (!hdmi->bridge) { >> dev_err(hdmi->dev, "Unable to find bridge\n"); >> dw_hdmi_remove(hdmi->hdmi); > > The component_add() error path below this is missing a > drm_bridge_put(). Right! Thanks for reviewing, fix queued for v2. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com