From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F72396D18 for ; Tue, 3 Feb 2026 10:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770113527; cv=none; b=W6FOuqe68SzBHsWE+wnVbu4glhGcZY3Sqdn5i2Elg1mySeS+yf7z3RrHz++O4ml8/pM+/Ia+G3VAZHIW53XID5B1qaFqsTJYTOc+aH2XsaI/mwnqdnoVBDZgaxWU9Okhw0JC4WlTDCUm7u6Nf7HwNSciEchoPYICshBvOiI2x9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770113527; c=relaxed/simple; bh=kaxurYH+pSZiT55rBegAYaKI+3y+ZBTAe+5LlaGS5Qc=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=GdGJxIckw0QZriZ1PPTYS81qgNUTRVdqAbizKTrQAPkLXfQxDu+pH1NILIuPmkWRkeBcM1ShGEzShzyCqLfh8TDh00eOzzsWMHnfhZsoxibGt5J+BQmWN7rwonyWIUHzVO38Nh3/jJOgU4TVeRYq23M7q64/LKfErGz+w8f5K3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=soDBBG2b; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="soDBBG2b" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 381854E423E2; Tue, 3 Feb 2026 10:12:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0765E60728; Tue, 3 Feb 2026 10:12:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7C634119A8888; Tue, 3 Feb 2026 11:11:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770113521; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=kaxurYH+pSZiT55rBegAYaKI+3y+ZBTAe+5LlaGS5Qc=; b=soDBBG2bgMR8f2LbgIrwrYZOZzYJcpbUWVYRItBu2O1PQqna30rioLkNHxmoqkhNvMoty+ if15F8cH7NZWu28bObiIMmjSXkf/cYBNUhfuBPoO76QtFqb1UQUMLfLDYevJwW/p1Kl7Lu +I3G0dxG+J6RhTJVOFeRfdIz+h/B9NG/cjr+thEijncqEHuyHKZUwYUANoWLQg294fKT8y TDLWlGQamhmukciHP6cONfNmeBtpmJaloA59+nUyzJxHvdVhD6JznC5KaF3u+dPqNNeDk7 seesqobwi6ZjgtZhhsyn/aWw21kF+XuG5pXLFvYh5MYavI/tXRZlfn3DYpa2Fg== Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 03 Feb 2026 11:11:50 +0100 Message-Id: Subject: Re: [PATCH v8 05/18] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , To: "Damon Ding" , , , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251217093321.3108939-1-damon.ding@rock-chips.com> <20251217093321.3108939-6-damon.ding@rock-chips.com> <7256ecf9-b10b-428c-a1a6-e35e80a686ed@rock-chips.com> <9e1da672-a52d-4ec3-a20a-fe6f8ca15496@rock-chips.com> In-Reply-To: <9e1da672-a52d-4ec3-a20a-fe6f8ca15496@rock-chips.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Damon, On Tue Feb 3, 2026 at 2:31 AM CET, Damon Ding wrote: > Hi, > > On 2/2/2026 10:54 AM, Damon Ding wrote: >> Hi Luca, >> >> On 1/31/2026 8:33 PM, Luca Ceresoli wrote: >>> Hello Damon, Dmitry, >>> >>> On Wed Dec 17, 2025 at 10:33 AM CET, Damon Ding wrote: >>>> As suggested by Dmitry, the DRM legacy bridge driver can be pulled >>>> out of imx/ subdir for multi-platform use. The driver is also renamed >>>> to make it more generic and suitable for platforms other than i.MX. >>>> >>>> Signed-off-by: Damon Ding >>>> Suggested-by: Dmitry Baryshkov >>>> Tested-by: Marek Szyprowski >>>> >>>> --- >>>> >>>> Changes in v7: >>>> - Rename legacy-bridge to of-display-mode-bridge. >>>> - Remove unnecessary API drm_bridge_is_legacy(). >>> >>> ... >>> >>>> --- a/drivers/gpu/drm/bridge/Kconfig >>>> +++ b/drivers/gpu/drm/bridge/Kconfig >>>> @@ -244,6 +244,16 @@ config DRM_NXP_PTN3460 >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 NXP PTN3460 eDP-LVDS bridge= chip driver. >>>> >>>> +config DRM_OF_DISPLAY_MODE_BRIDGE >>>> +=C2=A0=C2=A0=C2=A0 tristate >>>> +=C2=A0=C2=A0=C2=A0 depends on DRM_BRIDGE && OF >>>> +=C2=A0=C2=A0=C2=A0 help >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 This is a DRM bridge implementation th= at uses >>>> of_get_drm_display_mode >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to acquire display mode. >>>> + >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Newer designs should not use this brid= ge and should use proper >>>> panel >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 driver instead. >>> >>> "Newer designs should not use this bridge", but in patch 8 you are >>> introducing a new use ot devm_drm_of_display_mode_bridge(). Shouldn't y= ou >>> instead "use proper panel driver instead" in patch 8? >>> >>> Can you point to the conversation where the converstaion where Dmitry >>> suggested this change? Maybe it already contains the answer to my >>> qustion. Also adding a link to that conversation in the commit message >>> woule be useful. >>> >> >> First of all, thanks for your reviews on this patch series. >> >> link: https://lore.kernel.org/all/ >> xwenycscalzdlpuxytorbiyvej3k7pv3lhxwtadilxq65ipwsv@x5rxm53w5e22/ >> >> I think it may be a misleading issue caused by directly copying the >> previous Kconfig description. Now that the new >> devm_drm_of_display_mode_bridge() helper has been added, drivers using >> the panel-bridge framework can rely on it to maintain compatibility with >> legacy display mode parsing. Ah, I think I got the point: the mode description in device tree is legacy, but the driver itself is not legacy and will be current until we need to support legacy device tree. Correct? If that's correct, this patch looks OK to me with a new Kconfig help text. >> It would be better to update the comment as follows: >> >> This is a DRM bridge implementation that uses of_get_drm_display_mode to >> acquire display mode. >> >> It exists for compatibility with legacy display mode parsing, in order >> to conform to the panel-bridge framework. >> > > Dmitry, what's you take on this? Dmitry's opinion would be much more relevant than mine. I don't know much myself about this driver. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com