From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389C23D76 for ; Thu, 11 Jun 2026 08:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781168072; cv=none; b=EzSiS1g9UcbqzTq0jUG7OdTX1AIRtlLcrs7fOcmxNVBWKXGlM6a+2GbLmrPzC3e0+xlUdiHh8zDs9pcMfoEdbqSnaByvIGFUb1WWKfcJiPhEj5idIUdbrTAuNAFdXEEIV7GYDUzJGT3OW92pDBP70QEPKHG2pphS9Wj3p4o+z9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781168072; c=relaxed/simple; bh=MQc2+40RixqWU8oeluKeT0f9yl4yXhif0AmrBhleuus=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=dMK4FD6C/RmHqbIA1UbXhEl2J7oAgfWNPpbhyGc7bRoJWiBUTOn9zZyFlt1pDD4YNi1P+t35J6V3sMTYRX73L2lwtm5re7/eI+2DSCdmQ6Z+27+XlHlgV7mvTVGlrgrTby++MnFZP5vhWWDaxdKFQXmhyTn6EjvbmazGywCGnQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lNi/XdDn; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lNi/XdDn" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 7C6651A3840; Thu, 11 Jun 2026 08:54:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4A6925FF03; Thu, 11 Jun 2026 08:54:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E3564106B9477; Thu, 11 Jun 2026 10:54:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1781168064; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=59GDvGkxf3cHZtAQ2AAidgdUgpnfTEwmRZmFMmIXUBM=; b=lNi/XdDnbrP4ELsevq7Ct9EK0bIg9nouRauRmtlYYjVjULpigORAvDxGGIx9sWsnTega8d CZf4OQFho7OL2/4YdDVIYm/K8CB3CIBJD/j/2vTX0VBvuqJLmv0oEVR7zh19M4b/ge3LSQ I2oE2bQyA4n+xqhkktJFocnIJl8ZfolR5BmmP7DSeA2lJeyE8Qqt/chMWuJUBpu7ckat5d 6LqN5ctT1Gh45eEQJGF4vmL/O+6834D7Rj2Y0Jmk1MyxoA0QrBvNkgluqK0DH4kKQOD70o 5rtwoDTKSSzav4WRygvNcut1xMaDp8mIAiG2zPw/LijjDBAqo3ubc/YA4my+IQ== Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Jun 2026 10:54:14 +0200 Message-Id: Subject: Re: [PATCH 19/37] drm/bridge: samsung-dsim: move drm_bridge_add() call to probe Cc: "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Inki Dae" , "Jagan Teki" , "Marek Szyprowski" , "Marek Vasut" , "Stefan Agner" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , To: "Maxime Ripard" , "Luca Ceresoli" From: "Luca Ceresoli" X-Mailer: aerc 0.21.0 References: <20260519-drm-bridge-hotplug-v1-0-45e2bdb3dfb4@bootlin.com> <20260519-drm-bridge-hotplug-v1-19-45e2bdb3dfb4@bootlin.com> <20260608-mellow-weasel-of-politeness-a56172@houat> In-Reply-To: <20260608-mellow-weasel-of-politeness-a56172@houat> X-Last-TLS-Session-Version: TLSv1.3 On Mon Jun 8, 2026 at 1:58 PM CEST, Maxime Ripard wrote: > On Tue, May 19, 2026 at 12:37:36PM +0200, Luca Ceresoli wrote: >> This bridge driver calls drm_bridge_add() in the DSI host .attach callba= ck >> instead of in the probe function. >> >> This works for current use cases but is problematic for supporting hotpl= ug >> of DRM bridges. The problematic case is when this DSI host is always >> present while its DSI device is hot-pluggable. In such case with the >> current code the DRM card will not be populated until after the DSI devi= ce >> attaches to the host, which could happen a very long time after booting,= or >> even not happen at all. >> >> The reason is that the previous pipeline component (the encoder in this >> case) when probing cannot find the samsung-dsim bridge. What happens is: >> >> [1 and 2 can happen in any order, same result] >> 1) samsung-dsim probes (does not drm_bridge_add() itself) >> 2) The lcdif starts probing multiple times, but >> lcdif_probe >> -> lcdif_load >> -> lcdif_attach_bridge >> -> devm_drm_of_get_bridge() returns -EPROBE_DEFER because >> the samsung-dsim is not in the global bridge_list >> (deferred probe pending: imx-lcdif: Cannot connect bridge) >> >> The samsung-dsim will not drm_bridge_add() itself until a DSI device wil= l >> try to mipi_dsi_attach() to the DSI Host, which can happen arbitratily l= ate >> on hot-pluggable hardware. >> >> As a preliminary step to supporting hotplug move drm_bridge_add() at pro= be >> time, so that the samsung-dsim DSI host bridge is available during boot, >> even without a connected DSI device. This results in: >> >> 1) samsung-dsim probes (and adds to drm_bridge_add() itself) >> 2) The lcdif starts probing multiple times, but >> lcdif_probe >> -> lcdif_load >> -> lcdif_attach_bridge >> -> devm_drm_of_get_bridge() --> OK, returns samsung-dsim ptr >> >> Signed-off-by: Luca Ceresoli > > We should probably amend > https://www.kernel.org/doc/html/latest/gpu/drm-kms-helpers.html#special-c= are-with-mipi-dsi-bridges > > To mention this use case here Right. I haven't updated the docs for this v1 because I was not sure the overall approach would be acked. Now Dmitry acked it overall, and I kind of infer you are not against, so I'll look into updating the docs in v2. However I find that section of the docs a bit hard to read especially from a newcomer perspective. A better understanding on my side would help in doing the right change as far as this patch is concerned, and as a bonus in improving the section overall (that would probably be a separate series). So I have a couple questions to start from: * Do I understand correctly that using the component framework is legacy, not recommended for new DRM development, and that converting existing code to stop using it is welcome? * The first bullet quotes "The upstream driver [...] isn=E2=80=99t a MIPI-= DSI host". If the upstream driver of a MIPI DSI link isn't a MIPI DSI host, what else could it be? What are the use cases here? * If read literally, none of the 4 bullets after "Indeed, there=E2=80=99s = multiple cases that needs to be considered" covers this driver (it does not use the component framework, it does not use DCS, and the upstream device is a DSI host). However the 3 bullets after "The ideal pattern to cover the last item" appear to cover what this driver does. Do we need a fifth bullet for drivers like this one? Or...? * To me it looks like the "bridge" word in this section is always used to refer to the DSI device. Would it make sense to replace "bridge" -> "[DSI ]device" in this section? (especially as the DSI host is also a DRM bridge) Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com