RE: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool statistics

Shenwei Wang
2022-11-14T16:31:50Z

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, November 14, 2022 10:28 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Alexander Lobakin <alexandr.lobakin@intel.com>; Paolo Abeni
> <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: Re: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
> statistics
>
> Caution: EXT Email
>
> > I did implement a quick version of u64_stats_t counters, and the
> > performance impact was about 1~3Mbps on the i.MX8QXP which is 1.2GHz
> > ARM64 Dual Core platform, which is about 1.5% performance decrease.
>
> Please post your code.
>
> Which driver did you copy? Maybe you picked a bad example?

The implementation was not optimized because it updated the u64_stats_t counters per packet.

Thanks,
Shenwei

>
> Andrew