RE: [EXT] Re: [PATCH 1/1] net: phylink: add phylink_set_mac_pm() helper

Shenwei Wang
2022-10-06T20:24:12Z

> -----Original Message-----
> From: Russell King <linux@armlinux.org.uk>
> Sent: Thursday, October 6, 2022 2:24 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Andrew Lunn <andrew@lunn.ch>; Heiner Kallweit <hkallweit1@gmail.com>;
> David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; netdev@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH 1/1] net: phylink: add phylink_set_mac_pm() helper
>
> Caution: EXT Email
>
> On Thu, Oct 06, 2022 at 12:02:37PM -0500, Shenwei Wang wrote:
> > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> > index e9d62f9598f9..a741c4bb5dd5 100644
> > --- a/drivers/net/phy/phylink.c
> > +++ b/drivers/net/phy/phylink.c
> > @@ -1722,6 +1722,15 @@ void phylink_stop(struct phylink *pl) }
> > EXPORT_SYMBOL_GPL(phylink_stop);
> >
> > +void phylink_set_mac_pm(struct phylink *pl)
>
> This needs documenting. The documentation for the function needs to mention
> when this should be called - so users are guided towards calling it at the right
> place in their drivers, rather than leaving them trying to figure it out and possibly
> get it wrong.
>

Thanks very much for the review. Will add it in the patch V2.

Thanks,
Shenwei

> Thanks.
>
> --
> RMK's Patch system:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ar
> mlinux.org.uk%2Fdeveloper%2Fpatches%2F&amp;data=05%7C01%7Cshenwei.
> wang%40nxp.com%7C817e10680d6345ce150908daa7d05d51%7C686ea1d3bc2
> b4c6fa92cd99c5c301635%7C0%7C0%7C638006810614113624%7CUnknown%7
> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=dRZOuDK5vKRHYZomgVbJLPu
> Adg13bxe3QGyPZyRWwwQ%3D&amp;reserved=0
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!