From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m16.yeah.net (mail-m16.yeah.net [220.197.32.19]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F6C819994F for ; Mon, 17 Feb 2025 10:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739787123; cv=none; b=Q//DP80iFPLEdrYhPGUJO8VRgH6LiVSFJtYztWuYolUTNPspV7UN73VsbIHk5uj57am93pZYRCZxsjd1bt2VmRJzG3x3QqpcSowPEUYkh/XgD7T+27rBWSbuoYBm7Xh+ODU73cLAoFZGqCkvTbQVBJAz0Gmju6nghKmKlq7JLgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739787123; c=relaxed/simple; bh=Dz/mc4M7A7lcIj44Btvtc/c5kfNMPa3gssZu8LopwoE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jdnTM+SAm8u+hpb/GCLVH+Yo82hNwD+4OuD1qZZuo7gRqNSy1L03jFtdz9RJ4y2Aennq5qcCmtBWgePrScbckBkruNr4XRB+fCMEheCEHxLjbgb/rHtOX+HLirqIIE19/DoaP8pYZCE91QIfSNhvO6adMNyxqSYwSSMi3XzdhGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net; spf=pass smtp.mailfrom=yeah.net; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b=qCELh/cv; arc=none smtp.client-ip=220.197.32.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yeah.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b="qCELh/cv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=FKkPX8SSsZZubXRSv3O7mjjd5d5lK8W3Iit7i4K0x3U=; b=qCELh/cvx9nCT6quI4lzHZYumKBpmnKj2xFQCw9dSGHy9efbOzhPpiAbQHnUqx Xp1/oOA20xiMTDk6COOjQNUMgfDUx+54jnB7YCT4qZWi7VbVfvryrk4m1KOqhmHK 1fvAzsweWtsOzRMKtaFZmUO4YUXy8qQWYrpUn1j47Z7lk= Received: from dragon (unknown []) by gzsmtp3 (Coremail) with SMTP id M88vCgCXW7BcC7NnpRIUCQ--.16375S3; Mon, 17 Feb 2025 18:11:42 +0800 (CST) Date: Mon, 17 Feb 2025 18:11:40 +0800 From: Shawn Guo To: Andrej Picej Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, upstream@lists.phytec.de Subject: Re: [PATCH v2 13/15] arm64: dts: imx8mm-phycore-som: Add overlay for rproc Message-ID: References: <20241202072052.2195283-1-andrej.picej@norik.com> <20241202072052.2195283-14-andrej.picej@norik.com> <221c8216-ce71-4ba2-9981-8612ff33ec2a@norik.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <221c8216-ce71-4ba2-9981-8612ff33ec2a@norik.com> X-CM-TRANSID:M88vCgCXW7BcC7NnpRIUCQ--.16375S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7CryDKw4xZF43ZrWDZry5urg_yoW8uw48pr y7uayUKrs2gF4xCrZIqw4DWryqy3W3XF43u34DZr1vgr4avF9FyF409ryfuryjqF4kZw4F vF4fZFZF9wn8ZaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jFdgAUUUUU= X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiCwL2ZWey6E2ehQAAsx On Tue, Dec 31, 2024 at 08:34:32AM +0100, Andrej Picej wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso > > > new file mode 100644 > > > index 000000000000..0c61946f0cf8 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso > > > @@ -0,0 +1,55 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2024 PHYTEC Messtechnik GmbH > > > + * Author: Dominik Haller > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +#include > > > + > > > +&{/} { > > > + reserved-memory { > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > > I'm getting this: > > > > arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:16.3-10: Warning (ranges_format): /fragment@0/__overlay__/reserved-memory:ranges: empty "ranges" property but its #size-cells (2) differs from /fragment@0/__overlay__ (1) > > arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:13.18-43.4: Warning (avoid_default_addr_size): /fragment@0/__overlay__/reserved-memory: Relying on default #address-cells value > > arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:13.18-43.4: Warning (avoid_default_addr_size): /fragment@0/__overlay__/reserved-memory: Relying on default #size-cells value > > > > I see, missed this before, sorry. But I have some problems fixing it. > I think the problem is that this is overlay, the same node put in the > imx8mm-phycore-som.dtsi doesn't trigger a warning. > The only solution that I found is that I specify the default address-cells > and size-cells in root node: > > > &{/} { > #address-cells = <2>; > #size-cells = <2>; > > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > ranges; > ... > }; > }; > > The same values are used in imx8mm.dtsi, but the checker fails to find these > default values. > Not sure if this is the right solution, though. Your input would be helpful, > thanks. Unless DT folks have better suggestion, I'm fine with this. Shawn