From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1401FF5FC for ; Mon, 7 Apr 2025 15:36:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744040209; cv=none; b=cDeW53tPuz3z2ftjt3Rqr3bQCMUrbhCz46E3rQ7zN5yhhIJytQEXLWL1zVO5B/Zyn4qvYW6UwzU6BnSflLmWFSIEuO5RLpkdGEcalcanbVHcbO3uQNoQ5pZtohkzqcm5KXOtykKnXD20A+2cpf4xwv0gXE1RDyn0CN3zd58iRO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744040209; c=relaxed/simple; bh=G+sqUQNrBPH4I/W5mHr1fMjnSyEYSDrtCw2osviFCmU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jaO+NGJ9eIaYznS1tU6KS2FgFmi1/IH4sIXye1gDtqEmo9CBqAHKMy5M9R9Z3W73EGgPAmk7PowYMTdoBb3scqrhWjvZNGbOI344mNQ3lqCV3lokgnDKl7ChOnHduiNAt8wnEr0QueDVqiTzaN4BiLR10Texnl6XLx1wVysFcyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YaoLbDHw; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YaoLbDHw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744040208; x=1775576208; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=G+sqUQNrBPH4I/W5mHr1fMjnSyEYSDrtCw2osviFCmU=; b=YaoLbDHw2UkbPC2EXNlkH6HEoyIsOj/+nZF8ZFSSB6WC7Z/X3r/TDS1k GOYGF4At4/XXBDvpSXOujnIs6JQx3hc7fTOsRtgYLTltHp+FTBsqjMeZx LmWduuyQnBH8vQ58lYPaWgMLI9hvwR1hKN6tMHLuPuTBELNqRr3MitsEs rZMuFYbe/BdolRj5PtTyR7mDGG7THwsWqQEtjev9JxV1PAfZ2+u4WXp6P O7AtdDTNh66JDNJI92NfnqzxdH2iSRQYYB5R9HN2JIWYGqTY0thWr4yKs 95DSCCaE8U7RohIMhSrpHWN7C4IZrC6EW0Kbjxa+PkxvzObt7dH8FY5e6 A==; X-CSE-ConnectionGUID: NsZkNAFFTtCRDIUvijBgDw== X-CSE-MsgGUID: +cY0hW+rTRuKVKdSLiMY5g== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="70811282" X-IronPort-AV: E=Sophos;i="6.15,194,1739865600"; d="scan'208";a="70811282" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2025 08:36:46 -0700 X-CSE-ConnectionGUID: rNN1lCbSQX+WW/v4pCR9wA== X-CSE-MsgGUID: R72zNQsnQ/GnEwWrCsQ2wA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,194,1739865600"; d="scan'208";a="132128993" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2025 08:36:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u1oWT-0000000A6zT-16Go; Mon, 07 Apr 2025 18:36:29 +0300 Date: Mon, 7 Apr 2025 18:36:28 +0300 From: Andy Shevchenko To: Herve Codina Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Rob Herring , Saravana Kannan , Bjorn Helgaas , Mark Brown , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 11/16] of: property: Allow fw_devlink device-tree support for x86 Message-ID: References: <20250407145546.270683-1-herve.codina@bootlin.com> <20250407145546.270683-12-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250407145546.270683-12-herve.codina@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Apr 07, 2025 at 04:55:40PM +0200, Herve Codina wrote: > PCI drivers can use a device-tree overlay to describe the hardware > available on the PCI board. This is the case, for instance, of the > LAN966x PCI device driver. > > Adding some more nodes in the device-tree overlay adds some more > consumer/supplier relationship between devices instantiated from this > overlay. > > Those fw_node consumer/supplier relationships are handled by fw_devlink > and are created based on the device-tree parsing done by the > of_fwnode_add_links() function. > > Those consumer/supplier links are needed in order to ensure a correct PM > runtime management and a correct removal order between devices. > > For instance, without those links a supplier can be removed before its > consumers is removed leading to all kind of issue if this consumer still > want the use the already removed supplier. > > The support for the usage of an overlay from a PCI driver has been added > on x86 systems in commit 1f340724419ed ("PCI: of: Create device tree PCI > host bridge node"). > > In the past, support for fw_devlink on x86 had been tried but this > support has been removed in commit 4a48b66b3f52 ("of: property: Disable > fw_devlink DT support for X86"). Indeed, this support was breaking some > x86 systems such as OLPC system and the regression was reported in [0]. > > Instead of disabling this support for all x86 system, use a finer grain > and disable this support only for the possible problematic subset of x86 > system mixing ACPI and device-tree at boot time (i.e. OLPC and CE4100). This is incorrect, they never had ACPI to begin with. Also there is third platform that are using DT on x86 core — SpreadTrum based phones. And not sure about AMD stuff (Geode?). > [0] https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@web.de/ Can you make this to be a Link tag? Link: https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@web.de/ [0] > Signed-off-by: Herve Codina -- With Best Regards, Andy Shevchenko