From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF3C19AD59 for ; Tue, 16 Jul 2024 15:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144812; cv=none; b=MPlYE0k+cjbMQIR9/gjqW0OS4K8BDksw0oa46FPoMRBdiYgdVcTCMVda88QzTZY8vf5f5odtPquHqM2AXkPvl26KJzb9EKdOrCMfEIKe8pk468PScA7RFq6PdFwqVuZ5xRbcVYymZZSZBPKNxnIhjhDFHaP4uQNh/U/G3XJ6C08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144812; c=relaxed/simple; bh=Ov0ZxuRqg19DOdyaVwSAZjy1CSU3sqSqbZdr+Bo8tNo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q6gaTeWLbORPhDF+bsCVW7LIYJqNrl54ZJ/4W9FvY/ZZpsiI55avZfNpfR6M5ytRC3i+nVm9qFINSafUAY76RpHjA1qduznIf4QZsT0Wk7LNt/EvKoPU5zWlxWrkjuF3cW9rf1IANlC5wN67WvL3g7o6O9dO2/oVMTaBA5uJ66Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l0mP+MLl; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l0mP+MLl" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1fb0d88fd25so39872885ad.0 for ; Tue, 16 Jul 2024 08:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721144810; x=1721749610; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GOZ0mHcem+Vs3dr0bori38FCvWKVYDMdvIY4Rdc3Vvo=; b=l0mP+MLl10KSiGiKRdvj9RouSrqucQmKLK/lQ0cfBuwFIxOilZ8TscyA2vRg6fSuSN I1Bs/qD0dlIcYtoYRQeYCxU3RI6agM/6jiQ5BmJiXOn1drhiZ4W7azEZE8ke6dH0+oyq gchL6IPzcLFLoBJxuB1PLnmvVGc/1xGqAed6bdcfrIPbYjpZ9hbXvUBqRcwvFmgA0iSn axBcxnk1/+VQqK7tLkpEe3m4xcQpSd5ViH1SyBfxCcwj3oIjQaNjrqRQ/qSlKzsvNExL rKFByoHakuKqSkNLBCcBNGqtlY63lQV6uxEWqFcIzFApYj/eo5tp7J0oeFrlCK0b6F5s s1og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721144810; x=1721749610; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GOZ0mHcem+Vs3dr0bori38FCvWKVYDMdvIY4Rdc3Vvo=; b=opUP2H4J37Cmk+hvFtm7gt1sAYbdrk/mynBTTzDt/DU0q6ZeYBnxj6vrjlG+nertP6 aUykl7znyJlwnl2AgLVV8hWzBWXL/kAI0vLUDUcJrGwsG/EmeBdUOSbBXNOrYx7yZZC4 6wzRDFjQHQTxSh35gcIf4dS8vhHxBneXSwDUOfFZULjt5XKEWAKj9yUF5z5ViKFIGIao VuKg3bDMYrdIx9HM4kzqWMk/WdB67HlGFxLKaYU5H8RSntrLu48/E2DEajtvzZ8BQoS5 HiF31rRG5nnqEZQjhuFfjTI8vAmw2FyRYfNGWE4+uTffeJOab2lB9S65C9wqtMNvMHKX aQvw== X-Forwarded-Encrypted: i=1; AJvYcCUEPujDAnqeIpLRynLVmtLgUdXVMnd3FEr+sKHbotkFnuq79BLs+L49epzFXRBOC6iLoe8zbYJPKGIOm8Eo48f0WgzI X-Gm-Message-State: AOJu0YwJC90+pORR5gB1xmUYngpa/h/xiQH66lvPLqgJ4cw06YGm1+w8 KLHMoE3FKMZ30gtdhWYfoW4ZA0R3+MDtJvJaECXDIrs/9aUOA6FyTZ7KUV/BUnI= X-Google-Smtp-Source: AGHT+IGuZHVU0ziAtoeqsGV04P2Tf0nyODoXzZ44+orFCy6lC6ncLmkiz+ZhBmIDQL7JpJUFd4iWGQ== X-Received: by 2002:a17:903:11cc:b0:1fb:6121:dfc0 with SMTP id d9443c01a7336-1fc3e6cae84mr37740675ad.19.1721144809911; Tue, 16 Jul 2024 08:46:49 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bbc2782sm59434125ad.102.2024.07.16.08.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:46:49 -0700 (PDT) Date: Tue, 16 Jul 2024 09:46:45 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai Subject: Re: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-5-7bcf6732d328@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-5-7bcf6732d328@nxp.com> On Fri, Jul 12, 2024 at 04:34:58PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Current tx_block is set to true, but there is case that no need to wait > response. Linux just needs to send data to remote processor, so let's > allow tx_block could be set to false. Ok, maybe - but this patch doesn't use the new functionality, i.e nothing changes. > > Reviewed-by: Jacky Bai > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 552fccebf7e2..01cf1dfb2e87 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -90,7 +90,7 @@ struct imx_rproc_mem { > #define ATT_CORE_MASK 0xffff > #define ATT_CORE(I) BIT((I)) > > -static int imx_rproc_xtr_mbox_init(struct rproc *rproc); > +static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block); > static void imx_rproc_free_mbox(struct rproc *rproc); > > struct imx_rproc { > @@ -369,7 +369,7 @@ static int imx_rproc_start(struct rproc *rproc) > struct arm_smccc_res res; > int ret; > > - ret = imx_rproc_xtr_mbox_init(rproc); > + ret = imx_rproc_xtr_mbox_init(rproc, true); > if (ret) > return ret; > > @@ -629,7 +629,7 @@ static void imx_rproc_kick(struct rproc *rproc, int vqid) > > static int imx_rproc_attach(struct rproc *rproc) > { > - return imx_rproc_xtr_mbox_init(rproc); > + return imx_rproc_xtr_mbox_init(rproc, true); > } > > static int imx_rproc_detach(struct rproc *rproc) > @@ -794,7 +794,7 @@ static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg) > queue_work(priv->workqueue, &priv->rproc_work); > } > > -static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > +static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block) > { > struct imx_rproc *priv = rproc->priv; > struct device *dev = priv->dev; > @@ -817,7 +817,7 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > > cl = &priv->cl; > cl->dev = dev; > - cl->tx_block = true; > + cl->tx_block = tx_block; > cl->tx_tout = 100; > cl->knows_txdone = false; > cl->rx_callback = imx_rproc_rx_callback; > @@ -1083,7 +1083,7 @@ static int imx_rproc_probe(struct platform_device *pdev) > > INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > > - ret = imx_rproc_xtr_mbox_init(rproc); > + ret = imx_rproc_xtr_mbox_init(rproc, true); > if (ret) > goto err_put_wkq; > > > -- > 2.37.1 >