From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5CE1922EB for ; Wed, 9 Oct 2024 11:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728474707; cv=none; b=UuNVFJ+hChXPuUExcaOdj3fxCuKu822QyJMfge92nLCcR3olmhU6ZUtT/dETWoujwLdD+7D3Fl6m3K6x+3Rggijg5c0a7zWvI8Vbv7WMKFBTjb6HaQGRXwyz69N7I9nXp0/AZmE+BdEfyukx7/3tKNA8pGBFjmMuQYRcHhnJnys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728474707; c=relaxed/simple; bh=7+eISHNu4uiQ47pDt/DSf8ldSBnlnXKbXyoRYwTIlV4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KeRytNuWMnpz072IEi1EdZcZXdM0w5aWJ15W5uFWsALDZXwsrEj/ZSYFXItigzVkj0baRL8cuQLx+UnZWvyEgWq7y3pRNxCKwmmUIZLqfUii0nEuwU0Z2Br7sh78rd1WZF/pvfvnpHtmBIHLGyVN3tiw6Qtl/YK950816POhMp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=r0Bn4Asn; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r0Bn4Asn" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a9963e47b69so364692866b.1 for ; Wed, 09 Oct 2024 04:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728474704; x=1729079504; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=r0Bn4AsnN1woKpc9lcQb6XkZaCatNkg5Sjo+VhyJyvisVvSuLeseyxy0/w7fXGFrej AoYmFjI47O9+n+3iAmQuT4N76HQLi5P9RDJqs9Ly4DEWe8ZzQjgBwJvx/CJBJ1PuT9VM kbvf9VdkujHEHhB+QCrv5UjfcNmxMtghBHUu+o71tFAzsvnRMKOPDmlwCjK6cwHIZAeC LMidPqNMVIXUmnNdRwUD+zgvqXWyCqbo7cS4k3csAupewkFv+szo4lZoUT9Mg7/EO32S PEkgPhSI3va9IqRt+b61O1jNeRsAMCigvTFP6cD1MfKStgSbRetbQ8GCNHoysDKOf75x vZSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728474704; x=1729079504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=omgHoytC1CvYf7t77n/2zNxlPDcPwss2HvH+W1CtvXU85UddZm6E7S42npcdbe0EGO 1FwI0+qkL6FwaDDhIfR+fOoIYQn0NpBZC2MzIPPAcYcKgNnR1BvOSE9jE/mhUaqzJTmy yIz9QhRIOFVHIw6qKRgW6vc1MrHmqy+UKTe96uym1q5nCe2baliCyzqgMbJxSGadbpd3 8MTmiAJ1eYUBrMiVhDdmdYXrRToi9WwexmS9NTDWhYUZRZtTBSCkK2VkqfKx4k3/zcEE aBhAjCqqkkOCB46fY3aa4PgfftGfbkSXBhbZlfiuqDmkOQs7tv6IR/EiWWATtPTERahH Rxgw== X-Forwarded-Encrypted: i=1; AJvYcCVrfLHhOmxpJYQEFwX1SyY9bK0ll8jvVdRhlEUen6uVwh2l5xMTjL0pG98HfePMhLCtZZU=@lists.linux.dev X-Gm-Message-State: AOJu0YwMPTc//n/IPUuUWWphp6byi0jt+QhVyCWenqhpqCRXd7I5a14t ScC6zbjRYH3VVciwGrSo9MNlezk85c5+8t8q2pYKFc+pNtACPffkoILHcEgLjOc= X-Google-Smtp-Source: AGHT+IGKpe5RJdRvKaNKGeWlJU8yuhUR86qwyFDbVPAhlwFfcx+fGtxwpK017I4wKqBnPOdRSWgB4w== X-Received: by 2002:a17:907:3da7:b0:a99:451b:38fe with SMTP id a640c23a62f3a-a998d174df2mr179992766b.26.1728474703666; Wed, 09 Oct 2024 04:51:43 -0700 (PDT) Received: from linaro.org ([82.77.84.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a995668f4b6sm396323966b.48.2024.10.09.04.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:51:43 -0700 (PDT) Date: Wed, 9 Oct 2024 14:51:41 +0300 From: Abel Vesa To: Pengfei Li Cc: krzk+dt@kernel.org, robh@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, ping.bai@nxp.com, ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver Message-ID: References: <20240627082426.394937-1-pengfei.li_1@nxp.com> <20240627082426.394937-2-pengfei.li_1@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627082426.394937-2-pengfei.li_1@nxp.com> On 24-06-27 16:24:25, Pengfei Li wrote: > IMX93_CLK_END was previously defined in imx93-clock.h to indicate > the number of clocks, but it is not part of the ABI, so it should > be moved to clk driver. > > Signed-off-by: Pengfei Li > --- > > Notes: > Change for v2: > - Use pre-processor define to simplify code. > > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index c6a9bc8ecc1f..c8b65146e76e 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -15,6 +15,8 @@ > > #include "clk.h" > > +#define IMX93_CLK_END 202 > + TBH, I don't like this. And I still don't understand the reason. Where are the clocks you want to add ? And why wouldn't it be OK to just keep this in the bindings header even if you need to add more clocks ? For the moment, I don't see the value of this change. Sorry, but NACK. > enum clk_sel { > LOW_SPEED_IO_SEL, > NON_IO_SEL, > -- > 2.34.1 >