From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EC972AEED for ; Sat, 19 Apr 2025 15:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745076646; cv=none; b=WZMdtSjrXxXjbG9omWsJNp5GH8guhQDe0Pl3oLmFnTmzdcNlLagtKsbPSAHsSFOMsRhKbYSCTDCjst3KHujoXGj7uydlVaNqR5kwyjKUwf1tv+DJ1Gw6WcMNdENlHK8ZplugqQMBC5RDOJ726toijEb8shHN/y6IXGitu/KEzFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745076646; c=relaxed/simple; bh=EJY6VnbO/oorT+t/r51LBHIJCvd7pfE+OXcRXcdWp/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ti17lqHbCON2jdLEZmzsy2kys466Bas8u5XvAfHoiBAlqukOGGy9Z8KTyaRseiSaL4WwKXbS06GNfNFV+NcEaUhk3r3TnsFJBOrO49tzDv9WJcykqKJZTq488p3U8dgZBmIX4YK8zoY4l+uuM3u29XvQaa1vaX1sHiCTtnRljuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kqy9yxI0; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kqy9yxI0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745076645; x=1776612645; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=EJY6VnbO/oorT+t/r51LBHIJCvd7pfE+OXcRXcdWp/Y=; b=kqy9yxI0ZfoOWs1glYcuiUfAd8IeLhIOjzDKlyVWWtXmPI8Z9C3j6jdY xg8nQpw9MkLbdPvL8dbzKq056ND84nxA0H+5Qujl7xO/ooR7uS2K/OOds xAl+EoI3kw/L4UDV6+XO/MuBhtCt9LcHiEcCONqz+TvmGRdhQYERB0RHg M/V4SXIwfEoEHO4b5XXwlXMh8dS4RWo6KnvzNsRFPiB2mIY3wGRL4f0VB xW/6CqPb+7xI7w6rSL8+LulS6lJ4oL0UqgRQRwtzfgvZKF+8945e8fvif qumRL0jDAoG5D4fndeSpAOK3l/R9fwoLOz1iZID/agGds9sJy/s0ohkO4 A==; X-CSE-ConnectionGUID: eXrZYSWSTkOUBPDX734ITw== X-CSE-MsgGUID: hbaIwPAbQjmUj4XtNbqEOA== X-IronPort-AV: E=McAfee;i="6700,10204,11408"; a="46806661" X-IronPort-AV: E=Sophos;i="6.15,224,1739865600"; d="scan'208";a="46806661" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2025 08:30:44 -0700 X-CSE-ConnectionGUID: CuoieLxUT1K3ksC/Kut48Q== X-CSE-MsgGUID: ZSJTu6nsQF+IEiTNRnHGnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,224,1739865600"; d="scan'208";a="154517506" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2025 08:30:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u6A9I-0000000DqsB-0AwJ; Sat, 19 Apr 2025 18:30:32 +0300 Date: Sat, 19 Apr 2025 18:30:31 +0300 From: Andy Shevchenko To: Herve Codina Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Rob Herring , Saravana Kannan , Bjorn Helgaas , Mark Brown , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 11/16] of: property: Allow fw_devlink device-tree support for x86 Message-ID: References: <20250407145546.270683-1-herve.codina@bootlin.com> <20250407145546.270683-12-herve.codina@bootlin.com> <20250408154925.5653d506@bootlin.com> <20250418151036.719f982b@bootlin.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250418151036.719f982b@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Apr 18, 2025 at 03:10:36PM +0200, Herve Codina wrote: > On Tue, 8 Apr 2025 17:34:54 +0300 > Andy Shevchenko wrote: > > On Tue, Apr 08, 2025 at 03:49:25PM +0200, Herve Codina wrote: > > > On Mon, 7 Apr 2025 18:36:28 +0300 > > > Andy Shevchenko wrote: > > > > On Mon, Apr 07, 2025 at 04:55:40PM +0200, Herve Codina wrote: ... > > > > This is incorrect, they never had ACPI to begin with. Also there is third > > > > platform that are using DT on x86 core — SpreadTrum based phones. > > > > > > I will rework the commit log to avoid 'mixing ACPI and device-tree' > > > > > > For "SpreadTrum based phones", do you have an idea about the Kconfig symbol > > > I could use to filter our this x86 systems? > > > > Hmm... good question. I don't think it was anything. The Airmont core just > > works and doesn't require anything special to be set. And platform is x86 with > > the devices that are established on ARM, so nothing special in device tree > > either, I suppose. Basically any x86 platform with OF should be excluded, > > rather think of what should be included. But I see that as opposite > > requirements to the same function. I have no idea how to solve this. Perhaps > > find that SpreadTrum Intel Atom-based device? Would be really hard, I believe. > > Especially if we want to install a custom kernel there... > > > > > Anything I find upstream related to SpreadTrum seems base on ARM cpus. > > > I probably miss something. > > > > There were two SoCs that were Intel Atom based [1]. And some patches [2] to x86 > > DT code were made to support those cases. > > > > > > And not sure about AMD stuff (Geode?). > > > > > > Same here, if some AMD devices need to be filtered out, is there a specific > > > Kconfig symbol I can use ? > > > > This is question to AMD people. I have no clue. > > > > [1]: https://www.anandtech.com/show/11196/mwc-2017-spreadtrum-launches-8core-intel-airmontbased-soc-with-cat-7-lte-for-smartphones > > > > [2]: 4e07db9c8db8 ("x86/devicetree: Use CPU description from Device Tree") > > and co. `git log --no-merges 4e07db9c8db8 -- arch/x86/kernel/devicetree.c > > I have tried to find a solution for this topic. > > Indeed, this patch enables fw_devlink based on device-tree on all x86 > platform except OLPC and CE4100. > > You have mentioned some other x86 based system that could have issues with > fw_devlink and it seems to be hard to have a complete list of systems for > which we should not enable fw_devlink (potential issues and so regression > against current kernel behavior). > > As you also proposed, we can thing on the opposite direction and enable > fw_devlink on x86 systems that need it. > > We need it because we need the device-tree description over PCI device feature > (CONFIG_PCI_DYNAMIC_OF_NODES) on x86 in order to support the LAN966x use case. > > What do you think about the following condition? > > if (IS_ENABLED(CONFIG_X86) && !IS_ENABLED(CONFIG_PCI_DYNAMIC_OF_NODES)) > return 0; /* Not enabled */ > > CONFIG_PCI_DYNAMIC_OF_NODES has already to set explicitly by the user. > > Do you think it makes sense and could be a good alternative instead of > filtering out a list of x86 systems ? At least this won't break old platforms that won't set that configuration option. Ideally, of course, it would be nice to have some kind of detection at run-time... -- With Best Regards, Andy Shevchenko