* [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
@ 2025-05-23 21:32 Frank Li
2025-05-26 15:28 ` Conor Dooley
2025-07-23 12:29 ` Vinod Koul
0 siblings, 2 replies; 7+ messages in thread
From: Frank Li @ 2025-05-23 21:32 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marek Vasut, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
for others.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../devicetree/bindings/dma/fsl,mxs-dma.yaml | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
index 75a7d9556699c..9102b615dbd61 100644
--- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
@@ -23,6 +23,35 @@ allOf:
properties:
power-domains: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx23-dma-apbx
+ then:
+ properties:
+ interrupt-names:
+ items:
+ - const: audio-adc
+ - const: audio-dac
+ - const: spdif-tx
+ - const: i2c
+ - const: saif0
+ - const: empty0
+ - const: auart0-rx
+ - const: auart0-tx
+ - const: auart1-rx
+ - const: auart1-tx
+ - const: saif1
+ - const: empty1
+ - const: empty2
+ - const: empty3
+ - const: empty4
+ - const: empty5
+ else:
+ properties:
+ interrupt-names: false
+
properties:
compatible:
oneOf:
@@ -54,6 +83,10 @@ properties:
minItems: 4
maxItems: 16
+ interrupt-names:
+ minItems: 4
+ maxItems: 16
+
"#dma-cells":
const: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
2025-05-23 21:32 [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx Frank Li
@ 2025-05-26 15:28 ` Conor Dooley
2025-05-28 15:50 ` Frank Li
2025-07-23 12:29 ` Vinod Koul
1 sibling, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2025-05-26 15:28 UTC (permalink / raw)
To: Frank Li
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marek Vasut, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]
On Fri, May 23, 2025 at 05:32:52PM -0400, Frank Li wrote:
> Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> for others.
The content of the patch seems okay, but why are you doing this? What is
the value on this particular platform but not the others?
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/dma/fsl,mxs-dma.yaml | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> index 75a7d9556699c..9102b615dbd61 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> @@ -23,6 +23,35 @@ allOf:
> properties:
> power-domains: false
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx23-dma-apbx
> + then:
> + properties:
> + interrupt-names:
> + items:
> + - const: audio-adc
> + - const: audio-dac
> + - const: spdif-tx
> + - const: i2c
> + - const: saif0
> + - const: empty0
> + - const: auart0-rx
> + - const: auart0-tx
> + - const: auart1-rx
> + - const: auart1-tx
> + - const: saif1
> + - const: empty1
> + - const: empty2
> + - const: empty3
> + - const: empty4
> + - const: empty5
> + else:
> + properties:
> + interrupt-names: false
> +
> properties:
> compatible:
> oneOf:
> @@ -54,6 +83,10 @@ properties:
> minItems: 4
> maxItems: 16
>
> + interrupt-names:
> + minItems: 4
> + maxItems: 16
> +
> "#dma-cells":
> const: 1
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
2025-05-26 15:28 ` Conor Dooley
@ 2025-05-28 15:50 ` Frank Li
2025-05-30 15:24 ` Conor Dooley
0 siblings, 1 reply; 7+ messages in thread
From: Frank Li @ 2025-05-28 15:50 UTC (permalink / raw)
To: Conor Dooley
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marek Vasut, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Mon, May 26, 2025 at 04:28:07PM +0100, Conor Dooley wrote:
> On Fri, May 23, 2025 at 05:32:52PM -0400, Frank Li wrote:
> > Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> > for others.
>
> The content of the patch seems okay, but why are you doing this? What is
> the value on this particular platform but not the others?
Actually it is not used in dma driver, i.MX23 is quite old chips (over 10year).
Just to match existed dts to reduce warnings.
Frank
>
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > .../devicetree/bindings/dma/fsl,mxs-dma.yaml | 33 +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> > index 75a7d9556699c..9102b615dbd61 100644
> > --- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> > @@ -23,6 +23,35 @@ allOf:
> > properties:
> > power-domains: false
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx23-dma-apbx
> > + then:
> > + properties:
> > + interrupt-names:
> > + items:
> > + - const: audio-adc
> > + - const: audio-dac
> > + - const: spdif-tx
> > + - const: i2c
> > + - const: saif0
> > + - const: empty0
> > + - const: auart0-rx
> > + - const: auart0-tx
> > + - const: auart1-rx
> > + - const: auart1-tx
> > + - const: saif1
> > + - const: empty1
> > + - const: empty2
> > + - const: empty3
> > + - const: empty4
> > + - const: empty5
> > + else:
> > + properties:
> > + interrupt-names: false
> > +
> > properties:
> > compatible:
> > oneOf:
> > @@ -54,6 +83,10 @@ properties:
> > minItems: 4
> > maxItems: 16
> >
> > + interrupt-names:
> > + minItems: 4
> > + maxItems: 16
> > +
> > "#dma-cells":
> > const: 1
> >
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
2025-05-28 15:50 ` Frank Li
@ 2025-05-30 15:24 ` Conor Dooley
2025-05-30 16:11 ` Frank Li
0 siblings, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2025-05-30 15:24 UTC (permalink / raw)
To: Frank Li
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marek Vasut, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Wed, May 28, 2025 at 11:50:42AM -0400, Frank Li wrote:
> On Mon, May 26, 2025 at 04:28:07PM +0100, Conor Dooley wrote:
> > On Fri, May 23, 2025 at 05:32:52PM -0400, Frank Li wrote:
> > > Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> > > for others.
> >
> > The content of the patch seems okay, but why are you doing this? What is
> > the value on this particular platform but not the others?
>
> Actually it is not used in dma driver, i.MX23 is quite old chips (over 10year).
If they provide no value, why not just delete them?
> Just to match existed dts to reduce warnings.
You should mention this in your commit message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
2025-05-30 15:24 ` Conor Dooley
@ 2025-05-30 16:11 ` Frank Li
2025-06-06 15:17 ` Conor Dooley
0 siblings, 1 reply; 7+ messages in thread
From: Frank Li @ 2025-05-30 16:11 UTC (permalink / raw)
To: Conor Dooley
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marek Vasut, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Fri, May 30, 2025 at 04:24:51PM +0100, Conor Dooley wrote:
> On Wed, May 28, 2025 at 11:50:42AM -0400, Frank Li wrote:
> > On Mon, May 26, 2025 at 04:28:07PM +0100, Conor Dooley wrote:
> > > On Fri, May 23, 2025 at 05:32:52PM -0400, Frank Li wrote:
> > > > Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> > > > for others.
> > >
> > > The content of the patch seems okay, but why are you doing this? What is
> > > the value on this particular platform but not the others?
> >
> > Actually it is not used in dma driver, i.MX23 is quite old chips (over 10year).
>
> If they provide no value, why not just delete them?
The platform is too old. I have not hardware to test if it really unused.
Frank
>
> > Just to match existed dts to reduce warnings.
>
> You should mention this in your commit message.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
2025-05-30 16:11 ` Frank Li
@ 2025-06-06 15:17 ` Conor Dooley
0 siblings, 0 replies; 7+ messages in thread
From: Conor Dooley @ 2025-06-06 15:17 UTC (permalink / raw)
To: Frank Li
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marek Vasut, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Fri, May 30, 2025 at 12:11:17PM -0400, Frank Li wrote:
> On Fri, May 30, 2025 at 04:24:51PM +0100, Conor Dooley wrote:
> > On Wed, May 28, 2025 at 11:50:42AM -0400, Frank Li wrote:
> > > On Mon, May 26, 2025 at 04:28:07PM +0100, Conor Dooley wrote:
> > > > On Fri, May 23, 2025 at 05:32:52PM -0400, Frank Li wrote:
> > > > > Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> > > > > for others.
> > > >
> > > > The content of the patch seems okay, but why are you doing this? What is
> > > > the value on this particular platform but not the others?
> > >
> > > Actually it is not used in dma driver, i.MX23 is quite old chips (over 10year).
> >
> > If they provide no value, why not just delete them?
>
> The platform is too old. I have not hardware to test if it really unused.
oh well,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
2025-05-23 21:32 [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx Frank Li
2025-05-26 15:28 ` Conor Dooley
@ 2025-07-23 12:29 ` Vinod Koul
1 sibling, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2025-07-23 12:29 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Marek Vasut,
dmaengine, devicetree, imx, linux-arm-kernel, linux-kernel,
Frank Li
Cc: imx
On Fri, 23 May 2025 17:32:52 -0400, Frank Li wrote:
> Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> for others.
>
>
Applied, thanks!
[1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx
commit: e3a9ccd21897a59d02cf2b7a95297086249306d6
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-07-23 12:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-23 21:32 [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx Frank Li
2025-05-26 15:28 ` Conor Dooley
2025-05-28 15:50 ` Frank Li
2025-05-30 15:24 ` Conor Dooley
2025-05-30 16:11 ` Frank Li
2025-06-06 15:17 ` Conor Dooley
2025-07-23 12:29 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).