* [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions
@ 2025-07-03 13:08 Hiago De Franco
2025-07-04 16:25 ` Mathieu Poirier
0 siblings, 1 reply; 9+ messages in thread
From: Hiago De Franco @ 2025-07-03 13:08 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier
Cc: Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta,
linux-remoteproc, imx, linux-arm-kernel, linux-kernel,
Hiago De Franco, Ritesh Kumar
From: Hiago De Franco <hiago.franco@toradex.com>
Merge the contiguous ITCM and DTCM regions into a single region to
prevent failures when loading ELF files with large sections:
remoteproc remoteproc0: powering up imx-rproc
remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824
imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0
remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0
remoteproc remoteproc0: Failed to load program segments: -22
remoteproc remoteproc0: Boot failed: -22
This approach is the same as commit 8749919defb8 ("remoteproc:
imx_rproc: Merge TCML/U").
Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com>
Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
---
Hi,
The ELF I tested had the following data section:
Memory region Used Size Region Size %age Used
m_interrupts: 680 B 1 KB 66.41%
m_text: 6984 B 127 KB 5.37%
m_data: 130224 B 128 KB 99.35%
m_data2: 0 GB 16 MB 0.00%
[100%] Built target hello_world_cm7.elf
Which triggered the error. After this patch, remoteproc was able to boot
and work fine. Thanks!
---
drivers/remoteproc/imx_rproc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 74299af1d7f1..bbf089ef48ee 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = {
static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
/* dev addr , sys addr , size , flags */
- /* ITCM */
- { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM },
+ /* D/ITCM */
+ { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM },
/* OCRAM_S */
{ 0x00180000, 0x00180000, 0x00009000, 0 },
/* OCRAM */
@@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
{ 0x08000000, 0x08000000, 0x08000000, 0 },
/* DDR (Code) - alias */
{ 0x10000000, 0x40000000, 0x0FFE0000, 0 },
- /* DTCM */
- { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM },
/* OCRAM_S - alias */
{ 0x20180000, 0x00180000, 0x00008000, ATT_OWN },
/* OCRAM */
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-03 13:08 [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions Hiago De Franco @ 2025-07-04 16:25 ` Mathieu Poirier 2025-07-04 19:08 ` Hiago De Franco 0 siblings, 1 reply; 9+ messages in thread From: Mathieu Poirier @ 2025-07-04 16:25 UTC (permalink / raw) To: Hiago De Franco Cc: Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta, linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Hiago De Franco, Ritesh Kumar Good morning, On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > From: Hiago De Franco <hiago.franco@toradex.com> > > Merge the contiguous ITCM and DTCM regions into a single region to > prevent failures when loading ELF files with large sections: > > remoteproc remoteproc0: powering up imx-rproc > remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0 > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > remoteproc remoteproc0: Failed to load program segments: -22 > remoteproc remoteproc0: Boot failed: -22 > > This approach is the same as commit 8749919defb8 ("remoteproc: > imx_rproc: Merge TCML/U"). > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > --- > Hi, > > The ELF I tested had the following data section: > > Memory region Used Size Region Size %age Used > m_interrupts: 680 B 1 KB 66.41% > m_text: 6984 B 127 KB 5.37% > m_data: 130224 B 128 KB 99.35% > m_data2: 0 GB 16 MB 0.00% > [100%] Built target hello_world_cm7.elf > > Which triggered the error. After this patch, remoteproc was able to boot > and work fine. Thanks! > --- > drivers/remoteproc/imx_rproc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 74299af1d7f1..bbf089ef48ee 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = { > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > /* dev addr , sys addr , size , flags */ > - /* ITCM */ > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, > + /* D/ITCM */ > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM }, > /* OCRAM_S */ > { 0x00180000, 0x00180000, 0x00009000, 0 }, > /* OCRAM */ > @@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > { 0x08000000, 0x08000000, 0x08000000, 0 }, > /* DDR (Code) - alias */ > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > - /* DTCM */ > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, In commit 8749919defb8 "dev addr" and "sys addr" were both contiguous, but in this patch "dev addr" is not. How will this work with new kernel that use old FW images? Am I missing something? Thanks, Mathieu > /* OCRAM_S - alias */ > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > /* OCRAM */ > -- > 2.39.5 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-04 16:25 ` Mathieu Poirier @ 2025-07-04 19:08 ` Hiago De Franco 2025-07-05 13:25 ` Peng Fan 2025-07-07 16:13 ` Mathieu Poirier 0 siblings, 2 replies; 9+ messages in thread From: Hiago De Franco @ 2025-07-04 19:08 UTC (permalink / raw) To: Mathieu Poirier Cc: Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta, linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Hiago De Franco, Ritesh Kumar Hi Mathieu, On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: > Good morning, > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > > From: Hiago De Franco <hiago.franco@toradex.com> > > > > Merge the contiguous ITCM and DTCM regions into a single region to > > prevent failures when loading ELF files with large sections: > > > > remoteproc remoteproc0: powering up imx-rproc > > remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0 > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > > remoteproc remoteproc0: Failed to load program segments: -22 > > remoteproc remoteproc0: Boot failed: -22 > > > > This approach is the same as commit 8749919defb8 ("remoteproc: > > imx_rproc: Merge TCML/U"). > > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > > --- > > Hi, > > > > The ELF I tested had the following data section: > > > > Memory region Used Size Region Size %age Used > > m_interrupts: 680 B 1 KB 66.41% > > m_text: 6984 B 127 KB 5.37% > > m_data: 130224 B 128 KB 99.35% > > m_data2: 0 GB 16 MB 0.00% > > [100%] Built target hello_world_cm7.elf > > > > Which triggered the error. After this patch, remoteproc was able to boot > > and work fine. Thanks! > > --- > > drivers/remoteproc/imx_rproc.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > > index 74299af1d7f1..bbf089ef48ee 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = { > > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > /* dev addr , sys addr , size , flags */ > > - /* ITCM */ > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, > > + /* D/ITCM */ > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM }, > > /* OCRAM_S */ > > { 0x00180000, 0x00180000, 0x00009000, 0 }, > > /* OCRAM */ > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > > /* DDR (Code) - alias */ > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > > - /* DTCM */ > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, > > In commit 8749919defb8 "dev addr" and "sys addr" were both contiguous, but in > this patch "dev addr" is not. How will this work with new kernel that use old > FW images? Am I missing something? No, you are correct, I think the use case I tested was not good enough. If I understand correctly, this will break older firmware expecting .data at 0x20000000 because dev_addr is no longer mapped for DTCM entry. Do you think it is possible (or reccomend) another approach to fix this issue? In this case to keep using the TCM, instead of going to OCRAM or DDR. Thanks, Hiago. > > Thanks, > Mathieu > > > /* OCRAM_S - alias */ > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > > /* OCRAM */ > > -- > > 2.39.5 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-04 19:08 ` Hiago De Franco @ 2025-07-05 13:25 ` Peng Fan 2025-07-05 22:39 ` Peng Fan 2025-07-07 16:13 ` Mathieu Poirier 1 sibling, 1 reply; 9+ messages in thread From: Peng Fan @ 2025-07-05 13:25 UTC (permalink / raw) To: Hiago De Franco, Mathieu Poirier Cc: Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Daniel Baluta, linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hiago De Franco, Ritesh Kumar > Subject: Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM > regions > > Hi Mathieu, > > On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: > > Good morning, > > > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > > > From: Hiago De Franco <hiago.franco@toradex.com> > > > > > > Merge the contiguous ITCM and DTCM regions into a single region > to > > > prevent failures when loading ELF files with large sections: > > > > > > remoteproc remoteproc0: powering up imx-rproc remoteproc > > > remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = > 0x1fcb0 > > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > remoteproc > > > remoteproc0: Failed to load program segments: -22 remoteproc > > > remoteproc0: Boot failed: -22 > > > > > > This approach is the same as commit 8749919defb8 ("remoteproc: > > > imx_rproc: Merge TCML/U"). > > > > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > > > --- > > > Hi, > > > > > > The ELF I tested had the following data section: > > > > > > Memory region Used Size Region Size %age Used > > > m_interrupts: 680 B 1 KB 66.41% > > > m_text: 6984 B 127 KB 5.37% > > > m_data: 130224 B 128 KB 99.35% > > > m_data2: 0 GB 16 MB 0.00% > > > [100%] Built target hello_world_cm7.elf > > > > > > Which triggered the error. After this patch, remoteproc was able to > > > boot and work fine. Thanks! > > > --- > > > drivers/remoteproc/imx_rproc.c | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index > 74299af1d7f1..bbf089ef48ee > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att > > > imx_rproc_att_imx8qxp[] = { > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > > /* dev addr , sys addr , size , flags */ > > > - /* ITCM */ > > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | > ATT_IOMEM }, > > > + /* D/ITCM */ > > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | > ATT_IOMEM }, > > > /* OCRAM_S */ > > > { 0x00180000, 0x00180000, 0x00009000, 0 }, > > > /* OCRAM */ > > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att > imx_rproc_att_imx8mn[] = { > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > > > /* DDR (Code) - alias */ > > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > > > - /* DTCM */ > > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | > ATT_IOMEM }, > > > > In commit 8749919defb8 "dev addr" and "sys addr" were both > contiguous, > > but in this patch "dev addr" is not. How will this work with new > > kernel that use old FW images? Am I missing something? > > No, you are correct, I think the use case I tested was not good enough. > > If I understand correctly, this will break older firmware expecting .data > at 0x20000000 because dev_addr is no longer mapped for DTCM entry. > The ITCM in M7 starts from 0, DTCM in M7 starts from 0x20000000. The ITCM/DTCM is continuous from A53 perspective. You let linux to load continuous text/data, but if the dev addr start from ITCM_START+128KB is not reserved from Reference manual. How could M7 still work proper if M7 accessing [0x20000, x] dev_addr? You need update your linker script to separate text into different sections. Regards, Peng. > Do you think it is possible (or reccomend) another approach to fix this > issue? In this case to keep using the TCM, instead of going to OCRAM > or DDR. > > Thanks, > Hiago. > > > > > Thanks, > > Mathieu > > > > > /* OCRAM_S - alias */ > > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > > > /* OCRAM */ > > > -- > > > 2.39.5 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-05 13:25 ` Peng Fan @ 2025-07-05 22:39 ` Peng Fan 0 siblings, 0 replies; 9+ messages in thread From: Peng Fan @ 2025-07-05 22:39 UTC (permalink / raw) To: Peng Fan, Hiago De Franco, Mathieu Poirier Cc: Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Daniel Baluta, linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hiago De Franco, Ritesh Kumar > Subject: RE: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM > regions > > > Subject: Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM > > regions > > > > Hi Mathieu, > > > > On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: > > > Good morning, > > > > > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > > > > From: Hiago De Franco <hiago.franco@toradex.com> > > > > > > > > Merge the contiguous ITCM and DTCM regions into a single region > > to > > > > prevent failures when loading ELF files with large sections: > > > > > > > > remoteproc remoteproc0: powering up imx-rproc remoteproc > > > > remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > > > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = > > 0x1fcb0 > > > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > > remoteproc > > > > remoteproc0: Failed to load program segments: -22 remoteproc > > > > remoteproc0: Boot failed: -22 > > > > > > > > This approach is the same as commit 8749919defb8 ("remoteproc: > > > > imx_rproc: Merge TCML/U"). > > > > > > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > > > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > > > > --- > > > > Hi, > > > > > > > > The ELF I tested had the following data section: > > > > > > > > Memory region Used Size Region Size %age Used > > > > m_interrupts: 680 B 1 KB 66.41% > > > > m_text: 6984 B 127 KB 5.37% > > > > m_data: 130224 B 128 KB 99.35% > > > > m_data2: 0 GB 16 MB 0.00% > > > > [100%] Built target hello_world_cm7.elf > > > > > > > > Which triggered the error. After this patch, remoteproc was able > > > > to boot and work fine. Thanks! > > > > --- > > > > drivers/remoteproc/imx_rproc.c | 6 ++---- > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > > b/drivers/remoteproc/imx_rproc.c index > > 74299af1d7f1..bbf089ef48ee > > > > 100644 > > > > --- a/drivers/remoteproc/imx_rproc.c > > > > +++ b/drivers/remoteproc/imx_rproc.c > > > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att > > > > imx_rproc_att_imx8qxp[] = { > > > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > > > /* dev addr , sys addr , size , flags */ > > > > - /* ITCM */ > > > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | > > ATT_IOMEM }, > > > > + /* D/ITCM */ > > > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | > > ATT_IOMEM }, > > > > /* OCRAM_S */ > > > > { 0x00180000, 0x00180000, 0x00009000, 0 }, > > > > /* OCRAM */ > > > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att > > imx_rproc_att_imx8mn[] = { > > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > > > > /* DDR (Code) - alias */ > > > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > > > > - /* DTCM */ > > > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | > > ATT_IOMEM }, > > > > > > In commit 8749919defb8 "dev addr" and "sys addr" were both > > contiguous, > > > but in this patch "dev addr" is not. How will this work with new > > > kernel that use old FW images? Am I missing something? > > > > No, you are correct, I think the use case I tested was not good enough. > > > > If I understand correctly, this will break older firmware expecting > > .data at 0x20000000 because dev_addr is no longer mapped for > DTCM entry. > > > > The ITCM in M7 starts from 0, DTCM in M7 starts from 0x20000000. > The ITCM/DTCM is continuous from A53 perspective. > > You let linux to load continuous text/data, but if the dev addr start > from ITCM_START+128KB is not reserved from Reference manual. Typo: ITCM_START + 128KB is reserved. > > How could M7 still work proper if M7 accessing [0x20000, x] dev_addr? > > You need update your linker script to separate text into different > sections. > > Regards, > Peng. > > > Do you think it is possible (or reccomend) another approach to fix > > this issue? In this case to keep using the TCM, > > > > instead of going to OCRAM > > or DDR. > > > > Thanks, > > Hiago. > > > > > > > > Thanks, > > > Mathieu > > > > > > > /* OCRAM_S - alias */ > > > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > > > > /* OCRAM */ > > > > -- > > > > 2.39.5 > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-04 19:08 ` Hiago De Franco 2025-07-05 13:25 ` Peng Fan @ 2025-07-07 16:13 ` Mathieu Poirier 2025-07-08 17:29 ` Hiago De Franco 1 sibling, 1 reply; 9+ messages in thread From: Mathieu Poirier @ 2025-07-07 16:13 UTC (permalink / raw) To: Hiago De Franco Cc: Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta, linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Hiago De Franco, Ritesh Kumar On Fri, Jul 04, 2025 at 04:08:16PM -0300, Hiago De Franco wrote: > Hi Mathieu, > > On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: > > Good morning, > > > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > > > From: Hiago De Franco <hiago.franco@toradex.com> > > > > > > Merge the contiguous ITCM and DTCM regions into a single region to > > > prevent failures when loading ELF files with large sections: > > > > > > remoteproc remoteproc0: powering up imx-rproc > > > remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0 > > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > > > remoteproc remoteproc0: Failed to load program segments: -22 > > > remoteproc remoteproc0: Boot failed: -22 > > > > > > This approach is the same as commit 8749919defb8 ("remoteproc: > > > imx_rproc: Merge TCML/U"). > > > > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > > > --- > > > Hi, > > > > > > The ELF I tested had the following data section: > > > > > > Memory region Used Size Region Size %age Used > > > m_interrupts: 680 B 1 KB 66.41% > > > m_text: 6984 B 127 KB 5.37% > > > m_data: 130224 B 128 KB 99.35% > > > m_data2: 0 GB 16 MB 0.00% > > > [100%] Built target hello_world_cm7.elf > > > > > > Which triggered the error. After this patch, remoteproc was able to boot > > > and work fine. Thanks! > > > --- > > > drivers/remoteproc/imx_rproc.c | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > > > index 74299af1d7f1..bbf089ef48ee 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = { > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > > /* dev addr , sys addr , size , flags */ > > > - /* ITCM */ > > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, > > > + /* D/ITCM */ > > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM }, > > > /* OCRAM_S */ > > > { 0x00180000, 0x00180000, 0x00009000, 0 }, > > > /* OCRAM */ > > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > > > /* DDR (Code) - alias */ > > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > > > - /* DTCM */ > > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, > > > > In commit 8749919defb8 "dev addr" and "sys addr" were both contiguous, but in > > this patch "dev addr" is not. How will this work with new kernel that use old > > FW images? Am I missing something? > > No, you are correct, I think the use case I tested was not good enough. > > If I understand correctly, this will break older firmware expecting > .data at 0x20000000 because dev_addr is no longer mapped for DTCM entry. > Correct. Older firmware would still expect DTCM at 0x20000000. > Do you think it is possible (or reccomend) another approach to fix this > issue? In this case to keep using the TCM, instead of going to OCRAM or > DDR. > To me the best way to proceed is understand why using the current mapping is a problem. The changelog describes a failure condition when dealing with large sections but does not indicate _why_ that is happening. I think that's what needs to be fixed rather than trying to move mappings around. > Thanks, > Hiago. > > > > > Thanks, > > Mathieu > > > > > /* OCRAM_S - alias */ > > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > > > /* OCRAM */ > > > -- > > > 2.39.5 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-07 16:13 ` Mathieu Poirier @ 2025-07-08 17:29 ` Hiago De Franco 2025-07-09 8:26 ` Peng Fan 0 siblings, 1 reply; 9+ messages in thread From: Hiago De Franco @ 2025-07-08 17:29 UTC (permalink / raw) To: Mathieu Poirier Cc: Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta, linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Hiago De Franco, Ritesh Kumar Hi Peng, Mathieu, On Mon, Jul 07, 2025 at 10:13:02AM -0600, Mathieu Poirier wrote: > On Fri, Jul 04, 2025 at 04:08:16PM -0300, Hiago De Franco wrote: > > Hi Mathieu, > > > > On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: > > > Good morning, > > > > > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > > > > From: Hiago De Franco <hiago.franco@toradex.com> > > > > > > > > Merge the contiguous ITCM and DTCM regions into a single region to > > > > prevent failures when loading ELF files with large sections: > > > > > > > > remoteproc remoteproc0: powering up imx-rproc > > > > remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > > > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0 > > > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > > > > remoteproc remoteproc0: Failed to load program segments: -22 > > > > remoteproc remoteproc0: Boot failed: -22 > > > > > > > > This approach is the same as commit 8749919defb8 ("remoteproc: > > > > imx_rproc: Merge TCML/U"). > > > > > > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > > > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > > > > --- > > > > Hi, > > > > > > > > The ELF I tested had the following data section: > > > > > > > > Memory region Used Size Region Size %age Used > > > > m_interrupts: 680 B 1 KB 66.41% > > > > m_text: 6984 B 127 KB 5.37% > > > > m_data: 130224 B 128 KB 99.35% > > > > m_data2: 0 GB 16 MB 0.00% > > > > [100%] Built target hello_world_cm7.elf > > > > > > > > Which triggered the error. After this patch, remoteproc was able to boot > > > > and work fine. Thanks! > > > > --- > > > > drivers/remoteproc/imx_rproc.c | 6 ++---- > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > > > > index 74299af1d7f1..bbf089ef48ee 100644 > > > > --- a/drivers/remoteproc/imx_rproc.c > > > > +++ b/drivers/remoteproc/imx_rproc.c > > > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = { > > > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > > > /* dev addr , sys addr , size , flags */ > > > > - /* ITCM */ > > > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, > > > > + /* D/ITCM */ > > > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM }, > > > > /* OCRAM_S */ > > > > { 0x00180000, 0x00180000, 0x00009000, 0 }, > > > > /* OCRAM */ > > > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > > > > /* DDR (Code) - alias */ > > > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > > > > - /* DTCM */ > > > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, > > > > > > In commit 8749919defb8 "dev addr" and "sys addr" were both contiguous, but in > > > this patch "dev addr" is not. How will this work with new kernel that use old > > > FW images? Am I missing something? > > > > No, you are correct, I think the use case I tested was not good enough. > > > > If I understand correctly, this will break older firmware expecting > > .data at 0x20000000 because dev_addr is no longer mapped for DTCM entry. > > > > Correct. Older firmware would still expect DTCM at 0x20000000. > > > > Do you think it is possible (or reccomend) another approach to fix this > > issue? In this case to keep using the TCM, instead of going to OCRAM or > > DDR. > > > > To me the best way to proceed is understand why using the current mapping is a > problem. The changelog describes a failure condition when dealing with large > sections but does not indicate _why_ that is happening. I think that's what > needs to be fixed rather than trying to move mappings around. Thanks for the information you both provided, sorry for the noise, so please Mathieu ignore this patch. I will work around this in a different way. By the way, Peng, I noticed the DDR linker from MCUXpresso does not work if the firmware is larger than 128KB, since the .data is placed right after .text and loaded later to DDR. The imx_rproc driver should instead have a way to do the other way around: starting from the firwmare inside DDR, we could set PC and stack from M7 to point to DDR and start the execution. Probably will be slower, but it would make the DDR case possible. Correct me if I am wrong, but as my current understanding the DDR linker is broken without this change to the driver. Anyway, maybe something for a future patch. Thanks, Hiago. > > > Thanks, > > Hiago. > > > > > > > > Thanks, > > > Mathieu > > > > > > > /* OCRAM_S - alias */ > > > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > > > > /* OCRAM */ > > > > -- > > > > 2.39.5 > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-08 17:29 ` Hiago De Franco @ 2025-07-09 8:26 ` Peng Fan 2025-07-10 15:46 ` Hiago De Franco 0 siblings, 1 reply; 9+ messages in thread From: Peng Fan @ 2025-07-09 8:26 UTC (permalink / raw) To: Hiago De Franco Cc: Mathieu Poirier, Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta, linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Hiago De Franco, Ritesh Kumar On Tue, Jul 08, 2025 at 02:29:53PM -0300, Hiago De Franco wrote: >Hi Peng, Mathieu, > >On Mon, Jul 07, 2025 at 10:13:02AM -0600, Mathieu Poirier wrote: >> On Fri, Jul 04, 2025 at 04:08:16PM -0300, Hiago De Franco wrote: >> > Hi Mathieu, >> > >> > On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: >> > > Good morning, >> > > >> > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: >> > > > From: Hiago De Franco <hiago.franco@toradex.com> >> > > > >> > > > Merge the contiguous ITCM and DTCM regions into a single region to >> > > > prevent failures when loading ELF files with large sections: >> > > > >> > > > remoteproc remoteproc0: powering up imx-rproc >> > > > remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 >> > > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0 >> > > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 >> > > > remoteproc remoteproc0: Failed to load program segments: -22 >> > > > remoteproc remoteproc0: Boot failed: -22 >> > > > >> > > > This approach is the same as commit 8749919defb8 ("remoteproc: >> > > > imx_rproc: Merge TCML/U"). >> > > > >> > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> >> > > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> >> > > > --- >> > > > Hi, >> > > > >> > > > The ELF I tested had the following data section: >> > > > >> > > > Memory region Used Size Region Size %age Used >> > > > m_interrupts: 680 B 1 KB 66.41% >> > > > m_text: 6984 B 127 KB 5.37% >> > > > m_data: 130224 B 128 KB 99.35% >> > > > m_data2: 0 GB 16 MB 0.00% >> > > > [100%] Built target hello_world_cm7.elf >> > > > >> > > > Which triggered the error. After this patch, remoteproc was able to boot >> > > > and work fine. Thanks! >> > > > --- >> > > > drivers/remoteproc/imx_rproc.c | 6 ++---- >> > > > 1 file changed, 2 insertions(+), 4 deletions(-) >> > > > >> > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c >> > > > index 74299af1d7f1..bbf089ef48ee 100644 >> > > > --- a/drivers/remoteproc/imx_rproc.c >> > > > +++ b/drivers/remoteproc/imx_rproc.c >> > > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = { >> > > > >> > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { >> > > > /* dev addr , sys addr , size , flags */ >> > > > - /* ITCM */ >> > > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, >> > > > + /* D/ITCM */ >> > > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM }, >> > > > /* OCRAM_S */ >> > > > { 0x00180000, 0x00180000, 0x00009000, 0 }, >> > > > /* OCRAM */ >> > > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { >> > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, >> > > > /* DDR (Code) - alias */ >> > > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, >> > > > - /* DTCM */ >> > > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, >> > > >> > > In commit 8749919defb8 "dev addr" and "sys addr" were both contiguous, but in >> > > this patch "dev addr" is not. How will this work with new kernel that use old >> > > FW images? Am I missing something? >> > >> > No, you are correct, I think the use case I tested was not good enough. >> > >> > If I understand correctly, this will break older firmware expecting >> > .data at 0x20000000 because dev_addr is no longer mapped for DTCM entry. >> > >> >> Correct. Older firmware would still expect DTCM at 0x20000000. >> >> >> > Do you think it is possible (or reccomend) another approach to fix this >> > issue? In this case to keep using the TCM, instead of going to OCRAM or >> > DDR. >> > >> >> To me the best way to proceed is understand why using the current mapping is a >> problem. The changelog describes a failure condition when dealing with large >> sections but does not indicate _why_ that is happening. I think that's what >> needs to be fixed rather than trying to move mappings around. > >Thanks for the information you both provided, sorry for the noise, so >please Mathieu ignore this patch. I will work around this in a different >way. > >By the way, Peng, I noticed the DDR linker from MCUXpresso does not work >if the firmware is larger than 128KB, since the .data is placed right >after .text and loaded later to DDR. The imx_rproc driver should instead >have a way to do the other way around: starting from the firwmare inside >DDR, we could set PC and stack from M7 to point to DDR and start the >execution. Probably will be slower, but it would make the DDR case >possible. I am not aware of the size limitation if image is built to run in DDR. It maybe MCUXpresso team just reuse the linker script for TCM and only update the link address. You could update the linker script to build larger image. In final elf, .data is put just after .text, but the related section loading address should be specified as my understanding. See below, .data is at 0x20000000 for M7. xx-gcc -S imx8mn_m7_TCM_rpmsg_lite_str_echo_rtos.elf There are 20 section headers, starting at offset 0xc998: Section Headers: [Nr] Name Type Addr Off Size ES Flg Lk Inf Al [ 0] NULL 00000000 000000 000000 00 0 0 0 [ 1] .interrupts PROGBITS 00000000 001000 000240 00 A 0 0 4 [ 2] .resource_table PROGBITS 00000240 001240 000058 00 A 0 0 1 [ 3] .text PROGBITS 000002a0 0012a0 0046b0 00 AX 0 0 16 [ 4] .ARM ARM_EXIDX 00004950 005950 000008 00 AL 3 0 4 [ 5] .init_array INIT_ARRAY 00004958 005958 000004 04 WA 0 0 4 [ 6] .fini_array FINI_ARRAY 0000495c 00595c 000004 04 WA 0 0 4 [ 7] .data PROGBITS 20000000 006000 00000c 00 WA 0 0 4 [ 8] .ncache.init PROGBITS 80000000 00600c 000000 00 W 0 0 1 [ 9] .ncache PROGBITS 80000000 00600c 000000 00 W 0 0 1 [10] .bss NOBITS 2000000c 00600c 00a4ac 00 WA 0 0 4 [11] .heap NOBITS 2000a4b8 00600c 000400 00 WA 0 0 1 [12] .stack NOBITS 2000a8b8 00600c 000400 00 WA 0 0 1 [13] .ARM.attributes ARM_ATTRIBUTES 00000000 00600c 000030 00 0 0 1 [14] .debug_line_str PROGBITS 00000000 00603c 0002b1 01 MS 0 0 1 [15] .comment PROGBITS 00000000 0062ed 000055 01 MS 0 0 1 [16] .debug_frame PROGBITS 00000000 006344 000260 00 0 0 4 [17] .symtab SYMTAB 00000000 0065a4 003cd0 10 18 586 4 [18] .strtab STRTAB 00000000 00a274 002664 00 0 0 1 [19] .shstrtab STRTAB 00000000 00c8d8 0000bd 00 0 0 1 > >Correct me if I am wrong, but as my current understanding the DDR linker >is broken without this change to the driver. Anyway, maybe something for >a future patch. If you wanna image in DDR, you could specifiy the address of data section in your linker script. But for support ddr elf file, you need patches as below: https://lore.kernel.org/linux-arm-kernel/CAEnQRZC5t=qmo+OJLW+dqZg4gH9cAN=paWDSGbrJb2AvkKBqxg@mail.gmail.com/T/#ec54c42b70416b002936a643b44b79661dd2a8483 This patchset was rejected, because we need to get stack/pc from .interrupts section and store to ITCM. Latest NXP m7 demo has included a new section for stack/pc, but this will only be public in 2025 Q3 release, for pre-2025-Q3 releases, still need the upper patchset. Regards, Peng > >Thanks, >Hiago. > >> >> > Thanks, >> > Hiago. >> > >> > > >> > > Thanks, >> > > Mathieu >> > > >> > > > /* OCRAM_S - alias */ >> > > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, >> > > > /* OCRAM */ >> > > > -- >> > > > 2.39.5 >> > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions 2025-07-09 8:26 ` Peng Fan @ 2025-07-10 15:46 ` Hiago De Franco 0 siblings, 0 replies; 9+ messages in thread From: Hiago De Franco @ 2025-07-10 15:46 UTC (permalink / raw) To: Peng Fan Cc: Mathieu Poirier, Bjorn Andersson, Shawn Guo, Sascha Hauer, Iuliana Prodan, Peng Fan, Daniel Baluta, linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Hiago De Franco, Ritesh Kumar On Wed, Jul 09, 2025 at 04:26:52PM +0800, Peng Fan wrote: > On Tue, Jul 08, 2025 at 02:29:53PM -0300, Hiago De Franco wrote: > >Hi Peng, Mathieu, > > > >On Mon, Jul 07, 2025 at 10:13:02AM -0600, Mathieu Poirier wrote: > >> On Fri, Jul 04, 2025 at 04:08:16PM -0300, Hiago De Franco wrote: > >> > Hi Mathieu, > >> > > >> > On Fri, Jul 04, 2025 at 10:25:19AM -0600, Mathieu Poirier wrote: > >> > > Good morning, > >> > > > >> > > On Thu, Jul 03, 2025 at 10:08:31AM -0300, Hiago De Franco wrote: > >> > > > From: Hiago De Franco <hiago.franco@toradex.com> > >> > > > > >> > > > Merge the contiguous ITCM and DTCM regions into a single region to > >> > > > prevent failures when loading ELF files with large sections: > >> > > > > >> > > > remoteproc remoteproc0: powering up imx-rproc > >> > > > remoteproc remoteproc0: Booting fw image rproc-imx-rproc-fw, size 151824 > >> > > > imx-rproc imx8mp-cm7: Translation failed: da = 0x1f48 len = 0x1fcb0 > >> > > > remoteproc remoteproc0: bad phdr da 0x1f48 mem 0x1fcb0 > >> > > > remoteproc remoteproc0: Failed to load program segments: -22 > >> > > > remoteproc remoteproc0: Boot failed: -22 > >> > > > > >> > > > This approach is the same as commit 8749919defb8 ("remoteproc: > >> > > > imx_rproc: Merge TCML/U"). > >> > > > > >> > > > Suggested-by: Ritesh Kumar <ritesh.kumar@toradex.com> > >> > > > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com> > >> > > > --- > >> > > > Hi, > >> > > > > >> > > > The ELF I tested had the following data section: > >> > > > > >> > > > Memory region Used Size Region Size %age Used > >> > > > m_interrupts: 680 B 1 KB 66.41% > >> > > > m_text: 6984 B 127 KB 5.37% > >> > > > m_data: 130224 B 128 KB 99.35% > >> > > > m_data2: 0 GB 16 MB 0.00% > >> > > > [100%] Built target hello_world_cm7.elf > >> > > > > >> > > > Which triggered the error. After this patch, remoteproc was able to boot > >> > > > and work fine. Thanks! > >> > > > --- > >> > > > drivers/remoteproc/imx_rproc.c | 6 ++---- > >> > > > 1 file changed, 2 insertions(+), 4 deletions(-) > >> > > > > >> > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > >> > > > index 74299af1d7f1..bbf089ef48ee 100644 > >> > > > --- a/drivers/remoteproc/imx_rproc.c > >> > > > +++ b/drivers/remoteproc/imx_rproc.c > >> > > > @@ -166,8 +166,8 @@ static const struct imx_rproc_att imx_rproc_att_imx8qxp[] = { > >> > > > > >> > > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > >> > > > /* dev addr , sys addr , size , flags */ > >> > > > - /* ITCM */ > >> > > > - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, > >> > > > + /* D/ITCM */ > >> > > > + { 0x00000000, 0x007E0000, 0x00040000, ATT_OWN | ATT_IOMEM }, > >> > > > /* OCRAM_S */ > >> > > > { 0x00180000, 0x00180000, 0x00009000, 0 }, > >> > > > /* OCRAM */ > >> > > > @@ -180,8 +180,6 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > >> > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > >> > > > /* DDR (Code) - alias */ > >> > > > { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > >> > > > - /* DTCM */ > >> > > > - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, > >> > > > >> > > In commit 8749919defb8 "dev addr" and "sys addr" were both contiguous, but in > >> > > this patch "dev addr" is not. How will this work with new kernel that use old > >> > > FW images? Am I missing something? > >> > > >> > No, you are correct, I think the use case I tested was not good enough. > >> > > >> > If I understand correctly, this will break older firmware expecting > >> > .data at 0x20000000 because dev_addr is no longer mapped for DTCM entry. > >> > > >> > >> Correct. Older firmware would still expect DTCM at 0x20000000. > >> > >> > >> > Do you think it is possible (or reccomend) another approach to fix this > >> > issue? In this case to keep using the TCM, instead of going to OCRAM or > >> > DDR. > >> > > >> > >> To me the best way to proceed is understand why using the current mapping is a > >> problem. The changelog describes a failure condition when dealing with large > >> sections but does not indicate _why_ that is happening. I think that's what > >> needs to be fixed rather than trying to move mappings around. > > > >Thanks for the information you both provided, sorry for the noise, so > >please Mathieu ignore this patch. I will work around this in a different > >way. > > > >By the way, Peng, I noticed the DDR linker from MCUXpresso does not work > >if the firmware is larger than 128KB, since the .data is placed right > >after .text and loaded later to DDR. The imx_rproc driver should instead > >have a way to do the other way around: starting from the firwmare inside > >DDR, we could set PC and stack from M7 to point to DDR and start the > >execution. Probably will be slower, but it would make the DDR case > >possible. > > I am not aware of the size limitation if image is built to run in DDR. > It maybe MCUXpresso team just reuse the linker script for TCM and only > update the link address. > > You could update the linker script to build larger image. > > In final elf, .data is put just after .text, but the related section > loading address should be specified as my understanding. See below, > .data is at 0x20000000 for M7. > > xx-gcc -S imx8mn_m7_TCM_rpmsg_lite_str_echo_rtos.elf > There are 20 section headers, starting at offset 0xc998: > > Section Headers: > [Nr] Name Type Addr Off Size ES Flg Lk Inf Al > [ 0] NULL 00000000 000000 000000 00 0 0 0 > [ 1] .interrupts PROGBITS 00000000 001000 000240 00 A 0 0 4 > [ 2] .resource_table PROGBITS 00000240 001240 000058 00 A 0 0 1 > [ 3] .text PROGBITS 000002a0 0012a0 0046b0 00 AX 0 0 16 > [ 4] .ARM ARM_EXIDX 00004950 005950 000008 00 AL 3 0 4 > [ 5] .init_array INIT_ARRAY 00004958 005958 000004 04 WA 0 0 4 > [ 6] .fini_array FINI_ARRAY 0000495c 00595c 000004 04 WA 0 0 4 > [ 7] .data PROGBITS 20000000 006000 00000c 00 WA 0 0 4 > [ 8] .ncache.init PROGBITS 80000000 00600c 000000 00 W 0 0 1 > [ 9] .ncache PROGBITS 80000000 00600c 000000 00 W 0 0 1 > [10] .bss NOBITS 2000000c 00600c 00a4ac 00 WA 0 0 4 > [11] .heap NOBITS 2000a4b8 00600c 000400 00 WA 0 0 1 > [12] .stack NOBITS 2000a8b8 00600c 000400 00 WA 0 0 1 > [13] .ARM.attributes ARM_ATTRIBUTES 00000000 00600c 000030 00 0 0 1 > [14] .debug_line_str PROGBITS 00000000 00603c 0002b1 01 MS 0 0 1 > [15] .comment PROGBITS 00000000 0062ed 000055 01 MS 0 0 1 > [16] .debug_frame PROGBITS 00000000 006344 000260 00 0 0 4 > [17] .symtab SYMTAB 00000000 0065a4 003cd0 10 18 586 4 > [18] .strtab STRTAB 00000000 00a274 002664 00 0 0 1 > [19] .shstrtab STRTAB 00000000 00c8d8 0000bd 00 0 0 1 > > > > >Correct me if I am wrong, but as my current understanding the DDR linker > >is broken without this change to the driver. Anyway, maybe something for > >a future patch. > > If you wanna image in DDR, you could specifiy the address of data section > in your linker script. > > But for support ddr elf file, you need patches as below: > https://lore.kernel.org/linux-arm-kernel/CAEnQRZC5t=qmo+OJLW+dqZg4gH9cAN=paWDSGbrJb2AvkKBqxg@mail.gmail.com/T/#ec54c42b70416b002936a643b44b79661dd2a8483 > This patchset was rejected, because we need to get stack/pc from .interrupts > section and store to ITCM. > > Latest NXP m7 demo has included a new section for stack/pc, but > this will only be public in 2025 Q3 release, for pre-2025-Q3 releases, > still need the upper patchset. Great, thanks for all the information Peng. I will inform my team here. Best regards, Hiago. > > Regards, > Peng > > > > >Thanks, > >Hiago. > > > >> > >> > Thanks, > >> > Hiago. > >> > > >> > > > >> > > Thanks, > >> > > Mathieu > >> > > > >> > > > /* OCRAM_S - alias */ > >> > > > { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > >> > > > /* OCRAM */ > >> > > > -- > >> > > > 2.39.5 > >> > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-07-10 15:46 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-07-03 13:08 [PATCH] remoteproc: imx_rproc: merge ITCM and DTCM regions Hiago De Franco 2025-07-04 16:25 ` Mathieu Poirier 2025-07-04 19:08 ` Hiago De Franco 2025-07-05 13:25 ` Peng Fan 2025-07-05 22:39 ` Peng Fan 2025-07-07 16:13 ` Mathieu Poirier 2025-07-08 17:29 ` Hiago De Franco 2025-07-09 8:26 ` Peng Fan 2025-07-10 15:46 ` Hiago De Franco
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).