From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A958D23BCEE for ; Tue, 15 Jul 2025 15:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752593570; cv=none; b=VD4xinexbQGrLysaWqJS85LPglXEQJvFzFsMssKrjSg2HObh+KXhBowP63nK+TiNmCjux8bzWGi6nUYz8sHO4l3l8Mh2N8szAS+9mLn6N+Wjf86H9ACvc7ZFrQ4mBel4sfnw+f3DV/VpG3XLjeR9+drMONDhGo7NT8lFI3qQJE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752593570; c=relaxed/simple; bh=qUHDQT2XageAU0kIkbMdtj4nwVZk54055G83360ZEYQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M6XNzyhRP27dXF+sLsWT2RQqF6RURtqhlxq7cmUsOH0ROHKGH0DhXma6gxbYuboQZPZyHH9RgXpa5068fjqIyWy6xP8TNOesDwNZ9ASbjdr0L0Yd+Grei48aG++C3m2iVbyuKkkhQY1rtO4lW1DTUhf6Cl1e53NGx8sBRKtqY5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UAHSqq5C; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UAHSqq5C" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-23636167b30so51096295ad.1 for ; Tue, 15 Jul 2025 08:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752593568; x=1753198368; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=33yHY0U8ND4bNjhKpzusNE0usrblN+UAP92ijnAvwrA=; b=UAHSqq5CkfcbDwqhAol5nUWliX+UIiLGMWcPJN/13kp2G5EfC3mgI9HPJ/Wbk/2Eo2 MRmM6yJB9R6EIs7mjjFuX1OmTI6yJMmh2YmKw9slmRAvIjuskBveOZugcEefY9wP15Av jhNlNIIfPIjQVt8Op+INSmwHPiG5JJH3m1z0rUoG87pLsL3Il+i5kZPqvPHw5n7HJPXO 0IS6aiGH9XmgtMAx1NGtMjIlgHfnE1XUrZd0iY+SmqDg1yebPk2N8f1GxBH6GmNll6dz vOY6LybDc4ANuycEOjdFENmfV6l2sYyNXiSh7yzny17/jqVkXpQlb/K9sZBYgkpy5bTH QAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752593568; x=1753198368; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=33yHY0U8ND4bNjhKpzusNE0usrblN+UAP92ijnAvwrA=; b=TAUP3Krlq46G1NgcJIm+setB+gVqfhROGcxuPSyUc6PTTecQseaM43ISsIQYCaYFGs HC4BHDUv/gPf/fiOvp17u6nx7wTmRukWYyTzQ9bYxbFABH0Uwp+tPFwXRRy7ckVjO+uu fxxwjq+zFcgK/ewbT/3NyShQUdiTSjmBiiX5ifsuPlWpdWoj1tO9njFynkrzUe6pmh6s hFL83Vp4J7+iPbEnjomVCAGRMaw6SFRAnieyzF5WqPFKMG1pfdn38AS3u8cCOMi6ei9w +QUjrzYhUIScBjJssQVDOYmXeVtD3Sr1/MheZ8TKA33mpsLnwDJUDabqHd8V13gO5O/O e+tg== X-Forwarded-Encrypted: i=1; AJvYcCUfjol+NO0+YWZ2qYToiQstn5v7ucRPou0AuPWFr3X/3SveMKPLyWVpb32HtxsN9Stbrw0=@lists.linux.dev X-Gm-Message-State: AOJu0YxmsPZIa7K8eEqjq4Eb10h4XqQ43qU9ypT0oIByL/r9TiLPKoPD HCChJ3dta0qVg4CfzysAqkyGk/JkX0QCRyJ1Wh+gm3ThYbSTZ0VP3FWXBdA+qnsBSsE= X-Gm-Gg: ASbGncudtRcpw5QoLy3SNapNDpEAf526QOuGdi8k1Pi5Pj0KEoe9++/Jpz13EYzYUH6 XmIEvgXVjPEzFHJXtSxnDdgBc9dgCZtf8oq7cQv83yCtg93TssZoG7Ot+kywsbewyW++Z0bqB0b D4ylQllnAIh7lcFeoCrunuOMJ0dzUYHmmhYGjRE21VF6TEahcKIT2XHg8uJ9bTdKdmHvs2e0/NZ LX+KJabcI+HdkADTQJOohrHKUzMRua+4HilTp0EyJ42wfKUt022G55cpK7NskNiAMzjdyj2k8+w yEwavT4uB6w1ob7BAE+PaCrT/uvMsUQgGL+fwgmqjAWpErnzp3DCxQYOCl/66pJLoGcZ6KQx/DL aOALxwe/tGtybEDj1XXBD5HRr X-Google-Smtp-Source: AGHT+IHkJUK5ENBeylJNtS4qtHpCbavXcR17LDaafdWZuI5joLSCqs8sTEoGsBj18ccUt3gtd70HMA== X-Received: by 2002:a17:903:2c8:b0:237:d25b:8f07 with SMTP id d9443c01a7336-23dee0d7c54mr275182995ad.44.1752593567667; Tue, 15 Jul 2025 08:32:47 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:3f17:6d67:cf82:708]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de4323cd5sm110969645ad.126.2025.07.15.08.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 08:32:47 -0700 (PDT) Date: Tue, 15 Jul 2025 09:32:44 -0600 From: Mathieu Poirier To: Hiago De Franco Cc: Ulf Hansson , linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Shawn Guo , Sascha Hauer , Bjorn Andersson , Hiago De Franco , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , daniel.baluta@nxp.com, iuliana.prodan@oss.nxp.com, "Rafael J . Wysocki" , Peng Fan Subject: Re: [PATCH v7 3/3] remoteproc: imx_rproc: detect and attach to pre-booted remote cores Message-ID: References: <20250629172512.14857-1-hiagofranco@gmail.com> <20250629172512.14857-4-hiagofranco@gmail.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250629172512.14857-4-hiagofranco@gmail.com> On Sun, Jun 29, 2025 at 02:25:12PM -0300, Hiago De Franco wrote: > From: Hiago De Franco > > When the Cortex-M remote core is started and already running before > Linux boots (typically by the Cortex-A bootloader using a command like > bootaux), the current driver is unable to attach to it. This is because > the driver only checks for remote cores running in different SCFW > partitions. However in this case, the M-core is in the same partition as > Linux and is already powered up and running by the bootloader. > > This patch adds a check using dev_pm_genpd_is_on() to verify whether the > M-core's power domains are already on. If all power domain devices are > on, the driver assumes the M-core is running and proceed to attach to > it. > > To accomplish this, we need to avoid passing any attach_data or flags to > dev_pm_domain_attach_list(), allowing the platform device become a > consumer of the power domain provider without changing its current > state. > > During probe, also enable and sync the device runtime PM to make sure > the power domains are correctly managed when the core is controlled by > the kernel. > > Suggested-by: Ulf Hansson > Reviewed-by: Ulf Hansson > Reviewed-by: Peng Fan > Signed-off-by: Hiago De Franco > --- > v6 -> v7: > - Added Peng reviewed-by. > v5 -> v6: > - Commit description improved, as suggested. Added Ulf Hansson reviewed > by. Comment on imx-rproc.c improved. > v4 -> v5: > - pm_runtime_get_sync() removed in favor of > pm_runtime_resume_and_get(). Now it also checks the return value of > this function. > - Added pm_runtime_disable() and pm_runtime_put() to imx_rproc_remove() > function. > v3 -> v4: > - Changed to use the new dev_pm_genpd_is_on() function instead, as > suggested by Ulf. This will now get the power status of the two > remote cores power domains to decided if imx_rpoc needs to attach or > not. In order to do that, pm_runtime_enable() and > pm_runtime_get_sync() were introduced and pd_data was removed. > v2 -> v3: > - Unchanged. > v1 -> v2: > - Dropped unecessary include. Removed the imx_rproc_is_on function, as > suggested. > --- > drivers/remoteproc/imx_rproc.c | 37 +++++++++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 5 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 627e57a88db2..24597b60c5b0 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -890,10 +891,8 @@ static int imx_rproc_partition_notify(struct notifier_block *nb, > static int imx_rproc_attach_pd(struct imx_rproc *priv) > { > struct device *dev = priv->dev; > - int ret; > - struct dev_pm_domain_attach_data pd_data = { > - .pd_flags = PD_FLAG_DEV_LINK_ON, > - }; > + int ret, i; > + bool detached = true; > > /* > * If there is only one power-domain entry, the platform driver framework > @@ -902,7 +901,22 @@ static int imx_rproc_attach_pd(struct imx_rproc *priv) > if (dev->pm_domain) > return 0; > > - ret = dev_pm_domain_attach_list(dev, &pd_data, &priv->pd_list); > + ret = dev_pm_domain_attach_list(dev, NULL, &priv->pd_list); > + /* > + * If all the power domain devices are already turned on, the remote > + * core is already powered up and running when the kernel booted (e.g., > + * started by U-Boot's bootaux command). In this case attach to it. > + */ > + for (i = 0; i < ret; i++) { > + if (!dev_pm_genpd_is_on(priv->pd_list->pd_devs[i])) { > + detached = false; > + break; > + } > + } I was doing one final review of this work when I noticed the return code for dev_pm_domain_attach_list() is never checked for error. Thanks, Mathieu > + > + if (detached) > + priv->rproc->state = RPROC_DETACHED; > + > return ret < 0 ? ret : 0; > } > > @@ -1146,6 +1160,15 @@ static int imx_rproc_probe(struct platform_device *pdev) > } > } > > + if (dcfg->method == IMX_RPROC_SCU_API) { > + pm_runtime_enable(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret) { > + dev_err(dev, "pm_runtime get failed: %d\n", ret); > + goto err_put_clk; > + } > + } > + > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > @@ -1171,6 +1194,10 @@ static void imx_rproc_remove(struct platform_device *pdev) > struct rproc *rproc = platform_get_drvdata(pdev); > struct imx_rproc *priv = rproc->priv; > > + if (priv->dcfg->method == IMX_RPROC_SCU_API) { > + pm_runtime_disable(priv->dev); > + pm_runtime_put(priv->dev); > + } > clk_disable_unprepare(priv->clk); > rproc_del(rproc); > imx_rproc_put_scu(rproc); > -- > 2.39.5 >