From: Cristian Marussi <cristian.marussi@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
arm-scmi@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] firmware: imx: sm-misc: Dump syslog info
Date: Tue, 19 Aug 2025 18:28:17 +0100 [thread overview]
Message-ID: <aKS0MUXlQvMTfV4d@pluto> (raw)
In-Reply-To: <20250710-sm-misc-api-v1-v2-6-c3e953e34be6@nxp.com>
On Thu, Jul 10, 2025 at 04:33:31PM +0800, Peng Fan wrote:
> Add sysfs interface to read System Manager syslog info
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/firmware/imx/sm-misc.c | 178 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 178 insertions(+)
>
> diff --git a/drivers/firmware/imx/sm-misc.c b/drivers/firmware/imx/sm-misc.c
> index fc3ee12c2be878e0285183e3381c9514a63d5142..10aab5b127f65ecc57db9ab6c0c2c2b84d1dd864 100644
> --- a/drivers/firmware/imx/sm-misc.c
> +++ b/drivers/firmware/imx/sm-misc.c
> @@ -3,6 +3,7 @@
> * Copyright 2024 NXP
> */
>
Hi,
I have not so much to say about this: you expose one value per-sysfs
entry as prescribe BUT this also means a lot of messages to exchage to
retrieve a whole new fresh log each time a single sysfs entry is
queried...a bit ugly but I wouldn't now how to handle this differently
with the current log command format indeed...
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2025-08-19 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 8:33 [PATCH v2 0/6] firmware: arm_scmi: imx: Dump syslog and system_info Peng Fan
2025-07-10 8:33 ` [PATCH v2 1/6] firmware: arm_scmi: imx: Add documentation for MISC_BOARD_INFO Peng Fan
2025-07-10 8:33 ` [PATCH v2 2/6] firmware: arm_scmi: imx: Support discovering buildinfo of MISC protocol Peng Fan
2025-08-19 15:57 ` Cristian Marussi
2025-07-10 8:33 ` [PATCH v2 3/6] firmware: arm_scmi: imx: Support getting cfg info " Peng Fan
2025-08-19 15:59 ` Cristian Marussi
2025-07-10 8:33 ` [PATCH v2 4/6] firmware: arm_scmi: imx: Support getting board " Peng Fan
2025-08-19 16:28 ` Cristian Marussi
2025-07-10 8:33 ` [PATCH v2 5/6] firmware: arm_scmi: imx: Support getting syslog " Peng Fan
2025-08-19 17:09 ` Cristian Marussi
2025-08-21 9:05 ` Peng Fan
2025-07-10 8:33 ` [PATCH v2 6/6] firmware: imx: sm-misc: Dump syslog info Peng Fan
2025-08-19 17:28 ` Cristian Marussi [this message]
2025-08-18 2:25 ` [PATCH v2 0/6] firmware: arm_scmi: imx: Dump syslog and system_info Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKS0MUXlQvMTfV4d@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).