imx.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2
@ 2025-08-19  2:43 Haibo Chen
  2025-08-19 15:50 ` Frank Li
  2025-08-22  9:19 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Haibo Chen @ 2025-08-19  2:43 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
	Frank Li
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Haibo Chen

1, the phy support up to 8Mbit/s databitrate for CAN FD.
   refer to product data sheet:
     https://www.nxp.com/docs/en/data-sheet/TJA1463.pdf
2, the standby pin of the phy is ACTIVE_LOW.
3, the phy of flexcan2 connect the standby/en pin to PCAL6408 on i2c4 bus.

Fixes: 02b7adb791e1 ("arm64: dts: imx95-19x19-evk: add adc0 flexcan[1,2] i2c[2,3] uart5 spi3 and tpm3")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
index 2f949a0d48d2d8066388884703c3b3cd678f16e1..9d034275c847606919af8ee4a80a00599abf4d8b 100644
--- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
@@ -80,17 +80,17 @@ linux_cma: linux,cma {
 	flexcan1_phy: can-phy0 {
 		compatible = "nxp,tjr1443";
 		#phy-cells = <0>;
-		max-bitrate = <1000000>;
+		max-bitrate = <8000000>;
 		enable-gpios = <&i2c6_pcal6416 6 GPIO_ACTIVE_HIGH>;
-		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_HIGH>;
+		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_LOW>;
 	};
 
 	flexcan2_phy: can-phy1 {
 		compatible = "nxp,tjr1443";
 		#phy-cells = <0>;
-		max-bitrate = <1000000>;
-		enable-gpios = <&i2c6_pcal6416 4 GPIO_ACTIVE_HIGH>;
-		standby-gpios = <&i2c6_pcal6416 3 GPIO_ACTIVE_HIGH>;
+		max-bitrate = <8000000>;
+		enable-gpios = <&i2c4_gpio_expander_21 4 GPIO_ACTIVE_HIGH>;
+		standby-gpios = <&i2c4_gpio_expander_21 3 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_vref_1v8: regulator-1p8v {

---
base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
change-id: 20250819-can-dts-fix-62ac1d02c007

Best regards,
-- 
Haibo Chen <haibo.chen@nxp.com>


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2
  2025-08-19  2:43 [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2 Haibo Chen
@ 2025-08-19 15:50 ` Frank Li
  2025-08-21 15:03   ` Frank Li
  2025-08-22  9:19 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Frank Li @ 2025-08-19 15:50 UTC (permalink / raw)
  To: Haibo Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
	devicetree, imx, linux-arm-kernel, linux-kernel

On Tue, Aug 19, 2025 at 10:43:37AM +0800, Haibo Chen wrote:
> 1, the phy support up to 8Mbit/s databitrate for CAN FD.
>    refer to product data sheet:
>      https://www.nxp.com/docs/en/data-sheet/TJA1463.pdf
> 2, the standby pin of the phy is ACTIVE_LOW.
> 3, the phy of flexcan2 connect the standby/en pin to PCAL6408 on i2c4 bus.
>
> Fixes: 02b7adb791e1 ("arm64: dts: imx95-19x19-evk: add adc0 flexcan[1,2] i2c[2,3] uart5 spi3 and tpm3")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> index 2f949a0d48d2d8066388884703c3b3cd678f16e1..9d034275c847606919af8ee4a80a00599abf4d8b 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> @@ -80,17 +80,17 @@ linux_cma: linux,cma {
>  	flexcan1_phy: can-phy0 {
>  		compatible = "nxp,tjr1443";
>  		#phy-cells = <0>;
> -		max-bitrate = <1000000>;
> +		max-bitrate = <8000000>;
>  		enable-gpios = <&i2c6_pcal6416 6 GPIO_ACTIVE_HIGH>;
> -		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_HIGH>;
> +		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_LOW>;

It use go though CAN phy.

Frank
>  	};
>
>  	flexcan2_phy: can-phy1 {
>  		compatible = "nxp,tjr1443";
>  		#phy-cells = <0>;
> -		max-bitrate = <1000000>;
> -		enable-gpios = <&i2c6_pcal6416 4 GPIO_ACTIVE_HIGH>;
> -		standby-gpios = <&i2c6_pcal6416 3 GPIO_ACTIVE_HIGH>;
> +		max-bitrate = <8000000>;
> +		enable-gpios = <&i2c4_gpio_expander_21 4 GPIO_ACTIVE_HIGH>;
> +		standby-gpios = <&i2c4_gpio_expander_21 3 GPIO_ACTIVE_LOW>;
>  	};
>
>  	reg_vref_1v8: regulator-1p8v {
>
> ---
> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> change-id: 20250819-can-dts-fix-62ac1d02c007
>
> Best regards,
> --
> Haibo Chen <haibo.chen@nxp.com>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2
  2025-08-19 15:50 ` Frank Li
@ 2025-08-21 15:03   ` Frank Li
  0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-08-21 15:03 UTC (permalink / raw)
  To: Haibo Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
	devicetree, imx, linux-arm-kernel, linux-kernel

On Tue, Aug 19, 2025 at 11:50:17AM -0400, Frank Li wrote:
> On Tue, Aug 19, 2025 at 10:43:37AM +0800, Haibo Chen wrote:
> > 1, the phy support up to 8Mbit/s databitrate for CAN FD.
> >    refer to product data sheet:
> >      https://www.nxp.com/docs/en/data-sheet/TJA1463.pdf
> > 2, the standby pin of the phy is ACTIVE_LOW.
> > 3, the phy of flexcan2 connect the standby/en pin to PCAL6408 on i2c4 bus.
> >
> > Fixes: 02b7adb791e1 ("arm64: dts: imx95-19x19-evk: add adc0 flexcan[1,2] i2c[2,3] uart5 spi3 and tpm3")
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > index 2f949a0d48d2d8066388884703c3b3cd678f16e1..9d034275c847606919af8ee4a80a00599abf4d8b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > @@ -80,17 +80,17 @@ linux_cma: linux,cma {
> >  	flexcan1_phy: can-phy0 {
> >  		compatible = "nxp,tjr1443";
> >  		#phy-cells = <0>;
> > -		max-bitrate = <1000000>;
> > +		max-bitrate = <8000000>;
> >  		enable-gpios = <&i2c6_pcal6416 6 GPIO_ACTIVE_HIGH>;
> > -		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_HIGH>;
> > +		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_LOW>;
>
> It use go though CAN phy.

Sorry, I mass up. It is correct.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> Frank
> >  	};
> >
> >  	flexcan2_phy: can-phy1 {
> >  		compatible = "nxp,tjr1443";
> >  		#phy-cells = <0>;
> > -		max-bitrate = <1000000>;
> > -		enable-gpios = <&i2c6_pcal6416 4 GPIO_ACTIVE_HIGH>;
> > -		standby-gpios = <&i2c6_pcal6416 3 GPIO_ACTIVE_HIGH>;
> > +		max-bitrate = <8000000>;
> > +		enable-gpios = <&i2c4_gpio_expander_21 4 GPIO_ACTIVE_HIGH>;
> > +		standby-gpios = <&i2c4_gpio_expander_21 3 GPIO_ACTIVE_LOW>;
> >  	};
> >
> >  	reg_vref_1v8: regulator-1p8v {
> >
> > ---
> > base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> > change-id: 20250819-can-dts-fix-62ac1d02c007
> >
> > Best regards,
> > --
> > Haibo Chen <haibo.chen@nxp.com>
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2
  2025-08-19  2:43 [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2 Haibo Chen
  2025-08-19 15:50 ` Frank Li
@ 2025-08-22  9:19 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2025-08-22  9:19 UTC (permalink / raw)
  To: Haibo Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
	Frank Li, devicetree, imx, linux-arm-kernel, linux-kernel

On Tue, Aug 19, 2025 at 10:43:37AM +0800, Haibo Chen wrote:
> 1, the phy support up to 8Mbit/s databitrate for CAN FD.
>    refer to product data sheet:
>      https://www.nxp.com/docs/en/data-sheet/TJA1463.pdf
> 2, the standby pin of the phy is ACTIVE_LOW.
> 3, the phy of flexcan2 connect the standby/en pin to PCAL6408 on i2c4 bus.
> 
> Fixes: 02b7adb791e1 ("arm64: dts: imx95-19x19-evk: add adc0 flexcan[1,2] i2c[2,3] uart5 spi3 and tpm3")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-22  9:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19  2:43 [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2 Haibo Chen
2025-08-19 15:50 ` Frank Li
2025-08-21 15:03   ` Frank Li
2025-08-22  9:19 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).